[Bug 207710] New: Crash while loading large file

https://bugs.kde.org/show_bug.cgi?id=207710


Jens Wilmer <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[hidden email]




--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

https://bugs.kde.org/show_bug.cgi?id=207710





--- Comment #18 from Jens Wilmer <kde_bugs jenswilmer de>  2010-07-08 14:35:41 ---
Created an attachment (id=48689)
 --> (http://bugs.kde.org/attachment.cgi?id=48689)
New crash information added by DrKonqi

reproducible crash when rebuilding fingerprints. There are corrupted Images due
to an ubuntu kernel failure silently corrupting the raid until all backups
where affected

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Johannes Wienke-3]

https://bugs.kde.org/show_bug.cgi?id=207710


Johannes Wienke <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[hidden email]




--- Comment #19 from Johannes Wienke <languitar semipol de>  2010-08-02 10:13:30 ---
*** Bug 246488 has been marked as a duplicate of this bug. ***

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Johannes Wienke-3]

https://bugs.kde.org/show_bug.cgi?id=207710


Johannes Wienke <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[hidden email]




--- Comment #20 from Johannes Wienke <languitar semipol de>  2010-08-02 12:54:57 ---
*** Bug 246500 has been marked as a duplicate of this bug. ***

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Johannes Wienke-3]

https://bugs.kde.org/show_bug.cgi?id=207710


Johannes Wienke <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Priority|NOR                         |HI
          Component|general                     |general
            Version|1.1.0                       |1.4.0
            Product|showfoto                    |digikam




--- Comment #21 from Johannes Wienke <languitar semipol de>  2010-08-02 12:56:14 ---
We really need to get these scaling crashes fixed. I've increased the priority.

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Johannes Wienke-3]

https://bugs.kde.org/show_bug.cgi?id=207710





--- Comment #22 from Johannes Wienke <languitar semipol de>  2010-08-03 21:29:52 ---
*** Bug 246635 has been marked as a duplicate of this bug. ***

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=207710





--- Comment #23 from Gilles Caulier <caulier gilles gmail com>  2010-08-17 11:12:27 ---
Using : http://pub.lindenmeier.com/360Paris.jpg

Loading to showfoto and swith on Fit To Screen zoom option crash the program :

#0  0xb7be24a4 in Digikam::DImgScale::dimgScaleAARGB (isi=0x91b9e38,
dest=0x93dbbf8, dxx=0, dyy=0, dx=0, dy=0, dw=128, dh=
    35, dow=128, sow=36678) at
/home/gilles/Documents/Devel/SVN/trunk/graphics/digikam/libs/dimg/dimgscale.cpp:1211
#1  0xb7bdeea4 in Digikam::DImg::smoothScaleSection (this=0x81f0004, sx=0,
sy=0, sw=6153, sh=1686, dw=128, dh=35)
    at
/home/gilles/Documents/Devel/SVN/trunk/graphics/digikam/libs/dimg/dimgscale.cpp:261
#2  0xb7e6f18b in Digikam::DImgInterface::paintOnDevice (this=0x82119a0,
p=0x849cb28, sx=0, sy=0, sw=6153, sh=6153, dx=0, dy=
    0, dw=128, dh=128)
    at
/home/gilles/Documents/Devel/SVN/trunk/graphics/digikam/utilities/imageeditor/canvas/dimginterface.cpp:687
#3  0xb7e7816c in Digikam::Canvas::paintViewport (this=0x8260890, er=...,
antialias=true)
    at
/home/gilles/Documents/Devel/SVN/trunk/graphics/digikam/utilities/imageeditor/canvas/canvas.cpp:647
#4  0xb7e7719c in Digikam::Canvas::viewportPaintEvent (this=0x8260890,
e=0xbfffc3d4)

The image is very large. It's a panoramic view. I suspect a rounding problem
there when scaling down is processed.

Gilles Caulier

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Marcel Wiesweg]

https://bugs.kde.org/show_bug.cgi?id=207710


Marcel Wiesweg <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |218256




--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Marcel Wiesweg]

https://bugs.kde.org/show_bug.cgi?id=207710


Marcel Wiesweg <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[hidden email]




--- Comment #24 from Marcel Wiesweg <marcel wiesweg gmx de>  2010-09-01 16:35:41 ---
*** Bug 249605 has been marked as a duplicate of this bug. ***

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

https://bugs.kde.org/show_bug.cgi?id=207710





--- Comment #25 from Daniel Scharrer <dscharrer gmail com>  2010-09-03 20:55:16 ---
Created an attachment (id=51288)
 --> (http://bugs.kde.org/attachment.cgi?id=51288)
fix overflow in DImgScale::dimgCalc*Points functions for large images

The dimgCalcYPoints dimgCalcYPoints16 dimgCalcXPoints and dimgCalcApoints
functions in libdigikamcore.so (digikam/libs/dimg/dimgscale.cpp) incorrectly
assume that the width and height can be represented by a (signed) int after
being shifted 16 bits to the left. On x86 and amd64 platforms this only leaves
15 Bits: larger width/height values will be shifted into the sign bit. Hence
for images with a width or height greater than 1<<15=32768 the increment will
be negative and hell breaks loose.

This can however be fixed by using a 64-bit type for the temporary values (see
attached patch). The attached patch shouldn't impact performance on 32-bit
platforms too much, as the changes only affect loops over the image (section)
width OR over the height, but not nested loops over all pixels.

With a patched libdigikamcore.so, showFoto will not crash while scaling down
large images to display them.

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=207710





--- Comment #26 from Gilles Caulier <caulier gilles gmail com>  2010-09-03 20:58:03 ---
Thanks a LOTS Daniel for your patch. It's very appreciate.

Marcel, can you take a look to this patch.

I will take a look too this week end. If it fine for you, i will apply it to
svn.

Gilles Caulier

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

https://bugs.kde.org/show_bug.cgi?id=207710





--- Comment #27 from Daniel Scharrer <dscharrer gmail com>  2010-09-03 21:03:12 ---
No problem. I forgot to mention that the "scaling up" part of
DImgScale::dimgCalcApoints still looks fishy to me, especially the "(val >> 8)
- ((val >> 8) & 0xffffff00)" part. Someone who understands the code better than
me should probably have a look at that.

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=207710





--- Comment #28 from Gilles Caulier <caulier gilles gmail com>  2010-09-03 21:07:04 ---
The code have been taken from imlib2 project few year ago by an old digiKam
developper. Nobody in the team understand properly this code.

I can found the original source code if you want

Gilles

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=207710





--- Comment #29 from Gilles Caulier <caulier gilles gmail com>  2010-09-03 21:19:16 ---
Daniel,

Current code of scaled algorithm from imlib2 is there :

http://trac.enlightenment.org/e/browser/trunk/imlib2/src/lib/scale.c

Code have been adapted to support 16 bits color depth images.

Gilles Caulier

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

https://bugs.kde.org/show_bug.cgi?id=207710





--- Comment #30 from Daniel Scharrer <dscharrer gmail com>  2010-09-03 22:03:56 ---
Ok, I'll try to understand the code some more.

Meanwhile, the patch I sent definitely fixes the crash when scaling DOWN large
images. (The imlib2 version still seems to have the same problem.)

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Marcel Wiesweg]

https://bugs.kde.org/show_bug.cgi?id=207710





--- Comment #31 from Marcel Wiesweg <marcel wiesweg gmx de>  2010-09-04 12:25:39 ---
Awesome, thanks a lot.

> No problem. I forgot to mention that the "scaling up" part of
> DImgScale::dimgCalcApoints still looks fishy to me, especially the "(val >> 8)
> - ((val >> 8) & 0xffffff00)" part.
> Someone who understands the code better than
> me should probably have a look at that.

By now, you are officially declared the one and only "he who understands
dimgscale.cpp"

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=207710


Gilles Caulier <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|REOPENED                    |RESOLVED
         Resolution|                            |FIXED




--- Comment #32 from Gilles Caulier <caulier gilles gmail com>  2010-09-05 19:47:04 ---
SVN commit 1171917 by cgilles:

apply patch #51288 from Daniel Scharrer to avoid crash in DImg scale with
panorama images
BUGS: 207710


 M  +12 -11    dimgscale.cpp  


WebSVN link: http://websvn.kde.org/?view=rev&revision=1171917

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=207710


Gilles Caulier <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[hidden email]




--- Comment #33 from Gilles Caulier <caulier gilles gmail com>  2010-09-13 11:36:37 ---
*** Bug 218256 has been marked as a duplicate of this bug. ***

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=207710


Gilles Caulier <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[hidden email]




--- Comment #34 from Gilles Caulier <caulier gilles gmail com>  2010-09-21 15:19:45 ---
*** Bug 251932 has been marked as a duplicate of this bug. ***

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=207710


Gilles Caulier <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[hidden email]




--- Comment #35 from Gilles Caulier <caulier gilles gmail com>  2010-10-06 13:25:51 ---
*** Bug 253382 has been marked as a duplicate of this bug. ***

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel