[Bug 207053] New: Replace current renaming in AlbumUI with ManualRename utility

https://bugs.kde.org/show_bug.cgi?id=207053

           Summary: Replace current renaming in AlbumUI with ManualRename
                    utility
           Product: digikam
           Version: 1.0.0-beta5
          Platform: unspecified
        OS/Version: Linux
            Status: NEW
          Severity: wishlist
          Priority: NOR
         Component: Albums GUI
        AssignedTo: [hidden email]
        ReportedBy: [hidden email]


Version:           1.0.0-beta5 (using 4.3.1 (KDE 4.3.1), Arch Linux)
Compiler:          gcc
OS:                Linux (i686) release 2.6.30-ARCH

Renaming in digiKam is not very intuitive at the moment.
To rename multiple files, you either need to

a) use the KIPI Batchplugins (not very powerful for renaming)
b) use BQM

The problem with b) is that you need to copy the files to a new target folder
first (and apply some batch tool, otherwise BQM doesn't start).
This problem can be solved with a dedicated RenameTool for BQM, which will be
another bugreport.

The general renaming issue could be fixed with a renaming dialog based on the
ManualRename utility, that is used in CameraUI and BQM now.
It is capable of adding a lot of information to the filename, like metadata
etc.

I will provide a patch in this bugreport that will make use of a
ManualRenameDialog widget, that can replace the current renaming method in
AlbumUI.

The only problem at the moment is that it is very slow, I guess because every
rename action will create a separate kio_file process.

Gilles, Marcel,

any idea how to make this faster?
If you use the patch, PLEASE test it only with a few images, not 3000 files or
so :-)

I think this feature is quite important, because renaming with BQM only is
confusing, especially for new users (and at the moment renaming actually isn't
working anyway, it is more a copy action that also requires at least one
assigned tool).

Andi

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

https://bugs.kde.org/show_bug.cgi?id=207053





--- Comment #1 from Andi Clemens <andi clemens gmx net>  2009-09-11 11:00:44 ---
Created an attachment (id=36864)
 --> (http://bugs.kde.org/attachment.cgi?id=36864)
ManualRenameDialog patch

This patch will enable the ManualRenameDialog for AlbumUI

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=207053





--- Comment #2 from Gilles Caulier <caulier gilles gmail com>  2009-09-11 12:06:27 ---
Andi,

I'm agree. Thsi feature is very important !

Do you use DIO method from digiKam core, to rename file, or kio_file process ?

Gilles

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

https://bugs.kde.org/show_bug.cgi?id=207053





--- Comment #3 from Andi Clemens <andi clemens gmx net>  2009-09-11 12:39:27 ---
DIO (actually I just call the old rename method: ImageViewUtilities::rename()),
I only added a second parameter 'newName' to the method.

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

https://bugs.kde.org/show_bug.cgi?id=207053


Andi Clemens <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #36864|0                           |1
        is obsolete|                            |




--- Comment #4 from Andi Clemens <andi clemens gmx net>  2009-09-11 18:51:03 ---
Created an attachment (id=36873)
 --> (http://bugs.kde.org/attachment.cgi?id=36873)
new version against trunk

New version of the patch, since trunk changed the way parsing is done.
Please note that you need to disable the building of tests at the moment,
because ManualRename will not link against digikamcore anymore (I still don't
understand why).

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

https://bugs.kde.org/show_bug.cgi?id=207053


Andi Clemens <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #36873|0                           |1
        is obsolete|                            |




--- Comment #5 from Andi Clemens <andi clemens gmx net>  2009-09-12 17:33:10 ---
Created an attachment (id=36904)
 --> (http://bugs.kde.org/attachment.cgi?id=36904)
3rd update

update against trunk

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

https://bugs.kde.org/show_bug.cgi?id=207053


Andi Clemens <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #36904|0                           |1
        is obsolete|                            |




--- Comment #6 from Andi Clemens <andi clemens gmx net>  2009-09-13 11:46:54 ---
Created an attachment (id=36916)
 --> (http://bugs.kde.org/attachment.cgi?id=36916)
4th update

sync with trunk, a lot changed in there so patch needs some love :)
No new features so far, still the old problem with slow renaming.

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

https://bugs.kde.org/show_bug.cgi?id=207053





--- Comment #7 from Andi Clemens <andi clemens gmx net>  2009-09-13 15:28:47 ---
I just played with renaming in AlbumUI again.
When I rename 88 images with this patch, I get 83 kio_digikamalbums slaves that
are not closed as long as digiKam is running.
Something is going terribly wrong here.

Do I need to do renaming in a different way then by just calling DIO::move()?

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

https://bugs.kde.org/show_bug.cgi?id=207053





--- Comment #8 from Andi Clemens <andi clemens gmx net>  2009-09-13 15:29:24 ---
DIO::rename I mean of course

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

https://bugs.kde.org/show_bug.cgi?id=207053





--- Comment #9 from Andi Clemens <andi clemens gmx net>  2009-09-13 15:32:51 ---
Just realized something else: I also have 64 kio_file slaves open, and they
don't close even digiKam is shut down.
I can only kill them by hand.

Calling DIO::rename() multiple times doesn't seem to be the right way.
I know there is a move() method for multiple files, the problem is that it has
a single target, so it is not suitable for renaming tasks.

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

https://bugs.kde.org/show_bug.cgi?id=207053


Andi Clemens <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #36916|0                           |1
        is obsolete|                            |




--- Comment #10 from Andi Clemens <andi clemens gmx net>  2009-09-15 12:27:38 ---
Created an attachment (id=36970)
 --> (http://bugs.kde.org/attachment.cgi?id=36970)
patch against new modifier code

sync with trunk

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=207053





--- Comment #11 from Gilles Caulier <caulier gilles gmail com>  2009-09-15 13:03:00 ---
Looking in your patch, how do you process files renaming in background ?

Why not to use a separate thread running KDE::rename() trough a queued list of
items to process one by one ?

Gilles

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

https://bugs.kde.org/show_bug.cgi?id=207053





--- Comment #12 from Andi Clemens <andi clemens gmx net>  2009-09-15 13:18:11 ---
Oh, never had a look at KDE::rename. I will check this later.

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=207053


Gilles Caulier <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[hidden email]




--- Comment #13 from Gilles Caulier <caulier gilles gmail com>  2009-09-15 13:25:32 ---
Image Editor already use it. Look there :

http://lxr.kde.org/source/extragear/graphics/digikam/utilities/imageeditor/editor
/editorwindow.cpp#1762

Gilles

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

https://bugs.kde.org/show_bug.cgi?id=207053


Andi Clemens <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #36970|0                           |1
        is obsolete|                            |




--- Comment #14 from Andi Clemens <andi clemens gmx net>  2009-09-16 19:00:27 ---
Created an attachment (id=36998)
 --> (http://bugs.kde.org/attachment.cgi?id=36998)
threaded version

I added a thread but I'm not sure if I use it correctly, never done this
before.
Could you please take a look at
RenameThread() and its interaction with ImageViewUtilities()?

Andi

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

https://bugs.kde.org/show_bug.cgi?id=207053





--- Comment #15 from Andi Clemens <andi clemens gmx net>  2009-09-18 18:12:17 ---
Created an attachment (id=37041)
 --> (http://bugs.kde.org/attachment.cgi?id=37041)
tool was renamed, sync with trunk

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

https://bugs.kde.org/show_bug.cgi?id=207053


Andi Clemens <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|Replace current renaming in |Replace current renaming in
                   |AlbumUI with ManualRename   |AlbumUI with AdvancedRename
                   |utility                     |utility




--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Bartek Pietrasiak]

https://bugs.kde.org/show_bug.cgi?id=207053


Bartek Pietrasiak <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[hidden email]




--- Comment #16 from Bartek Pietrasiak <pietras sp gmail com>  2009-09-29 10:40:25 ---
One remark. I would be nice if the same renamame dialog would be used during
import from camera. I can remember that in 0.9 the rename during import was not
able to handle my simple pattern so I had to do this after import with normal
digikam rename.

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

https://bugs.kde.org/show_bug.cgi?id=207053





--- Comment #17 from Andi Clemens <andi clemens gmx net>  2009-09-29 10:44:10 ---
The new renaming tool is used in CameraUI (import) and BQM (Batch Queue
Manager) for months :-)
It was not used in the main application due to threading problems (that in some
way still exist, but at least renaming is working now).

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

https://bugs.kde.org/show_bug.cgi?id=207053


Andi Clemens <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|                            |FIXED




--- Comment #18 from Andi Clemens <andi clemens gmx net>  2009-09-29 10:45:37 ---
Since I committed everything (and only some minor tweaks have to be made), I
will close this wish now.

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel