[Bug 203485] New: consider using KGlobalSettings::picturesPath() instead of KGlobalSettings::documentPath()

classic Classic list List threaded Threaded
6 messages Options
Reply | Threaded
Open this post in threaded view
|

[Bug 203485] New: consider using KGlobalSettings::picturesPath() instead of KGlobalSettings::documentPath()

Bugzilla from yoho_ahoy@hotmail.com
https://bugs.kde.org/show_bug.cgi?id=203485

           Summary: consider using KGlobalSettings::picturesPath() instead
                    of KGlobalSettings::documentPath()
           Product: digikam
           Version: unspecified
          Platform: Compiled Sources
        OS/Version: unspecified
            Status: UNCONFIRMED
          Severity: wishlist
          Priority: NOR
         Component: general
        AssignedTo: [hidden email]
        ReportedBy: [hidden email]


Version:            (using Devel)
Installed from:    Compiled sources

I've set up xdg-user-dirs (Video, Documents, Pictures, etc.) on my system and
am interested at how well they are integrated in kde. I see that they are
provided by KGlobalSettings and looked on lxr to see what uses them.

Currently, KGlobalSettings::documentPath() has a lot of users in digikam,
showfoto and kipi-plugins. Would KGlobalSettings::picturesPath() be more
appropriate in some of these cases?

See http://lxr.kde.org/search?string=documentPath%28%29 for examples. (These
results are from trunk,  I guess that's where digikam development is. I don't
know if there's a good permanent url, this will always show current users.)

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel
Reply | Threaded
Open this post in threaded view
|

[Bug 203485] consider using KGlobalSettings::picturesPath() instead of KGlobalSettings::documentPath()

Rex Dieter
https://bugs.kde.org/show_bug.cgi?id=203485


Rex Dieter <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[hidden email]




--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel
Reply | Threaded
Open this post in threaded view
|

[Bug 203485] consider using KGlobalSettings::picturesPath() instead of KGlobalSettings::documentPath()

Gilles Caulier-4
In reply to this post by Bugzilla from yoho_ahoy@hotmail.com
https://bugs.kde.org/show_bug.cgi?id=203485


Gilles Caulier <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Version|unspecified                 |1.0.0




--- Comment #1 from Gilles Caulier <caulier gilles gmail com>  2009-08-12 11:07:42 ---
I'm agree to use picture path by default, but the question is : which KDE
version include this settings to picture path ?

Another question is : digiKam can drive video too. what we can do with video
path settings from KDE ?

Gilles Caulier

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel
Reply | Threaded
Open this post in threaded view
|

[Bug 203485] consider using KGlobalSettings::picturesPath() instead of KGlobalSettings::documentPath()

Marcel Wiesweg
In reply to this post by Bugzilla from yoho_ahoy@hotmail.com
https://bugs.kde.org/show_bug.cgi?id=203485


Marcel Wiesweg <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[hidden email]




--- Comment #2 from Marcel Wiesweg <marcel wiesweg gmx de>  2009-08-12 19:14:08 ---
For the default collection path we already use picturesPath()
(utilities/firstrun/collectionpage.cpp).
Most places where we use documentPath() are located in the image plugins, I
assume for storing settings. I guess it's appropriate for this purpose.
One occurrence in digikamapp.cpp (location for importing) should be changed to
picturesPath. Same probably for showfoto.cpp.

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel
Reply | Threaded
Open this post in threaded view
|

[Bug 203485] consider using KGlobalSettings::picturesPath() instead of KGlobalSettings::documentPath()

Marcel Wiesweg
In reply to this post by Bugzilla from yoho_ahoy@hotmail.com
https://bugs.kde.org/show_bug.cgi?id=203485


Marcel Wiesweg <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |RESOLVED
         Resolution|                            |FIXED




--- Comment #3 from Marcel Wiesweg <marcel wiesweg gmx de>  2009-09-26 18:06:22 ---
SVN commit 1028318 by mwiesweg:

Replace two occurences of documentPath() with picturesPath().
For the remaining occurences documentPath() is suitable because it is not about
pictures,
but tool settings.

BUG: 203485

 M  +3 -1      NEWS  
 M  +7 -1      digikam/digikamapp.cpp  
 M  +10 -2     showfoto/showfoto.cpp  


WebSVN link: http://websvn.kde.org/?view=rev&revision=1028318

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel
Reply | Threaded
Open this post in threaded view
|

[digikam] [Bug 203485] consider using KGlobalSettings::picturesPath() instead of KGlobalSettings::documentPath()

bugzilla_noreply
In reply to this post by Bugzilla from yoho_ahoy@hotmail.com
https://bugs.kde.org/show_bug.cgi?id=203485

[hidden email] changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
          Component|general                     |setup
                 CC|                            |[hidden email]

--
You are receiving this mail because:
You are the assignee for the bug.