[Bug 201717] New: Changing rating filter when images are selected, select all images between first and last selected image

classic Classic list List threaded Threaded
10 messages Options
Reply | Threaded
Open this post in threaded view
|

[Bug 201717] New: Changing rating filter when images are selected, select all images between first and last selected image

Bugzilla from kde_bugs@hubbertz.de
https://bugs.kde.org/show_bug.cgi?id=201717

           Summary: Changing rating filter when images are selected,
                    select all images between first and last selected
                    image
           Product: digikam
           Version: 1.0.0-beta3
          Platform: Gentoo Packages
        OS/Version: unspecified
            Status: UNCONFIRMED
          Severity: normal
          Priority: NOR
         Component: general
        AssignedTo: [hidden email]
        ReportedBy: [hidden email]


Version:           1.0.0-beta3 (using KDE 4.2.98)
Installed from:    Gentoo Packages

Steps to reproduce:

1. Activate rating filter (e.g. 4 stars)
2. Select All Images
3. Change rating filter (e.g. 3 stars)

--> Result: All images between (and including) the first and the last image
with 4 stars are selected.

--> Expected behaviour: Selection should not change

--> Notes & Workaround: The problem only occurs if "All Images" (Strg-A or
dragging a mouse selection recatnagle over all images) have been selected. So,
as workaroung, select all images, deselect one and select it again. Then the
rating filter can be changed without problems.

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel
Reply | Threaded
Open this post in threaded view
|

[Bug 201717] Changing rating filter when images are selected, select all images between first and last selected image

Gilles Caulier-4
https://bugs.kde.org/show_bug.cgi?id=201717


Gilles Caulier <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[hidden email]
          Component|general                     |Albums GUI
               Flag|                            |Qt4ModelView+




--- Comment #1 from Gilles Caulier <caulier gilles gmail com>  2009-07-28 06:33:24 ---
It's relevant of new Qt4 model/View code...

Gilles Caulier

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel
Reply | Threaded
Open this post in threaded view
|

[Bug 201717] Changing rating filter when images are selected, select all images between first and last selected image

Marcel Wiesweg
In reply to this post by Bugzilla from kde_bugs@hubbertz.de
https://bugs.kde.org/show_bug.cgi?id=201717





--- Comment #2 from Marcel Wiesweg <marcel wiesweg gmx de>  2009-07-28 22:07:22 ---
This is indeep a Qt problem. See this code from QItemSelectionModel:

void QItemSelectionModelPrivate::_q_layoutAboutToBeChanged()
{
    savedPersistentIndexes.clear();
    savedPersistentCurrentIndexes.clear();

    // special case for when all indexes are selected
    if (ranges.isEmpty() && currentSelection.count() == 1) {
        QItemSelectionRange range = currentSelection.first();
        QModelIndex parent = range.parent();
        if (range.top() == 0
            && range.left() == 0
            && range.bottom() == model->rowCount(parent) - 1
            && range.right() == model->columnCount(parent) - 1) {
            tableSelected = true;
            tableParent = parent;
            tableColCount = model->columnCount(parent);
            tableRowCount = model->rowCount(parent);
            return;
        }
    }
...
}

void QItemSelectionModelPrivate::_q_layoutChanged()
{
    // special case for when all indexes are selected
    if (tableSelected && tableColCount == model->columnCount(tableParent)
        && tableRowCount == model->rowCount(tableParent)) {
        ...
    }

    if (savedPersistentCurrentIndexes.isEmpty() &&
savedPersistentIndexes.isEmpty()) {
        // either the selection was actually empty, or we
        // didn't get the layoutAboutToBeChanged() signal
        return;
    }
...
}

The "special case" is hit in the first method when storing the indexes. In the
second method for restoring the selection, the special case is not met, and no
indexes have been saved in the savedPersistentIndexes list.

1) For what purpose is this special case added?
2) File a Qt bug?

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel
Reply | Threaded
Open this post in threaded view
|

[Bug 201717] Changing rating filter when images are selected, select all images between first and last selected image

Marcel Wiesweg
In reply to this post by Bugzilla from kde_bugs@hubbertz.de
https://bugs.kde.org/show_bug.cgi?id=201717





--- Comment #3 from Marcel Wiesweg <marcel wiesweg gmx de>  2009-08-03 18:48:05 ---
Posted to Qt task tracker with number 259089.

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel
Reply | Threaded
Open this post in threaded view
|

[Bug 201717] Changing rating filter when images are selected, select all images between first and last selected image

Marcel Wiesweg
In reply to this post by Bugzilla from kde_bugs@hubbertz.de
https://bugs.kde.org/show_bug.cgi?id=201717





--- Comment #4 from Marcel Wiesweg <marcel wiesweg gmx de>  2009-08-25 18:01:03 ---
Now it really got added as a task with number 260134.

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel
Reply | Threaded
Open this post in threaded view
|

[Bug 201717] Changing rating filter when images are selected, select all images between first and last selected image

Bugzilla from ragnarokk91@gmail.com
In reply to this post by Bugzilla from kde_bugs@hubbertz.de
https://bugs.kde.org/show_bug.cgi?id=201717





--- Comment #5 from Ignat Semenov <ragnarokk91 gmail com>  2009-10-31 15:20:48 ---
Now it has been fixed in Qt 4.6:
http://qt.nokia.com/developer/task-tracker/index_html?method=entry&id=260134
KDE 4.4 depends on Qt 4.6. Does that mean that this should be closed?
It work sfine now with Qt 4.6 trunk and Digikam trunk.

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel
Reply | Threaded
Open this post in threaded view
|

[Bug 201717] Changing rating filter when images are selected, select all images between first and last selected image

Gilles Caulier-4
In reply to this post by Bugzilla from kde_bugs@hubbertz.de
https://bugs.kde.org/show_bug.cgi?id=201717


Gilles Caulier <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
          Component|Albums GUI                  |Filter




--- Comment #6 from Gilles Caulier <caulier gilles gmail com>  2009-10-31 15:40:07 ---
For me it can be closed....

Marcel Andi, do you have a fix in digiKam for Qt4 < 4.6 ?

Gilles

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel
Reply | Threaded
Open this post in threaded view
|

[Bug 201717] Changing rating filter when images are selected, select all images between first and last selected image

Bugzilla from andi.clemens@gmx.net
In reply to this post by Bugzilla from kde_bugs@hubbertz.de
https://bugs.kde.org/show_bug.cgi?id=201717





--- Comment #7 from Andi Clemens <andi clemens gmx net>  2009-10-31 15:44:58 ---
No, because this is an indeep Qt problem. If it is really fixed now, we can
ignore the bugreport.
At least I don't feel like fixing bugs for Nokia right now :-)

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel
Reply | Threaded
Open this post in threaded view
|

[Bug 201717] Changing rating filter when images are selected, select all images between first and last selected image

Gilles Caulier-4
In reply to this post by Bugzilla from kde_bugs@hubbertz.de
https://bugs.kde.org/show_bug.cgi?id=201717


Gilles Caulier <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |RESOLVED
         Resolution|                            |FIXED




--- Comment #8 from Gilles Caulier <caulier gilles gmail com>  2009-10-31 15:48:12 ---
Right. well closed...

Gilles

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel
Reply | Threaded
Open this post in threaded view
|

[Bug 201717] Changing rating filter when images are selected, select all images between first and last selected image

Gilles Caulier-4
In reply to this post by Bugzilla from kde_bugs@hubbertz.de
https://bugs.kde.org/show_bug.cgi?id=201717


Gilles Caulier <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Version|1.0.0-beta3                 |1.0.0




--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel