[Bug 200854] New: Option to clear light table on close [PATCH]

classic Classic list List threaded Threaded
6 messages Options
Reply | Threaded
Open this post in threaded view
|

[Bug 200854] New: Option to clear light table on close [PATCH]

Bugzilla from p.edelman@gmx.net
https://bugs.kde.org/show_bug.cgi?id=200854

           Summary: Option to clear light table on close [PATCH]
           Product: digikam
           Version: unspecified
          Platform: Unlisted Binaries
        OS/Version: unspecified
            Status: UNCONFIRMED
          Severity: wishlist
          Priority: NOR
         Component: general
        AssignedTo: [hidden email]
        ReportedBy: [hidden email]


Version:            (using KDE 4.2.4)
Installed from:    Unspecified Linux

When I close the light table, it is usually because I am done using it for the
current batch of (similar) photos. I also usually forget to clear it when I'm
done :) The result is that when I add a new batch of photos to the light table,
the old one is still present.

I've attached a simple patch that adds a configuration option to clear the
light table automatically when the user closes it. This option is present in
the Digikam configuration menu and can be added to the light table toolbar.

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel
Reply | Threaded
Open this post in threaded view
|

[Bug 200854] Option to clear light table on close [PATCH]

Bugzilla from p.edelman@gmx.net
https://bugs.kde.org/show_bug.cgi?id=200854





--- Comment #1 from Pieter Edelman <p edelman gmx net>  2009-07-20 12:58:05 ---
Created an attachment (id=35477)
 --> (http://bugs.kde.org/attachment.cgi?id=35477)
Option to clear light table on close

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel
Reply | Threaded
Open this post in threaded view
|

[Bug 200854] Option to clear light table on close [PATCH]

Gilles Caulier-4
In reply to this post by Bugzilla from p.edelman@gmx.net
https://bugs.kde.org/show_bug.cgi?id=200854


Gilles Caulier <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
          Component|general                     |Light Table
            Version|unspecified                 |0.10.0




--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel
Reply | Threaded
Open this post in threaded view
|

[Bug 200854] Option to clear light table on close [PATCH]

Gilles Caulier-4
In reply to this post by Bugzilla from p.edelman@gmx.net
https://bugs.kde.org/show_bug.cgi?id=200854





--- Comment #2 from Gilles Caulier <caulier gilles gmail com>  2009-07-20 13:21:26 ---
Pieter,

I'm agrre to add this option (i thinking to do the same in fact)

But the option must going on Light Table setup panel, not LT configuration
menu. We need to still coherent here. Look setup LT code :

http://lxr.kde.org/source/extragear/graphics/digikam/utilities/setup/setuplighttable.cpp

Note : Your patch need to be built against code from svn trunk.

Thanks in advance for your contrib...

Gilles Caulier

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel
Reply | Threaded
Open this post in threaded view
|

[Bug 200854] Option to clear light table on close [PATCH]

Bugzilla from p.edelman@gmx.net
In reply to this post by Bugzilla from p.edelman@gmx.net
https://bugs.kde.org/show_bug.cgi?id=200854





--- Comment #3 from Pieter Edelman <p edelman gmx net>  2009-07-20 13:52:10 ---
Ok, thanks for the feedback.

The option actually is in the setup panel (Settings->Configure digiKam and then
selecting Light Table), but I made it available from the toolbar as well. I can
remove that, please let me know.

The patch is against the latest SVN trunk.

Pieter

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel
Reply | Threaded
Open this post in threaded view
|

[Bug 200854] Option to clear light table on close [PATCH]

Gilles Caulier-4
In reply to this post by Bugzilla from p.edelman@gmx.net
https://bugs.kde.org/show_bug.cgi?id=200854


Gilles Caulier <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |RESOLVED
         Resolution|                            |FIXED




--- Comment #4 from Gilles Caulier <caulier gilles gmail com>  2009-07-20 14:02:13 ---
SVN commit 999717 by cgilles:

apply patch from Pieter Edelman to clear Light Table contents on close event.
BUGS: 200854


 M  +10 -0     lighttable/lighttablewindow.cpp  
 M  +2 -0      lighttable/lighttablewindow_p.h  
 M  +12 -1     setup/setuplighttable.cpp  


WebSVN link: http://websvn.kde.org/?view=rev&revision=999717

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel