[Bug 197817] New: digiKam should utilize _icc_profile X property

[Milan Knizek]

https://bugs.kde.org/show_bug.cgi?id=197817

           Summary: digiKam should utilize _icc_profile X property
           Product: digikam
           Version: 0.10.0
          Platform: Ubuntu Packages
        OS/Version: Linux
            Status: UNCONFIRMED
          Severity: wishlist
          Priority: NOR
         Component: general
        AssignedTo: [hidden email]
        ReportedBy: [hidden email]


Version:           0.10.0 (using KDE 4.2.2)
OS:                Linux
Installed from:    Ubuntu Packages

When colour management is enabled and user specifically wishes so, digiKam
should utilise _icc_profile property of X server, if exists.

If not, then it should fallback to user predefined display profile.

Refer to

http://burtonini.com/blog/computers/xicc

http://www.oyranos.org/wiki/index.php?title=ICC_Profiles_in_X_Specification_0.2

for more details.

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=197817


Gilles Caulier <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
          Component|general                     |Color Management




--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Marcel Wiesweg]

https://bugs.kde.org/show_bug.cgi?id=197817





--- Comment #1 from Marcel Wiesweg <marcel wiesweg gmx de>  2009-08-31 20:30:22 ---
SVN commit 1017858 by mwiesweg:

Implementation to read ICC profiles set system-wide according to ICC profiles
from X specification. Code taken gratefully from KOffice.

CCBUG: 197817

 M  +4 -0      digikam/CMakeLists.txt  
 M  +76 -0     utilities/imageeditor/canvas/iccsettings.cpp  


WebSVN link: http://websvn.kde.org/?view=rev&revision=1017858

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Marcel Wiesweg]

https://bugs.kde.org/show_bug.cgi?id=197817





--- Comment #2 from Marcel Wiesweg <marcel wiesweg gmx de>  2009-08-31 20:30:27 ---
SVN commit 1017859 by mwiesweg:

Use profile returned from window system.
Cache profile per screen (if set or not set).
Marked as TODO for Windows and Mac (dont know the situation there).

CCBUG: 197817

 M  +28 -5     iccsettings.cpp  


WebSVN link: http://websvn.kde.org/?view=rev&revision=1017859

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Marcel Wiesweg]

https://bugs.kde.org/show_bug.cgi?id=197817


Marcel Wiesweg <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[hidden email]




--- Comment #3 from Marcel Wiesweg <marcel wiesweg gmx de>  2009-08-31 20:31:14 ---
Any hint how to test this (that is, how to set such a profile)?

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Milan Knizek]

https://bugs.kde.org/show_bug.cgi?id=197817





--- Comment #4 from Milan Knizek <knizek volny cz>  2009-08-31 22:06:53 ---
@Marcel
To set the property (you can use sRGB.icm for testing):
$ xicc /path/to/your/profiles/display_profile.icm

To check if it was set:
$ xprop -root | grep _ICC_PROFILE

The output should be a lot of numbers. If empty, then something's wrong.

There are also other tools (dispwin) which do more things at once: load VCGT to
calibrate the monitor (video card, actually) and also set the profile to X
property.

I will test myself - probably during the weekend.

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Milan Knizek]

https://bugs.kde.org/show_bug.cgi?id=197817





--- Comment #5 from Milan Knizek <knizek volny cz>  2009-09-05 14:00:43 ---
Created an attachment (id=36718)
 --> (http://bugs.kde.org/attachment.cgi?id=36718)
_ICC_PROFILE not recognised by digiKam

While there are no options for getting the system monitor profile in the
Settings, I assume it is supposed to work silently in the background.

However, it seems that _ICC_PROFILE property is ignored (digiKam svn 1020162,
kipi-plugins 0.6.0, kde-4.2.2 in Ubuntu x64).

I used BRG.icc as the monitor profile set with xicc and sRGB as a monitor
profile in digiKam Settings. If _ICC_PROFILE had priority above digiKam
Settings, the images would be displayed with swapped colour channels like with
EoG in the attachment.

Setting BRG.icc manually in the digiKam Settings works as expected -> ie.
channels are swapped.

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Marcel Wiesweg]

https://bugs.kde.org/show_bug.cgi?id=197817





--- Comment #6 from Marcel Wiesweg <marcel wiesweg gmx de>  2009-09-05 18:31:41 ---
SVN commit 1020214 by mwiesweg:

Use _ICC_PROFILE as atom name. The specification itself says it is
_ICC_Profile,
but though it should be right per definition (because it _is_ the
specification),
obviously it's wrong, at least dispwin uses _ICC_PROFILE.

CCBUG: 197817

 M  +8 -5      iccsettings.cpp  


WebSVN link: http://websvn.kde.org/?view=rev&revision=1020214

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Marcel Wiesweg]

https://bugs.kde.org/show_bug.cgi?id=197817





--- Comment #7 from Marcel Wiesweg <marcel wiesweg gmx de>  2009-09-05 18:33:25 ---
From where do I get this "xicc" tool? Dispwin completely messed up my display
here and refuses to uninstall the profile it installed, and gives errors for
every operation.

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Milan Knizek]

https://bugs.kde.org/show_bug.cgi?id=197817





--- Comment #8 from Milan Knizek <knizek volny cz>  2009-09-05 19:07:46 ---
It is part of the Ubuntu universe repository (Debian, too?). I am not sure, who
actually maintains the code now, but a tar ball can be obtained here:

http://packages.ubuntu.com/jaunty/xicc

or directly at

http://archive.ubuntu.com/ubuntu/pool/universe/x/xicc/xicc_0.2.orig.tar.gz

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Milan Knizek]

https://bugs.kde.org/show_bug.cgi?id=197817





--- Comment #9 from Milan Knizek <knizek volny cz>  2009-09-05 21:25:18 ---
digiKam svn 1020214: it works now as expected. Thanks, Marcel.

As regards GUI: it would be nice to let the user know that digiKam found the
"system" profile. E.g. the settings for the display profile could be greyed out
and some message displayed instead.

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Marcel Wiesweg]

https://bugs.kde.org/show_bug.cgi?id=197817





--- Comment #10 from Marcel Wiesweg <marcel wiesweg gmx de>  2009-09-11 18:32:25 ---
SVN commit 1022381 by mwiesweg:

Signal in setup when system-wide monitor profile is set.

CCBUG: 197817

 M  +20 -1     imageeditor/canvas/iccsettings.cpp  
 M  +10 -2     imageeditor/canvas/iccsettings.h  
 M  +10 -2     setup/setupicc.cpp  


WebSVN link: http://websvn.kde.org/?view=rev&revision=1022381

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Milan Knizek]

https://bugs.kde.org/show_bug.cgi?id=197817





--- Comment #11 from Milan Knizek <knizek volny cz>  2009-09-13 10:28:02 ---
Now it is fine, unless some one else objects it, I would consider this for
SOLVED.

Thanks again, Marcel.

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=197817


Gilles Caulier <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |RESOLVED
                 CC|                            |[hidden email]
         Resolution|                            |FIXED




--- Comment #12 from Gilles Caulier <caulier gilles gmail com>  2009-09-13 11:08:15 ---
Thanks for the feedback. I close this file now...

Gilles Caulier

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel