[Bug 196927] New: No easy way to expand or collapse deep tag hierarchies

classic Classic list List threaded Threaded
35 messages Options
12
Reply | Threaded
Open this post in threaded view
|

[Bug 196927] New: No easy way to expand or collapse deep tag hierarchies

Bugzilla from dkde@gardnersworld.org
https://bugs.kde.org/show_bug.cgi?id=196927

           Summary: No easy way to expand or collapse deep tag hierarchies
           Product: digikam
           Version: 0.10.0
          Platform: Ubuntu Packages
        OS/Version: Linux
            Status: UNCONFIRMED
          Severity: wishlist
          Priority: NOR
         Component: general
        AssignedTo: [hidden email]
        ReportedBy: [hidden email]


Version:           0.10.0 (using KDE 4.2.4)
OS:                Linux
Installed from:    Ubuntu Packages

My tag hierarchy is up to five levels deep in parts and can have
many tags at each level. It would be much easier to expand and
collapse tags in the tree to display a subset of the tags relevant
to my latest set of untagged photographs if I could right-click on
a tag and select "Collapse All" and "Expand All" to collapse or
expand all tags at all levels beneath that tag.

For example, I have a "Places" tag that contains country tags and
the country tags contain city tags. When I start up digiKam, it
takes me a while to collapse all of the country tags except the
one country tag I want for the moment. Doing this shortens the
distance I have to scroll up or down to other parts of the tag
tree or eliminates the need to scroll.

I would like to be able to right-click on the "Places" tag and
select "Collapse All", then expand "Places" normally to see just
the unexpanded country tags instead of the extra level of city
tags for every country. Then I can just expand the single country
tag I want and the tree will be nice and compact in just three
clicks instead of about twenty clicks.

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel
Reply | Threaded
Open this post in threaded view
|

[Bug 196927] No easy way to expand or collapse deep tag hierarchies

Gilles Caulier-4
https://bugs.kde.org/show_bug.cgi?id=196927


Gilles Caulier <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
          Component|general                     |Tags




--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel
Reply | Threaded
Open this post in threaded view
|

[Bug 196927] No easy way to expand or collapse deep tag hierarchies

Bugzilla from zeus2k@gmx.net
In reply to this post by Bugzilla from dkde@gardnersworld.org
https://bugs.kde.org/show_bug.cgi?id=196927





--- Comment #1 from  <zeus2k gmx net>  2009-10-10 17:15:52 ---
Created an attachment (id=37495)
 --> (http://bugs.kde.org/attachment.cgi?id=37495)
Patch to add "Expand All Children" and "Collapse All Children" menu items to
tag and album trees

This is my first shot at this, I tried to follow the guidelines, but please
direct me in the right direction if something's wrong.
How does this work? Does someone put this in SVN if it works correctly?
Sorry about all the questions, I hope it helps nonetheless.

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel
Reply | Threaded
Open this post in threaded view
|

[Bug 196927] No easy way to expand or collapse deep tag hierarchies

Gilles Caulier-4
In reply to this post by Bugzilla from dkde@gardnersworld.org
https://bugs.kde.org/show_bug.cgi?id=196927


Gilles Caulier <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[hidden email]




--- Comment #2 from Gilles Caulier <caulier gilles gmail com>  2009-10-10 18:09:43 ---
Yes, you use the right way.

Post your patch in Bugzilla file, built against svn trunk.

Someone from team will review it and test. If all is fine, code will be
commited to trunk.

Gilles Caulier

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel
Reply | Threaded
Open this post in threaded view
|

[Bug 196927] No easy way to expand or collapse deep tag hierarchies

Bugzilla from dkde@gardnersworld.org
In reply to this post by Bugzilla from dkde@gardnersworld.org
https://bugs.kde.org/show_bug.cgi?id=196927





--- Comment #3 from DGardner <dkde gardnersworld org>  2009-12-09 21:28:31 ---
No sign of this patch in RC1. In the meantime, if you select
"Tags already assigned" and then unselect it, all of the
tags in the tree will now be collapsed. I suppose it's a
bug that serves a useful purpose for some.

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel
Reply | Threaded
Open this post in threaded view
|

[Bug 196927] No easy way to expand or collapse deep tag hierarchies [patch]

Gilles Caulier-4
In reply to this post by Bugzilla from dkde@gardnersworld.org
https://bugs.kde.org/show_bug.cgi?id=196927


Gilles Caulier <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|No easy way to expand or    |No easy way to expand or
                   |collapse deep tag           |collapse deep tag
                   |hierarchies                 |hierarchies [patch]




--- Comment #4 from Gilles Caulier <caulier gilles gmail com>  2011-12-16 13:01:17 ---
Bastian,

Can you update your patch against git master reprository ?

Thanks in advance

Gilles Caulier

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel
Reply | Threaded
Open this post in threaded view
|

[digikam] [Bug 196927] No easy way to expand or collapse deep tag hierarchies [patch]

Smit Mehta
In reply to this post by Bugzilla from dkde@gardnersworld.org
https://bugs.kde.org/show_bug.cgi?id=196927

Smit Mehta <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[hidden email]

--- Comment #5 from Smit Mehta <[hidden email]> ---
Hi Gilles

The code has changed over years and this patch is obsolete now. Do you still
want to implement this feature? If yes, I can start working over it.

Smit

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel
Reply | Threaded
Open this post in threaded view
|

[digikam] [Bug 196927] No easy way to expand or collapse deep tag hierarchies [patch]

Gilles Caulier-4
In reply to this post by Bugzilla from dkde@gardnersworld.org
https://bugs.kde.org/show_bug.cgi?id=196927

--- Comment #6 from Gilles Caulier <[hidden email]> ---
Yes, this is a feature that we need.

Ask to Andi and Marcel if some new way have already studied to implement it.

In all case, this feature must be included in Tags Manager project.

Gilles

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel
Reply | Threaded
Open this post in threaded view
|

[digikam] [Bug 196927] No easy way to expand or collapse deep tag hierarchies [patch]

Yiou Wang
In reply to this post by Bugzilla from dkde@gardnersworld.org
https://bugs.kde.org/show_bug.cgi?id=196927

Yiou Wang <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[hidden email]

--- Comment #7 from Yiou Wang <[hidden email]> ---
Hello everyone,

I'm a student in CS and I'm preparing to apply for the GSOC this year.

I'm interested in the Tag Manager project and I'm working on it. I would like
to make sure that to include this feature of expand all / collapse all when
right-click on a tag, or create buttons for them in order to make them more
accessible for users?

If they are to be created as buttons I will modify the GUI mockup I made.

Yiou

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel
Reply | Threaded
Open this post in threaded view
|

[digikam] [Bug 196927] No easy way to expand or collapse deep tag hierarchies [patch]

Otto Hirr
In reply to this post by Bugzilla from dkde@gardnersworld.org
https://bugs.kde.org/show_bug.cgi?id=196927

Otto Hirr <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[hidden email]

--- Comment #8 from Otto Hirr <[hidden email]> ---
Greetings,
I just started using digiKam (very nice) and I very much would like to have
this feature of expanding and collapsing recursively.

May I suggest that one consider having this as a general feature on any tree
structure, in my limited use so far, specifically tag and album trees. Maybe a
right-click on a tree node has a menu pick to recursively expand or collapse
from that node downward.

(digiKam, v3.1.0, kde 4.10.2, win, bld jun 07, 2013)

..Otto

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel
Reply | Threaded
Open this post in threaded view
|

[digikam] [Bug 196927] No easy way to expand or collapse deep tag hierarchies [patch]

Veaceslav Munteanu-2
In reply to this post by Bugzilla from dkde@gardnersworld.org
https://bugs.kde.org/show_bug.cgi?id=196927

Veaceslav Munteanu <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |RESOLVED
                 CC|                            |veaceslav.munteanu90@gmail.
                   |                            |com
   Version Fixed In|                            |4.0.0
         Resolution|---                         |FIXED

--- Comment #9 from Veaceslav Munteanu <[hidden email]> ---
Collapse or expand by one level is available on Tags Manager options.

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel
Reply | Threaded
Open this post in threaded view
|

[digikam] [Bug 196927] No easy way to expand or collapse deep tag hierarchies [patch]

Bugzilla from dkde@gardnersworld.org
In reply to this post by Bugzilla from dkde@gardnersworld.org
https://bugs.kde.org/show_bug.cgi?id=196927

--- Comment #10 from DGardner <[hidden email]> ---
(In reply to comment #9)
> Collapse or expand by one level is available on Tags Manager options.

Only being able to "collapse or expand by one level" is the problem, not the
solution.

Please clarify your comment or revert the status of this issue to "VERIFIED" if
your comment means what it seems to mean.

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel
Reply | Threaded
Open this post in threaded view
|

[digikam] [Bug 196927] No easy way to expand or collapse deep tag hierarchies [patch]

Veaceslav Munteanu-2
In reply to this post by Bugzilla from dkde@gardnersworld.org
https://bugs.kde.org/show_bug.cgi?id=196927

--- Comment #11 from Veaceslav Munteanu <[hidden email]> ---
Tags Manager option to expand or collapse is not clicking on node to expand it.

here is a tree:
first
|---- second
        |---second1
        |---second2
|---- third
        |----third1
        |-----third2

So, expand function will expand on ly first on first trigger, will expand
second and third with second trigger and will expand second1, second2,  third1,
third2 on third trigger.

Until you have a really complicated tag hierarchy, with extremply long tag
names, you should read the full expand very quick.

I can expand everything at once, but this option gives more flexibility...

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel
Reply | Threaded
Open this post in threaded view
|

[digikam] [Bug 196927] No easy way to expand or collapse deep tag hierarchies [patch]

Bugzilla from dkde@gardnersworld.org
In reply to this post by Bugzilla from dkde@gardnersworld.org
https://bugs.kde.org/show_bug.cgi?id=196927

--- Comment #12 from DGardner <[hidden email]> ---
(In reply to comment #11)
> Tags Manager option to expand or collapse is not clicking on node to expand it.

Does that mean that it will expand or collapse one level (per "trigger") of
*all* nodes in the tag tree, not just the nodes beneath a selected node? If
that is the case, then it is not the feature I requested in the description. I
do not want to "read [reach?] the full expand very quick", I want to be able to
collapse or expand all tags below a *specific* tag in the tree without
affecting the expansion state of any other tags, as those other tags may
already be expanded to my liking. If the only option is to expand or collapse
one level of all tags, then that is much less flexible, not more flexible, as
it is a very blunt instrument.

What is the behaviour of your change if applied when the tag nodes are expanded
to different levels in different places?

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel
Reply | Threaded
Open this post in threaded view
|

[digikam] [Bug 196927] No easy way to expand or collapse deep tag hierarchies [patch]

Otto Hirr
In reply to this post by Bugzilla from dkde@gardnersworld.org
https://bugs.kde.org/show_bug.cgi?id=196927

--- Comment #13 from Otto Hirr <[hidden email]> ---
I would like to make some refining definitions... and to define what I
personally would like to see happen. At the end, I will give a usage scenario
to provide justification why each concept (and implementation) is useful.

First lets take as an example a tree with the fully expanded structure of
A                  A
|..a              A.a
|..b              A.b
B                  B
C                  C
|..a              C.a
    |..1          C.a.1
        |..x      C.a.1.x
        |..y      C.a.1.y
    |..2          C.a.2

One other key concept is that there is a "current cursor" pointing to one and
only one item in the tree. There may be several "selected" tree nodes, but
there is only one "current cursor" node in the tree. This "current cursor" may
not be one of the "selected" tree nodes.

As an abbriv for Expand|Collapse, I will simply use E|C...

There are three fundamental concepts:
1)  [Expand|Collapse] All Children
For me, this means that regardless of where the "current cursor" points, the
entire tree is E|C.

2)  [Expand|Collapse] Recursively
For me, this means that ALL nodes beneath the "current cursor" location are
E|C. This would be the children, grand-children, grand-grand-children, and so
on, from the "current cursor" are E|C.

3)  [Expand|Collapse]
For me, this means that only the immediate children of the "current cursor"
location would be expanded.

Usage scenario...
I have a large complex tree (does not really matter whether it is TAGS or any
other tree-ish thing)...

So I am evaluating photos from one set, start tagging. I know that some parts
of the tree are deeper than others. Some parts are more broad, some more deep,
some more broad and deep.

For some nodes, knowing it is not very deep, and wanting access to all the
nodes, I would set the "current cursor" appropriately and Expand-Recursively
(2) from that point.

For other uses, I know that the tree is deep in some places, so I want to
simply place the "current cursor" and only expand one-level at a time (3). Then
maybe make the "current cursor" one of the children and again expand one-level
at a time (3) or maybe knowing that I want quick access to all the nodes below
that one, I would Expand-Recursively (2).

Finally, I'm done with that tagging group or from expanding so much, my tree
display is now just too big. I simply want to collapse everything, regardless
of where the "current cursor" may be.

Bottomline, each of the conceptual functions are important. The minimal of (3)
(or 1) is simply a requirement of having a tree structure.

That of (1) is quite frustrating if one has a large (breadth or depth or both)
tree and it were the only method to expand. That of (1) for collapsing is a joy
when the tree has been widely expanded and one wants to quick close everything
up and start over in opening up only portions of the tree.

That of (2) is really useful for applying to sections of a tree, when one knows
that the node they want is buried a couple levels below a particular node.

Yes this was long, but hopefully clarifies some important concepts.

Personally I would like to have all three items of functionality. It would be
nice if this were something that could be generated via template applied to a
tree so that it could be coded once and used everywhere a tree structure is
used.

Best regards,

..Otto

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel
Reply | Threaded
Open this post in threaded view
|

[digikam] [Bug 196927] No easy way to expand or collapse deep tag hierarchies [patch]

Veaceslav Munteanu-2
In reply to this post by Bugzilla from dkde@gardnersworld.org
https://bugs.kde.org/show_bug.cgi?id=196927

--- Comment #14 from Veaceslav Munteanu <[hidden email]> ---
So, 1 is not 2 applied on root tag?

Also, I see you need the option for right and left sidebars, that means it's no
use for it in TagManager,

And the last question, anybody is using latest git?

I will need that for feedback.

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel
Reply | Threaded
Open this post in threaded view
|

[digikam] [Bug 196927] No easy way to expand or collapse deep tag hierarchies [patch]

Veaceslav Munteanu-2
In reply to this post by Bugzilla from dkde@gardnersworld.org
https://bugs.kde.org/show_bug.cgi?id=196927

Veaceslav Munteanu <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |REOPENED
         Resolution|FIXED                       |---
     Ever confirmed|0                           |1

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel
Reply | Threaded
Open this post in threaded view
|

[digikam] [Bug 196927] No easy way to expand or collapse deep tag hierarchies [patch]

Otto Hirr
In reply to this post by Bugzilla from dkde@gardnersworld.org
https://bugs.kde.org/show_bug.cgi?id=196927

--- Comment #15 from Otto Hirr <[hidden email]> ---
In further refinement...

if the state of display of children is with the node, then
1) touches EACH node of ENTIRE tree, saying to E|C children
2) touches the "current cursor" node and all nodes beneath, saying to E|C the
node's children
3) touches the "current cursor" node ONLY, saying to E|C the node's children

The implications are that applying (3-C) to a top level node, collapses
everything under that node - the collapse is for that node only and because it
is collapsed, any children, regardless of how deeply expanded or not, are not
affected. However, applying (3-E) again to that top level node, expands just
that top level node AND however the nodes under that top level node, whether
expanded or collapsed, will remain expanded or collapsed.

The implications of applying (1-C) to any node, collapses the entire tree. Then
applying (3-E) will only open just the one node, all children below it have
been collapsed due to the full coverage of (1-C) telling each node to not
display children.

Hopefully that makes a useful feature more understandable.

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel
Reply | Threaded
Open this post in threaded view
|

[digikam] [Bug 196927] No easy way to expand or collapse deep tag hierarchies [patch]

Otto Hirr
In reply to this post by Bugzilla from dkde@gardnersworld.org
https://bugs.kde.org/show_bug.cgi?id=196927

--- Comment #16 from Otto Hirr <[hidden email]> ---
(In reply to comment #14)
> So, 1 is not 2 applied on root tag?

I do not believe there is a "root" tag.
The tree has several top level tags.
In computerize, the tree widget, displays a forest, i.e. there are a multiple
top level trees.

So (1) is really (2) applied to every top level tag.
Furthermore, (2) is really (3) applied to the "current cursor" AND recursively
for each child of the "current cursor".

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel
Reply | Threaded
Open this post in threaded view
|

[digikam] [Bug 196927] No easy way to expand or collapse deep tag hierarchies [patch]

Veaceslav Munteanu-2
In reply to this post by Bugzilla from dkde@gardnersworld.org
https://bugs.kde.org/show_bug.cgi?id=196927

Veaceslav Munteanu <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|REOPENED                    |RESOLVED
         Resolution|---                         |FIXED
      Latest Commit|                            |http://commits.kde.org/digi
                   |                            |kam/575ce7b429f1414c8afb94b
                   |                            |0c3ea440bfcfb8715

--- Comment #17 from Veaceslav Munteanu <[hidden email]> ---
Git commit 575ce7b429f1414c8afb94b0c3ea440bfcfb8715 by Veaceslav Munteanu.
Committed on 07/11/2013 at 10:17.
Pushed by munteanu into branch 'master'.

M  +94   -0    digikam/tags/tagfolderview.cpp
M  +10   -0    digikam/tags/tagfolderview.h

http://commits.kde.org/digikam/575ce7b429f1414c8afb94b0c3ea440bfcfb8715

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel
12