[Bug 195735] New: digikam-svn fails to compile on Mac OS X

https://bugs.kde.org/show_bug.cgi?id=195735





--- Comment #19 from Carlo Baldassi <carlobaldassi gmail com>  2009-06-11 11:55:30 ---
> Hopefully a dev from lqr can comment on the failure of lqr to compile on Mac > OS X?
Hi, sorry for the delay, I currently don't have an internet connection at
home...
The compilation problem for OS X should be fixed in the MacPorts version:

http://trac.macports.org/ticket/19685
http://trac.macports.org/changeset/51312

If this works I'll remove those two inlines in the next version (BTW if anyone
knows the reason why those inlines break compilation and how to prevent this
please let me know...).

Carlo

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

https://bugs.kde.org/show_bug.cgi?id=195735





--- Comment #20 from  <rishi j sanyal gmail com>  2009-06-11 19:56:43 ---
Thanks Carlo, but I'm not sure I understand.

The latest version on MacPorts seems to be liblqr @1-0.3.1 (I simply did a
'port search lqr')

I don't even see a 0.4.x version.

Which is why I attempted to download the latest source. But that failed to
compile.

So what exactly should I do?

Thanks,
Rishi

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

https://bugs.kde.org/show_bug.cgi?id=195735





--- Comment #21 from  <rishi j sanyal gmail com>  2009-06-11 23:28:44 ---
Gilles,

I didn't realize that it was you actually who wrote the dngconverter
kipi-plugin?

You say on one of the blog posts on the digiKam site
(http://www.digikam.org/drupal/node/373#comment-17820) that dngconverter
compiles fine on Mac OS X.

Have you yourself verified this, or was this an earlier version of
dngconverter? Because I can't get around the problems outlined above, even with
the modifications I made to dng_types.h and XMCore_Impl.hpp...

Cheers,
Rishi

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=195735


Gilles Caulier <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[hidden email]




--- Comment #22 from Gilles Caulier <caulier gilles gmail com>  2009-06-12 06:13:49 ---
Rishi,

I'm the author of DNGConverter.

I have never checked Macos-x compilation. I don't have mac computer. Salvatore
has do it : http://www.digikam.org/node/418. I don't know which version he use
exactly. I CC him to get more details.

Gilles Caulier

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

https://bugs.kde.org/show_bug.cgi?id=195735





--- Comment #23 from  <rishi j sanyal gmail com>  2009-06-12 09:58:26 ---
Gilles, cool. You'll never guess what I use your DNG converter for, but, before
I get to that, I just wanted to point out that for some reason (even the
Kubuntu Linux version) it doesn't copy over the EXIF data when converting
Panasonic LX3 RAW files (.RW2) to DNG, and it messes up the white balance info.
So then I'm stuck using exiftool, individually for each file, copy over the
EXIF information from the .RW2 file to the .DNG file that DNG Converter made
(yes, I can write a script to do this). Even more annoying, though, is that the
white balance is so screwed up that even synchronizing white balance info
between the .RW2 and the .DNG file *doesn't* work... I have to manually, in
Lightroom for example, type in the original Kelvin value recorded in the .RW2
file.

I don't know if this is your code or the Adobe DNG SDK... any ideas?

Now, just a personal anecdote: I find your DNG converter indispensable for the
following reason: Panasonic demanded that RAW converters like ACR perform
automatic lens corrections on all RAW files from the LX3 camera. This is
because the lens has immense barrel distortion at 24mm. Lens distortion
correction can be nice, but it introduces 2 problems: 1.) sometimes it makes
people, especially faces, look fat; and 2.) the corners become extremely soft
due to the immense geometry correction. Additionally, ACR noise removal is so
heavy on LX3 RAW files that there's just too much of an inherent softness to
the image (presumably because LX3 is a noisy camera to begin with).

With your DNG converter, I'm able to take all the RAW files, convert them to
DNG, and for whatever reason, when I import these .dng files into Lightroom, LR
no longer does the default corrections... that is, it doesn't apply lens
correction nor does it apply noise reduction. This results in more normal
looking people (to my eye) and a sharper, albeit noisier, image. But, because
it's DNG, I'm able to work on the linear RAW data... that is, I'm able to use
ACR's color engine (well, I had to perform a hack for that also, as the color
profile that DNG converter packages with the .dng file messed up the name/model
of the camera in whatever .dcp profile is included in the DNG file... this
makes it such that Lightroom no longer loads the default LX3 profile, but some
other profile, presumably whatever rudimentary profile is packaged with the
DNG? I don't know why, but you may want to look into this? I fixed this by
taking Adobe's default profiles for the LX3 and editing them to reflect the
camera/model information that your DNG converter embeds in the DNG conversions
from LX3 RAW files). Anyway, what I'm trying to say is, in the end, I can use
Lightroom's color profiles with these DNG files, as well as functions like
Highlight Recovery, which Lightroom does pretty well. It would be futile to try
to do Highlight Recovery on TIFF conversions of LX3 RAW files exported by
digiKam (or whatever software), since the highlights would already be
compressed due to gamma compression. Obviously I wouldn't be able to apply
Adobe's quite pleasing color profiles also if I exported to TIFF.

So, here's one big cheer for your DNG converter... hopefully the problems will
eventually be fixed :)

Finally, Gilles, the errors output when trying to compile DNG converter, as I
outlined in 'Comment #18' above -- do they make any sense to you?

Cheers,
Rishi

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

https://bugs.kde.org/show_bug.cgi?id=195735





--- Comment #24 from Carlo Baldassi <carlobaldassi gmail com>  2009-06-12 11:51:52 ---
(in response to Comment #20)
> Thanks Carlo, but I'm not sure I understand.
>
> The latest version on MacPorts seems to be liblqr @1-0.3.1 (I simply did a
> 'port search lqr')
>
> I don't even see a 0.4.x version.
Ah ok, I don't have a Mac, and from the website it seemed to me it had been
updated.

> So what exactly should I do?
Just try removing the "inline" directives from lines 48 and 50 of
lqr_energy_priv.h, as shown in this patch:

http://trac.macports.org/changeset/51312

I hope this works, let me know.

Carlo

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=195735


Gilles Caulier <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[hidden email],
                   |                            |[hidden email]




--- Comment #25 from Gilles Caulier <caulier gilles gmail com>  2009-06-12 13:25:11 ---
Rishi,

Look this entry about DNG white balance:

https://bugs.kde.org/show_bug.cgi?id=191907

It's fully relevant of DNG sdk. In fact Adobe sdk and metadata is a mess. It
lack of all markernotes where are stored white balance information.

So the only solution to this problem is to use default D65.

I recommend to use last code from Exiv2 library (svn) where last code to write
in DNG file can store original makernotes without to break TIFF/EP structure...
Perhaps it can help...

I wait also next DNG SDK planed by Adobe. But i'm sure that no improvement will
be done in this way. In fact DNG converter from Adobe as private code to
restore WB using makernotes. This is wy Adobe sell commercial tools around this
format.

About your compilation problems under MAcos-x, my experience from this ystem is
limited. Without a real computer with this system to hack, it will be difficult
to found a way. Sorry.

The only words that i can said is:  linker, not compiler fail to find symbols
with XMP SDK (not DNG sdk)... why ? a missing library ? I don't know...

Salvatore, please can help here ?

Note : Exiv2 library include also XMP sdk from Adobe, and it compile fine to
Mac-OSX.
Perhaps Andreas from Exiv2 project can help us here. I CC him...

Gilles Caulier

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

https://bugs.kde.org/show_bug.cgi?id=195735





--- Comment #26 from Andreas Huggel <ahuggel gmx net>  2009-06-12 16:40:02 ---
(In reply to comment #25)
> Note : Exiv2 library include also XMP sdk from Adobe, and it compile fine to
> Mac-OSX.
> Perhaps Andreas from Exiv2 project can help us here. I CC him...

I'm afraid not. All I can say is that in Exiv2 this

#if XMP_MacBuild
        #include <Multiprocessing.h>
...

is still there in XMPCore_Impl.hpp and I haven't seen any complains about it.
And yes, it has been compiled on Max OS X ( although I also don't have one :)

Andreas

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

https://bugs.kde.org/show_bug.cgi?id=195735





--- Comment #27 from  <rishi j sanyal gmail com>  2009-06-13 00:02:47 ---
Hi Andreas,

You're absolutely right: the exiv2 source still has the Multiprocessing.h line
in the XMPCore_Impl.hpp file, and it compiles just fine (I just tried, even
though I have it installed already via MacPorts). Strange.

However, the xmpsdk directory in the Exiv2 source package is definitely
different from the one included with dngconverter... just take a look at the
source directory of xmpsdk & xmp_sdk (yeah, they're even named differently)
from Exiv2 and dngconverter, respectively (from left to right) in the following
screen capture of the two directories:

http://staff.washington.edu/rjsanyal/xmp_sdk.jpg

Maybe I'm being naive, but should these xmp_sdk source directories be so
different?

Thanks,
Rishi

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

https://bugs.kde.org/show_bug.cgi?id=195735





--- Comment #28 from Andreas Huggel <ahuggel gmx net>  2009-06-13 02:41:09 ---
Hi Rishi,

> but should these xmp_sdk source directories be so different?

I guess they both come from the same source, the original XMP SDK from Adobe.
For Exiv2, see doc/README-XMP for some information about how it was derived and
differs from the original XMP SDK. Which part they both use of that and how
they arrange it may be different.

Andreas

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=195735





--- Comment #29 from Gilles Caulier <caulier gilles gmail com>  2009-06-13 09:16:51 ---
Rishi,

In DNGConverter, i have just copied all source code from original Adobe tarball
and listed all file to compile into CMakeLists.txt. That all. It compile fine
under Linux and , Windows XP/Vista using MinGw and MSVC9 compilers.

Adobe said that XMP sdk code is compilable under Macos X...

Gilles Caulier

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

https://bugs.kde.org/show_bug.cgi?id=195735


Thomas Lunde <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[hidden email]




--- Comment #30 from Thomas Lunde <thomas lunde net>  2009-06-14 18:19:58 ---
+1 for digiKam on OS X.  PM to Gilles.

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

https://bugs.kde.org/show_bug.cgi?id=195735





--- Comment #31 from  <rishi j sanyal gmail com>  2009-06-15 22:53:48 ---
Hi Carlo,

Perhaps you've already figured this out, but, yes-- removing the "inline"
directives from lines 48 & 50 allows for a successful compile of lqr on Mac OS
X!

I was surprised to see that lqr 0.4.1 was added to MacPorts, and it installs
just fine, so I figure that you must've already taken out the "inline"
directives before it even went to MacPorts.

At any rate, all seems good now with lqr... though I'm still waiting for
digiKam to compile through the lqr step (and then, of course, fail on
dngconverter, argh!).

So now it would seem that dngconverter is the only problem left for a full
compilation on Mac OS X! (Although, admittedly, I'm having a little trouble get
liblensfun installed on OS X...)

Rishi

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

https://bugs.kde.org/show_bug.cgi?id=195735





--- Comment #32 from  <rishi j sanyal gmail com>  2009-06-16 00:02:22 ---
I can now confirm that contentawareresizing plugin compiles just fine with
digiKam, & is present in the final build.

So, the current status is: for Mac OS X, digiKam only fails to compile at 91%
when attempting to 'Link CXX executable dngvalidate'...

Rishi

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

https://bugs.kde.org/show_bug.cgi?id=195735





--- Comment #33 from  <rishi j sanyal gmail com>  2009-06-18 01:41:08 ---
Gilles-- Wow, did you change something in the DNG converter code? Because now,
on the Mac side of things-- it copies over metadata from Panasonic LX3 .RW2
files to the DNG files when converting to DNG! The White Balance info is still
screwed up, but at least aperture, shutter speed, ISO, etc. are all copied over
to the DNG file!

Or does this have something to do with the Mac side of things?

For everyone else-- Gilles fixed some code so that dngconverter now compiles
fine on the Mac... so now digiKam compiles 100% on Mac OS X!!

We may mark this bug now as 'resolved' :)

I was also able to get LensFun to compile to enough of a point that digiKam can
add it as a plug-in, and it functions. I'll have to post these instructions
somewhere or I will pass them along to LensFun dev in the hopes that he updates
it in source.

The only thing now is that dngconverter seems to NOT load as a kipi-plugin, so
one can't load it from within digiKam, but one can still use the dnconverter
application as a standalone.

Cheers, & many thanks to all incredible developers out there pushing out such
magnificent software :)

Best wishes,
Rishi

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

https://bugs.kde.org/show_bug.cgi?id=195735


[hidden email] changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |RESOLVED
         Resolution|                            |FIXED




--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[bugzilla_noreply]

https://bugs.kde.org/show_bug.cgi?id=195735

[hidden email] changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
          Component|Portability                 |Bundle-Tarball

--
You are receiving this mail because:
You are the assignee for the bug.