[Bug 193874] New: When changing dates, change date-based filename as well.

https://bugs.kde.org/show_bug.cgi?id=193874

           Summary: When changing dates, change date-based filename as
                    well.
           Product: digikam
           Version: unspecified
          Platform: Ubuntu Packages
        OS/Version: unspecified
            Status: NEW
          Severity: wishlist
          Priority: NOR
         Component: general
        AssignedTo: [hidden email]
        ReportedBy: [hidden email]


Version:            (using KDE 4.2.3)
Installed from:    Ubuntu Packages

Digikam gives the user the option to change filenames to date-based. In these
cases, it is obvious that the user is using the filename as a date field.
Therefore, when the user changes the date of a photo, he should have the option
of changing date-based filenames as well.

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=193874


Gilles Caulier <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
          Component|general                     |Metadata
            Version|unspecified                 |0.11.0-svn




--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=193874


Gilles Caulier <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Version|0.11.0-svn                  |1.0.0




--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=193874


Gilles Caulier <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[hidden email]




--- Comment #1 from Gilles Caulier <caulier gilles gmail com>  2011-12-17 09:31:14 ---
Dotan,

This file still valid using 2.x serie ?

Also, please give more information about, it's not enough clear...

Gilles Caulier

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Dotan Cohen-3]

https://bugs.kde.org/show_bug.cgi?id=193874





--- Comment #2 from Dotan Cohen <kde-2011 08 dotancohen com>  2011-12-17 17:10:54 ---
Created an attachment (id=66835)
 --> (http://bugs.kde.org/attachment.cgi?id=66835)
Example

Yes, the RFE is still valid for Digikam 2.4.

If there is a file that is named 20111126T160302.jpg that has the timestamp
2011-11-26 16:03:02 then obviously the filename is used to record the date of
the image, in addition to XMP, IPTC, or anything else. Therefore, when changing
the time of the photo the filename should be an option to update as well. See
attached screenshot.

Thanks!

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Smit Mehta]

https://bugs.kde.org/show_bug.cgi?id=193874

Smit Mehta <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[hidden email]

--- Comment #3 from Smit Mehta <[hidden email]> ---
Hi

I am Smit, an aspiring GSoC applicant for the UPnP plugin, under Marcel. I was
interested to solve this bug. As guided by Marcel, the advanced rename is
implemented in /utilities/advancedrename and the "date and time adjust" is
implemented as a kipi-plugin. Where can i find the kipi-plugin code? Can any
developer please guide me on how to go about solving this?

Smit

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=193874

--- Comment #4 from Gilles Caulier <[hidden email]> ---
Code is here :

https://projects.kde.org/projects/extragear/graphics/kipi-plugins/repository/revisions/master/show/timeadjust

Gilles Caulier

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Smit Mehta]

https://bugs.kde.org/show_bug.cgi?id=193874

--- Comment #5 from Smit Mehta <[hidden email]> ---
Hi Gilles

Thanks for pointing out the code. I tried to make ammends to it. As the user
wants, i included a "Edit Filename" option in the list of exiting ones, and in
the SlotOk(), i wrote another if condition, to do stuff when it is checked. I
want to change the file name. However whatever function i use, i am unable to
change it. I can change all the data related to image, say its comments, tags,
etc. But not the name. Kindly go through the patch and comment.

<a href="http://pastebin.com/AcdF4kdn"> patch </a>

Smit

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Marcel Wiesweg]

https://bugs.kde.org/show_bug.cgi?id=193874

--- Comment #6 from Marcel Wiesweg <[hidden email]> ---
You need to start an actual file rename operation on disk, not something which
adjusts parameters on a structure in memory.
I suggest to use KIO::move().
Regarding your code:
Remove the toAscii(). Dont forget to find out the correct file suffix, see
QFileInfo::suffix or completeSuffix(). Dont forget to handle a possible XMP
sidecar file (current work in progress under bug 220545). For this and the KIO
code, I suggest you have a look at digikam's dio.cpp

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Smit Mehta]

https://bugs.kde.org/show_bug.cgi?id=193874

--- Comment #7 from Smit Mehta <[hidden email]> ---
Hi Gilles

Kindly review the given patch.

http://pastebin.com/ERRUtBtH

This changed code works properly on the source code i downloaded on March 11.
In that version, whenever i changed the file name with that option, upon
clicking "Ok", it changed the filename, and was shown with the new name in the
album view. But in the source-code i downloaded today, i.e. March 19, it still
changes the fill name, but it is no more there in the album view inside
digikam. Any suggestions?

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Smit Mehta]

https://bugs.kde.org/show_bug.cgi?id=193874

--- Comment #8 from Smit Mehta <[hidden email]> ---
Hi

Kindly note that, when i say the patch works in the 11th March's version of
digikam, i mean that the file renaming portion works properly (as the sidecar
implementation in kpmetadata was not done then). It renamed the file, and
digikam automatically updated the view, with the renamed file. But it is not
happening in the current source code.
Instead, it is not showing the renamed file at all.

Smit

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=193874

Gilles Caulier <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Version|1.0.0                       |2.6.0

--- Comment #9 from Gilles Caulier <[hidden email]> ---
Smit,

1/ please post patch as attached file to this bugzilla entry, not as an
external link

2/ to rename XMP sidecar file, please use KPMetadata::moveSidecar() static
method that i just add today.

3/ revise you patch against current git/master implementation

Thanks in advance

Gilles

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Smit Mehta]

https://bugs.kde.org/show_bug.cgi?id=193874

--- Comment #10 from Smit Mehta <[hidden email]> ---
Created attachment 69764
  --> https://bugs.kde.org/attachment.cgi?id=69764&action=edit
Patch for bug 193874

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Smit Mehta]

https://bugs.kde.org/show_bug.cgi?id=193874

--- Comment #11 from Smit Mehta <[hidden email]> ---
Hi Gilles

I have incorporated the changes you recommended in my patch. It is working
properly on the latest source code. Kindly review it.

Smit

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=193874

--- Comment #12 from Gilles Caulier <[hidden email]> ---
smit,

Patch sound fine for me.

Do you have an account to apply it on git/master ?

Best

Gilles Caulier

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Smit Mehta]

https://bugs.kde.org/show_bug.cgi?id=193874

--- Comment #13 from Smit Mehta <[hidden email]> ---
Hi Gilles

No I dont have an account to apply it on git/master. Can I use your name in
"Who supports this request?" part of the application? Could you please guide me
on how to get that?

Smit

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Smit Mehta]

https://bugs.kde.org/show_bug.cgi?id=193874

Smit Mehta <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |FIXED

--- Comment #14 from Smit Mehta <[hidden email]> ---
Hi

I am closing this bug. This commit solves it.

https://projects.kde.org/projects/extragear/graphics/kipi-plugins/repository/revisions/3d7d8f30f1e9771dc1aab18b1b1a01b86883a946

Smit

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=193874

--- Comment #15 from Gilles Caulier <[hidden email]> ---
Smit,

Note, use BUGS not BUG to close file automatically

Use CCBUGS, not CCBUG to copy commit message in bugzilla entry

Best

Gilles Caulier

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=193874

Gilles Caulier <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Version Fixed In|                            |2.6.0

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel