[Bug 193232] New: "text files" album filter

[DrSlony-4]

https://bugs.kde.org/show_bug.cgi?id=193232

DrSlony <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Version|4.2.0                       |4.3.0

--- Comment #15 from DrSlony <[hidden email]> ---
Still does not work in 4.3.0. I tried adding "pp3" to Images, Movie and Audio
Files, then re-scanning and restarting. PP3 files would never show.

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[DrSlony-4]

https://bugs.kde.org/show_bug.cgi?id=193232

--- Comment #16 from DrSlony <[hidden email]> ---
Please look into this. Without it one cannot move e.g. raw file + sidecar file
to a different folder - I have to use an external program which defeats the
purpose of using digiKam.

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[DrSlony-4]

https://bugs.kde.org/show_bug.cgi?id=193232

--- Comment #17 from DrSlony <[hidden email]> ---
In 4.6.0 adding custom extensions to Image/Movie/Audio Files in Configure >
MIME Types finally works. Please add a fourth option, "Sidecar Files", so we
don't have to hijack the Audio or Movie categories to be able to move our
sidecar files along with our image files.

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[DrSlony-4]

https://bugs.kde.org/show_bug.cgi?id=193232

DrSlony <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Version|4.3.0                       |4.6.0

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[DrSlony-4]

https://bugs.kde.org/show_bug.cgi?id=193232

--- Comment #18 from DrSlony <[hidden email]> ---
Ignore my previous comment. In 4.6.0 is it still broken. I am absolutely
certain digiKam showed me the .pp3 and .pano icons in the album view, but this
must have been a one-time quirk of digiKam (one of many). I couldn't see then
after restarting digiKam. I even deleted the database and every config file
related to digiKam, re-added the collections, added pano;pp3;pto;p2vr to the
MIME Types, and still can't get it to show me those files again.

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[DrSlony-4]

https://bugs.kde.org/show_bug.cgi?id=193232

--- Comment #19 from DrSlony <[hidden email]> ---
Created attachment 90116
  --> https://bugs.kde.org/attachment.cgi?id=90116&action=edit
digiKam

No active filters, pano;pp3;pto;p2vr added to MIME Types, Albums tree view
correctly shows there are 4 items, but I only see the one JPEG.

 73K 2014-12-24 13:42:28 test_jpg.jpg
1.7M 2014-12-24 13:38:30 test_pano.pano
5.9K 2014-10-15 12:13:58 test_pp3.pp3
1.3K 2014-12-24 13:40:29 test_pto.pto

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=193232

Gilles Caulier <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|Add advanced input side-car |Add advanced input side-car
                   |files support (as .pto,     |files support (as .pto,
                   |.pp2, .pp3, .pano, etc...)  |.pp2, .pp3, .pano, thm,
                   |                            |etc...)

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=193232

Gilles Caulier <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[hidden email]

--- Comment #20 from Gilles Caulier <[hidden email]> ---
*** Bug 288513 has been marked as a duplicate of this bug. ***

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

https://bugs.kde.org/show_bug.cgi?id=193232

--- Comment #21 from Matthieu Pupat <[hidden email]> ---
Would it be possible for Digikam to read metadata from THM files when using
"Reread metadata From Images"?

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[bugzilla_noreply]

https://bugs.kde.org/show_bug.cgi?id=193232

--- Comment #22 from DrSlony <[hidden email]> ---
Bump, please add support for digiKam-5 to treat user-specified file types as
sidecar files so that when you move photos, these files get moved too.

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[bugzilla_noreply]

https://bugs.kde.org/show_bug.cgi?id=193232

Simon <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[hidden email]

--- Comment #23 from Simon <[hidden email]> ---
*** Bug 379511 has been marked as a duplicate of this bug. ***

--
You are receiving this mail because:
You are the assignee for the bug.

[bugzilla_noreply]

https://bugs.kde.org/show_bug.cgi?id=193232

--- Comment #24 from Simon <[hidden email]> ---
Created attachment 105376
  --> https://bugs.kde.org/attachment.cgi?id=105376&action=edit
Introduce additional sidecar types and refactor

This adds the new tab "Sidecars" to the metadata setup. It contains the
existing settings about sidecars and a new field to enter sidecar extensions.
These files will neither be displayed nor read from or written to. Only if the
corresponding item is renamed/moved/copied/deleted, these files are transformed
accordingly.

Screenshot of new metadata setup tab: http://i.imgur.com/5goLygr.png

--
You are receiving this mail because:
You are the assignee for the bug.

[bugzilla_noreply]

https://bugs.kde.org/show_bug.cgi?id=193232

--- Comment #25 from DrSlony <[hidden email]> ---
Thank you.

--
You are receiving this mail because:
You are the assignee for the bug.

[bugzilla_noreply]

https://bugs.kde.org/show_bug.cgi?id=193232

--- Comment #26 from [hidden email] ---
DrSlony,

Did you have tested the Simon patch ? I do not do it yet myself.

Simon,

The setup panel is very good. Congratulations.

Gilles

--
You are receiving this mail because:
You are the assignee for the bug.

[bugzilla_noreply]

https://bugs.kde.org/show_bug.cgi?id=193232

--- Comment #27 from DrSlony <[hidden email]> ---
I have not tested it yet, I probably won't be able to do that for a few weeks,
but the screenshot and description look and sound good.

--
You are receiving this mail because:
You are the assignee for the bug.

[bugzilla_noreply]

https://bugs.kde.org/show_bug.cgi?id=193232

Maik Qualmann <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[hidden email]

--- Comment #28 from Maik Qualmann <[hidden email]> ---
I've tested it, working as expected. Simon, I find cleanUserFilterString ()
quite complicated. What do you think of this code, it is not tested:

QString filter = filterString.trimmed();
filter.remove(QLatin1String("-*."));
filter.remove(QLatin1String("*."));
filter.remove(QLatin1String("-."));
filter.remove(QLatin1Char('.'));
filter.replace(QLatin1Char(';'), QLatin1Char(' '));
QStringList filterList = filter.split(QLatin1Char(' '),
QString::SkipEmptyParts);

Maik

--
You are receiving this mail because:
You are the assignee for the bug.

[bugzilla_noreply]

https://bugs.kde.org/show_bug.cgi?id=193232

--- Comment #29 from [hidden email] ---
Simon,

Tested here too. It work fine for me...

Gilles

--
You are receiving this mail because:
You are the assignee for the bug.

[bugzilla_noreply]

https://bugs.kde.org/show_bug.cgi?id=193232

Simon <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #105376|0                           |1
        is obsolete|                            |

--- Comment #30 from Simon <[hidden email]> ---
Created attachment 105399
  --> https://bugs.kde.org/attachment.cgi?id=105399&action=edit
Introduce additional sidecar types and refactor  - 2

I agree, this function is too complex for what it does. Your code would delete
the dot out of e.g. "out.pp3" and leading minuses must be preserved, so what is
in the updated patch is a little less simple.

A question about the copyright notices: Should I add my name when I do
(significant) changes?

--
You are receiving this mail because:
You are the assignee for the bug.

[bugzilla_noreply]

https://bugs.kde.org/show_bug.cgi?id=193232

--- Comment #31 from [hidden email] ---
>A question about the copyright notices: Should I add my name when I do
>(significant) changes?

Of course, with pleasure (:=))...

Gilles

--
You are receiving this mail because:
You are the assignee for the bug.

[bugzilla_noreply]

https://bugs.kde.org/show_bug.cgi?id=193232

Simon <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |RESOLVED
      Latest Commit|                            |https://commits.kde.org/dig
                   |                            |ikam/6485f23ed94757c31d4613
                   |                            |fe8f45c983d847d8df
         Resolution|---                         |FIXED
   Version Fixed In|                            |5.6.0

--- Comment #32 from Simon <[hidden email]> ---
Git commit 6485f23ed94757c31d4613fe8f45c983d847d8df by Simon Frei.
Committed on 12/05/2017 at 23:15.
Pushed by sfrei into branch 'master'.

The previous commit also included option to specify additional sidecar
extensions

This commit does not contain the actual changes, refer to the previous one.
The newly specified sidecar files are not read from/written to, they are only
processed alongside the item they belong to (i.e. renamed, moved, deleted...)
FIXED-IN: 5.6.0

M  +2    -1    NEWS

https://commits.kde.org/digikam/6485f23ed94757c31d4613fe8f45c983d847d8df

--
You are receiving this mail because:
You are the assignee for the bug.