[Bug 190296] New: Can not save images on Windows

https://bugs.kde.org/show_bug.cgi?id=190296

           Summary: Can not save images on Windows
           Product: digikam
           Version: 0.11.0-svn
          Platform: unspecified
        OS/Version: MS Windows
            Status: UNCONFIRMED
          Severity: normal
          Priority: NOR
         Component: Image Editor
        AssignedTo: [hidden email]
        ReportedBy: [hidden email]


Version:           0.11.0-svn (using 4.2.2 (KDE 4.2.2), MinGW 3.4.5)
Compiler:          gcc.exe
OS:                Microsoft Windows (i686) release 5.1 (XP Professional)

When I try to save an image in Image Editor I always get the message "Failed to
overwrite original file". I have tried different files, both Save and Save As
and different formats with the same result.

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=190296





--- Comment #1 from Gilles Caulier <caulier gilles gmail com>  2009-04-21 21:17:53 ---
If your image is in your user directory, it will have read only / archive flag,
and it's a stupid stuff from M$... We need to patch digiKam to ignore this flag
everywhere (under win32 only of course)

Do not ask me why files have this flag... I don't understand M$ policy...

Gilles Caulier

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

https://bugs.kde.org/show_bug.cgi?id=190296





--- Comment #2 from David Eriksson <meldavid acc umu se>  2009-04-21 21:28:20 ---
I tried using a directory on another partition (FAT32) with the same result. I
also noticed that the file is actually saved but has a name like
xd1124.digikamtempfile.tmp1124.

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Patrick Spendrin]

https://bugs.kde.org/show_bug.cgi?id=190296


Saro Engels <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[hidden email]




--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

https://bugs.kde.org/show_bug.cgi?id=190296





--- Comment #3 from David Eriksson <meldavid acc umu se>  2009-05-10 23:08:06 ---
I think this is related to bug 189742 (Thumbnails not saved), since Windows
don't like renaming open files. The attached patch (made along the lines of the
solution to bug 189742) closes the KTemporaryFile directly after it is created
since it didn't work just closing it before the final rename. I suspect there
is some renaming done in the saving of the image to the temporary file. The
patch enables me to do Save As, but not Save and I suspect this is due to the
image still being open in the editor during a Save. Now when I can save an
image I realized that it is always saved as png, independently of what I choose
as a name or format.

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

https://bugs.kde.org/show_bug.cgi?id=190296





--- Comment #4 from David Eriksson <meldavid acc umu se>  2009-05-10 23:09:00 ---
Created an attachment (id=33528)
 --> (http://bugs.kde.org/attachment.cgi?id=33528)
Patch to make Save As work

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=190296


Gilles Caulier <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |RESOLVED
         Resolution|                            |FIXED




--- Comment #5 from Gilles Caulier <caulier gilles gmail com>  2009-05-11 08:52:34 ---
SVN commit 966369 by cgilles:

apply patch #33528 from David Eriksson. Thanks for this patch and tests under
Windows.
BUG: 190296
CCMAIL: [hidden email]



 M  +12 -6     editorwindow.cpp  
 M  +1 -0      savingcontextcontainer.h  


WebSVN link: http://websvn.kde.org/?view=rev&revision=966369

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

https://bugs.kde.org/show_bug.cgi?id=190296





--- Comment #6 from David Eriksson <meldavid acc umu se>  2009-05-11 22:02:05 ---
I have now got Save to work also. The new patch includes the parts I missed in
for the rename of the file.

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

https://bugs.kde.org/show_bug.cgi?id=190296





--- Comment #7 from David Eriksson <meldavid acc umu se>  2009-05-11 22:02:43 ---
Created an attachment (id=33560)
 --> (http://bugs.kde.org/attachment.cgi?id=33560)
Patch to make Save work

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=190296





--- Comment #8 from Gilles Caulier <caulier gilles gmail com>  2009-05-11 23:00:43 ---
SVN commit 966775 by cgilles:

apply patch #33560
CCBUGS: 190296


 M  +13 -1     editorwindow.cpp  


WebSVN link: http://websvn.kde.org/?view=rev&revision=966775

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=190296





--- Comment #9 from Gilles Caulier <caulier gilles gmail com>  2009-05-11 23:05:24 ---
Thanks David for your patches.

As you work under windows, do you know a solution about this entry :

https://bugs.kde.org/show_bug.cgi?id=189168

Gilles Caulier

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=190296


Gilles Caulier <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Version|0.11.0-svn                  |1.0.0




--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=190296

Gilles Caulier <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Version Fixed In|                            |1.0.0

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[bugzilla_noreply]

https://bugs.kde.org/show_bug.cgi?id=190296

[hidden email] changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[hidden email]
           Platform|unspecified                 |MS Windows

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel