[Bug 189413] New: Images without GPS-data are shown on the equator in the geolocation-view

https://bugs.kde.org/show_bug.cgi?id=189413

           Summary: Images without GPS-data are shown on the equator in
                    the geolocation-view
           Product: digikam
           Version: 0.10.0
          Platform: Debian testing
        OS/Version: Linux
            Status: UNCONFIRMED
          Severity: normal
          Priority: NOR
         Component: general
        AssignedTo: [hidden email]
        ReportedBy: [hidden email]


Version:           0.10.0 (using KDE 4.2.2)
OS:                Linux
Installed from:    Debian testing/unstable Packages

When images with GPS-information and without GPS-information are selected at
the same time and the "Geolocation"-tab is opened, images without
GPS-information are shown on the equator at 0,0. The images with
GPS-information are shown correctly.

The right behavior would be not to show the images without GPS-information.
When only one image is selected, and the image is without GPS-information, it
is not shown on the map, as expected.

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=189413


Gilles Caulier <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
          Component|general                     |Geolocation




--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

https://bugs.kde.org/show_bug.cgi?id=189413


Michael G. Hansen <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[hidden email]




--- Comment #1 from Michael G. Hansen <mikeml2 pfna de>  2009-04-12 12:24:41 ---
The problem is a missing check for empty positions in
libs/imageproperties/imagepropertiessidebardb.cpp where the list of images to
be shown on the map is constructed. The changes below fix it.

--- imagepropertiessidebardb.cpp.original       2009-03-16 16:28:29.000000000
+0100
+++ imagepropertiessidebardb.cpp        2009-04-11 23:34:30.000000000 +0200
@@ -322,15 +322,25 @@
             GPSInfoList list;
             for (ImageInfoList::const_iterator it =
d->currentInfos.constBegin(); it != d->currentInfos.constEnd(); ++it)
             {
-                GPSInfo info;
-                info.latitude  = (*it).imagePosition().latitudeNumber();
-                info.longitude = (*it).imagePosition().longitudeNumber();
-                info.altitude  = (*it).imagePosition().altitude();
-                info.dateTime  = (*it).dateTime();
-                info.url       = (*it).fileUrl();
-                list.append(info);
+                if (!(*it).imagePosition().isEmpty())
+                {
+                    GPSInfo info;
+                    info.latitude  = (*it).imagePosition().latitudeNumber();
+                    info.longitude = (*it).imagePosition().longitudeNumber();
+                    info.altitude  = (*it).imagePosition().altitude();
+                    info.dateTime  = (*it).dateTime();
+                    info.url       = (*it).fileUrl();
+                    list.append(info);
+                }
+            }
+            if (list.isEmpty())
+            {
+                m_gpsTab->setCurrentURL();
+            }
+            else
+            {
+                m_gpsTab->setGPSInfoList(list);
             }
-            m_gpsTab->setGPSInfoList(list);

             m_dirtyGpsTab = true;
         }

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=189413


Gilles Caulier <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |RESOLVED
         Resolution|                            |FIXED




--- Comment #2 from Gilles Caulier <caulier gilles gmail com>  2009-04-12 12:41:32 ---
SVN commit 952618 by cgilles:

apply patch from Michael G.Hansen
BUG: 189413


 M  +22 -12    imagepropertiessidebardb.cpp  
 M  +2 -2      imagepropertiessidebardb.h  


WebSVN link: http://websvn.kde.org/?view=rev&revision=952618

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel