[Bug 189080] New: comments not saved with digikam 0.10.0 on KDE 4.2.2

https://bugs.kde.org/show_bug.cgi?id=189080

           Summary: comments not saved with digikam 0.10.0 on KDE 4.2.2
           Product: digikam
           Version: 0.10.0
          Platform: SuSE RPMs
        OS/Version: Linux
            Status: UNCONFIRMED
          Severity: normal
          Priority: NOR
         Component: general
        AssignedTo: [hidden email]
        ReportedBy: [hidden email]


Version:           0.10.0 (using KDE 4.2.2)
OS:                Linux
Installed from:    SuSE RPMs

Since I have installed KDE 4.2.2 my picture comments are neither stored to the
digikam database nor to the EXIF comment fields (I have enabled the latter for
a test). Rating and tags are stored to the database. Existing comments are read
from the database.

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

https://bugs.kde.org/show_bug.cgi?id=189080





--- Comment #1 from Egbert König <e kunig home nl>  2009-04-07 23:52:18 ---
digikam is running under openSuSE 11.1 with KDE 4.2.2 from the openSuSE Build
Service repository KDE:/KDE4:/Factory:/Desktop/openSUSE_11.1/, architecture is
x86_64.

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=189080


Gilles Caulier <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
          Component|general                     |Database




--- Comment #2 from Gilles Caulier <caulier gilles gmail com>  2009-04-07 23:53:29 ---
Hum, not reproducible here. Mandriva 2009, x86-32

Gilles Caulier

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

https://bugs.kde.org/show_bug.cgi?id=189080





--- Comment #3 from Egbert König <e kunig home nl>  2009-04-08 23:11:09 ---
I have checked again. I have found,that I could save comments to some pictures
and not to some other pictures. The reason was, that there have been duplicate
entries for the same imageid in database table "imagecomments". The newer
entries had lower ID values (column ID is different from column IMAGEID).
Obviously the comment shown is that with the highest ID value. After I have
removed the wrong comments (they had all the same text from my camera), I could
see the comments, I have entered before. I was now also able to change the
comments.

Might this be a consequence of converting the database from digikam3.db? The
affected pictures have been in the database before the conversion.

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=189080





--- Comment #4 from Gilles Caulier <caulier gilles gmail com>  2009-04-08 23:13:22 ---
Yes, certainly a bug.

Marcel ?

Gilles

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Marcel Wiesweg]

https://bugs.kde.org/show_bug.cgi?id=189080


Marcel Wiesweg <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[hidden email]




--- Comment #5 from Marcel Wiesweg <marcel wiesweg gmx de>  2009-04-11 17:35:44 ---
May it be that the invalid comment texts can be found in the exif/iptc
metadata?
Do you still have an example of the multiple entries in your ImageComments
table (with all fields in that table)?

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

https://bugs.kde.org/show_bug.cgi?id=189080





--- Comment #6 from Egbert König <e kunig home nl>  2009-04-11 18:23:08 ---
Created an attachment (id=32761)
 --> (http://bugs.kde.org/attachment.cgi?id=32761)
gzipped compressed xml export of table imagecomments with duplicate imageid's

You're totally right. The duplicate comments were coming from the pictures'
EXIF comment fields. Please get the attached table export. Examples for this
failure are e.g. starting at imageid 11370. These were the pictures which I
wanted to comment when my comments were not accepted.

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Marcel Wiesweg]

https://bugs.kde.org/show_bug.cgi?id=189080





--- Comment #7 from Marcel Wiesweg <marcel wiesweg gmx de>  2009-04-12 21:20:40 ---
Ok the cause of this problem is a SQL subtlety that I was not aware of:
"The UNIQUE constraint causes an unique index to be created on the specified
columns. All NULL values are considered different from each other and from all
other values for the purpose of determining uniqueness, hence a UNIQUE column
may contain multiple entries with the value of NULL."
There is a UNIQUE constraint in ImageComments for (imageid, type, language,
author). Now you have identical values for imageid, type and language and NULL
for author. Would author be '' (the empty string) there would not be duplicate
entries.
Now I have to find out how to solve that.

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Marcel Wiesweg]

https://bugs.kde.org/show_bug.cgi?id=189080





--- Comment #8 from Marcel Wiesweg <marcel wiesweg gmx de>  2009-04-13 14:46:49 ---
This may be SQL to fix an affected database:

DELETE FROM ImageComments WHERE id IN (SELECT C2.id FROM ImageComments AS C1,
ImageComments AS C2 WHERE C1.imageid=C2.imageid AND C1.type=C2.type AND
C1.language=C2.language AND C1.author IS NULL AND C2.author IS NULL AND C1.id <
C2.id);

(removes all second entries where the UNIQUE enforcement fails because author
is null)

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

https://bugs.kde.org/show_bug.cgi?id=189080





--- Comment #9 from Egbert König <e kunig home nl>  2009-04-13 15:43:43 ---
Thanks for the query. I have used it to identify the duplicate entries. As
sometimes the first entry had the right comment and sometimes the second, I
have delete the duplicate entries interactively with knoda/KDE3.

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gerhard Kulzer]

https://bugs.kde.org/show_bug.cgi?id=189080


Gerhard Kulzer <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[hidden email]




--- Comment #10 from Gerhard Kulzer <gerhard kulzer net>  2009-04-23 23:07:57 ---
*** Bug 190411 has been marked as a duplicate of this bug. ***

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Marcel Wiesweg]

https://bugs.kde.org/show_bug.cgi?id=189080


Marcel Wiesweg <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |RESOLVED
         Resolution|                            |FIXED




--- Comment #11 from Marcel Wiesweg <marcel wiesweg gmx de>  2009-07-05 18:10:39 ---
SVN commit 991767 by mwiesweg:

Take into account that a NULL value will prevent a UNIQUE restriction taking
effect.
1) In ImageComments, treat an empty author like a null author
2) When upgrading - there will still be users upgrading from 0.9, work around
it
   by deleting all affected entries before upgrading the image comments from
the old db

Users already affected by this bug need to solve it manually as outlined in the
bug report.

BUG: 189080

 M  +3 -1      NEWS  
 M  +9 -4      libs/database/imagecomments.cpp  
 M  +8 -0      libs/database/schemaupdater.cpp  


WebSVN link: http://websvn.kde.org/?view=rev&revision=991767

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Marcel Wiesweg]

https://bugs.kde.org/show_bug.cgi?id=189080


Marcel Wiesweg <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[hidden email]




--- Comment #12 from Marcel Wiesweg <marcel wiesweg gmx de>  2009-07-11 15:35:28 ---
*** Bug 199482 has been marked as a duplicate of this bug. ***

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Marcel Wiesweg]

https://bugs.kde.org/show_bug.cgi?id=189080


Marcel Wiesweg <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[hidden email]




--- Comment #13 from Marcel Wiesweg <marcel wiesweg gmx de>  2010-01-01 17:46:32 ---
*** Bug 220903 has been marked as a duplicate of this bug. ***

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=189080

Gilles Caulier <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Version Fixed In|                            |1.0.0

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[bugzilla_noreply]

https://bugs.kde.org/show_bug.cgi?id=189080

[hidden email] changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[hidden email]
          Component|Database                    |Database-Schema

--
You are receiving this mail because:
You are the assignee for the bug.