[Bug 187733] New: Cannot turn off sidebar after Infrared filter usage?

https://bugs.kde.org/show_bug.cgi?id=187733

           Summary: Cannot turn off sidebar after Infrared filter usage?
           Product: showfoto
           Version: 0.10.0
          Platform: unspecified
        OS/Version: Linux
            Status: UNCONFIRMED
          Severity: normal
          Priority: NOR
         Component: general
        AssignedTo: [hidden email]
        ReportedBy: [hidden email]


Version:           0.10.0 (using 4.2.1 (KDE 4.2.1), Kubuntu packages)
Compiler:          cc
OS:                Linux (i686) release 2.6.29-rc8

To reproduce:
Make sure sidebar tab is minimized (Geolocator, exif data, whatever)
Load picture
Go to Infrared filter (which has it's own huge usability issues)
Make changes to images and hit "Ok".
Sidebar (always on geolocator) is now on and jutting into window.

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

https://bugs.kde.org/show_bug.cgi?id=187733





--- Comment #1 from Brendan Barry <mailinglist endosquid com>  2009-03-20 20:17:36 ---
I think that this sidebar setting might be shared between the filter and the
editor, which is counter-intuitive, because in the filter, you absolutely need
the sidebar to set settings, etc. but in the editor proper, you don't want the
geolocator on most images just being there. This should probably be per-filter,
or even one setting for filters (Don't see how you can use them without a
sidebar, since that seems to be how they are built now) and for the editor,
which is usable without a sidebar.

I have a video showcasing all the problems with this flow and how it needs to
change with regard to display and usability bugs. Let me know who would like
the link to the video, since it has some images I wouldn't like public.

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=187733


Gilles Caulier <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[hidden email]




--- Comment #2 from Gilles Caulier <caulier gilles gmail com>  2009-04-17 09:57:16 ---
MArcel,

I confirm this problem with 0.11 implementation. Why sidebar is re-opened after
to use editor tool like Infrared ? I remember that you have fixed something
like that before 0.10 final release, or i'm wrong ?

Gilles

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

https://bugs.kde.org/show_bug.cgi?id=187733





--- Comment #3 from Andi Clemens <andi clemens gmx net>  2009-04-17 10:07:27 ---
But this behavior is true for every filter, not infrared only. The sidebar will
stay open (but at least I'm able to close it again).
There is another dysfunction here, we don't need the Try button, because
changing the ISO value will toggle the filter anyway.
I will remove it...

About the main issue: Can't we just save the sidebar state before entering a
filter?

Andi

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=187733





--- Comment #4 from Gilles Caulier <caulier gilles gmail com>  2009-04-17 10:11:12 ---
>About the main issue: Can't we just save the sidebar state before entering a
>filter?

It supposed to be done normally (:=))))

Gilles

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Marcel Wiesweg]

https://bugs.kde.org/show_bug.cgi?id=187733





--- Comment #5 from Marcel Wiesweg <marcel wiesweg gmx de>  2009-04-17 19:32:21 ---
There is a problem in line 261f. of sidebar.cpp. We store the size of 0 but
setting this fails. Need to try some solutions tomorrow. This code is prone to
create side effects and break when changed ;-)

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

https://bugs.kde.org/show_bug.cgi?id=187733





--- Comment #6 from Andi Clemens <andi clemens gmx net>  2009-04-17 20:29:40 ---
I had changed code for thumbnail bar in imagepreviewview that also had problems
when storing a size of zero. This isn't valid I guess. So I just saved the
whole thumbbar state, which seems to recognize a hidden / collapsed state and
therefore can restore the thumbbar in a correct way.

So maybe instead of saving a size of zero (I have not looked at the code now),
we should simply save the sidebar state... at least it worked fine for my
thumbbar problem.

Andi

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Marcel Wiesweg]

https://bugs.kde.org/show_bug.cgi?id=187733


Marcel Wiesweg <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |RESOLVED
         Resolution|                            |FIXED




--- Comment #7 from Marcel Wiesweg <marcel wiesweg gmx de>  2009-04-18 14:49:30 ---
SVN commit 955672 by mwiesweg:

Do not set previous tab from here. The sidebar will save state on its own.

BUG: 187733

 M  +2 -1      NEWS  
 M  +0 -5      utilities/imageeditor/editor/editortooliface.cpp  


WebSVN link: http://websvn.kde.org/?view=rev&revision=955672

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[bugzilla_noreply]

https://bugs.kde.org/show_bug.cgi?id=187733

[hidden email] changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Product|showfoto                    |digikam
          Component|general                     |showfoto

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel