[Bug 186823] New: several bugs in lens defect auto-correction plugin

[Matthias Welwarsky]

https://bugs.kde.org/show_bug.cgi?id=186823

           Summary: several bugs in lens defect auto-correction plugin
           Product: digikam
           Version: unspecified
          Platform: Ubuntu Packages
        OS/Version: Linux
            Status: UNCONFIRMED
          Severity: normal
          Priority: NOR
         Component: general
        AssignedTo: [hidden email]
        ReportedBy: [hidden email]


Version:           svn r937541 (using KDE 4.2.1)
OS:                Linux
Installed from:    Ubuntu Packages

chromatic aberration correction does not work:
- resulting image is transparent (alpha == 0)
- involves sub-pixel movements of color components, which is not implemented

distortion correction creates artifacts
- involves sub-pixel movements of image data, which is not implemented

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Matthias Welwarsky]

https://bugs.kde.org/show_bug.cgi?id=186823





--- Comment #1 from Matthias Welwarsky <matze welwarsky de>  2009-03-10 23:27:23 ---
Created an attachment (id=32009)
 --> (http://bugs.kde.org/attachment.cgi?id=32009)
proposed patch to fix the mentioned bugs

this patch implements access to interpolated image data in class DImg, either
via Lanczos or Bilinear interpolation. it also fixes the mentioned bugs in the
lens defect auto-correction plugin

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=186823


Gilles Caulier <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
          Component|general                     |Lens Distortion
            Version|unspecified                 |0.10.0-svn
            Product|digikam                     |digikamimageplugins




--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

https://bugs.kde.org/show_bug.cgi?id=186823





--- Comment #2 from Andi Clemens <andi clemens gmx net>  2009-04-12 22:14:27 ---
Matthias,

can you update your patch to current trunk? I tried to apply it but it failed.

Andi

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Matthias Welwarsky]

https://bugs.kde.org/show_bug.cgi?id=186823


Matthias Welwarsky <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #32009|0                           |1
        is obsolete|                            |




--- Comment #3 from Matthias Welwarsky <matze welwarsky de>  2009-04-13 16:17:52 ---
Created an attachment (id=32811)
 --> (http://bugs.kde.org/attachment.cgi?id=32811)
updated patch

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

https://bugs.kde.org/show_bug.cgi?id=186823


Andi Clemens <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #32811|0                           |1
        is obsolete|                            |




--- Comment #4 from Andi Clemens <andi clemens gmx net>  2009-04-21 15:03:10 ---
Created an attachment (id=32985)
 --> (http://bugs.kde.org/attachment.cgi?id=32985)
patch without tabs

I removed the tabs from the patch.
Sorry I hadn't the time yet to look at the patch, it is quite big.
I guess we need to discuss this further, at least I will not commit it on my
own :-)

Gilles, Marcel,

can you take a look at this patch, too?

Andi

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Matthias Welwarsky]

https://bugs.kde.org/show_bug.cgi?id=186823





--- Comment #5 from Matthias Welwarsky <matze welwarsky de>  2009-04-21 15:15:12 ---
We can meet on IRC if you need real time.

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=186823


Gilles Caulier <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[hidden email]




--- Comment #6 from Gilles Caulier <caulier gilles gmail com>  2009-04-21 16:13:50 ---
Yes, patch is huge. Great job.

Marcel, patch touch DImg component indeep. Can you take a look. I will do it
also, but it a sensible part...

Gilles

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Marcel Wiesweg]

https://bugs.kde.org/show_bug.cgi?id=186823





--- Comment #7 from Marcel Wiesweg <marcel wiesweg gmx de>  2009-04-22 19:50:38 ---
There are a lot of whitespace changes in the API docs of dimg.h. I think these
are a side-product of the patch processing and should be removed from the patch
- then it is much smaller.
For me the characters of Ville's surname in the copyright notice are broken as
well. Encoding issue.

Other than that, I see a bug fix in blendClamp8() and the rest is added
methods, that's fine with me.

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=186823





--- Comment #8 from Gilles Caulier <caulier gilles gmail com>  2009-04-23 10:24:39 ---
Thanks Marcel.

I review patch today...

Gilles

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=186823


Gilles Caulier <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |RESOLVED
         Resolution|                            |FIXED




--- Comment #9 from Gilles Caulier <caulier gilles gmail com>  2009-04-23 13:07:59 ---
SVN commit 958053 by cgilles:

apply patch #32985 from Matthias Welwarsky fo fix LensFun tool with Lanzcos
method
BUG: 186823


 M  +7 -7      imageplugins/lenscorrection/autocorrection/klensfun.cpp  
 M  +1 -0      libs/dimg/dcolor.h  
 M  +16 -9     libs/dimg/dcolorblend.h  
 M  +218 -2    libs/dimg/dimg.cpp  
 M  +96 -80    libs/dimg/dimg.h  
 M  +28 -1     libs/dimg/dimgprivate.h  


WebSVN link: http://websvn.kde.org/?view=rev&revision=958053

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=186823


Gilles Caulier <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Version|0.10.0-svn                  |0.10.0




--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=186823

Gilles Caulier <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Version Fixed In|                            |1.0.0

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel