[Bug 181964] New: Image Editor's "fit-to-window" is broken when invoking a filter

http://bugs.kde.org/show_bug.cgi?id=181964

           Summary: Image Editor's "fit-to-window" is broken when invoking a
                    filter
           Product: digikam
           Version: 0.10.0-rc2
          Platform: unspecified
        OS/Version: Linux
            Status: NEW
          Severity: normal
          Priority: NOR
         Component: Image Editor
        AssignedTo: [hidden email]
        ReportedBy: [hidden email]


Version:           0.10.0-rc2 (using 4.1.4 (KDE 4.1.4), Arch Linux)
Compiler:          gcc
OS:                Linux (i686) release 2.6.28-ARCH

If you have selected "fit-to-window" in the editor and start a filter, the
image gets zoomed in, but "fit-to-window" is still toggled. If you press
"fit-to-window" button now it becomes deselected, but the image will be fit to
screen now.

Also when "fit-to-window" is toggled and you zoom in / out, the button will
still be toggled, normally it should be deselected now.

I tried to find the relevant code, but I have not found it right now. It looks
like the tool is not reading the zoom settings of the editor window.

Andi


--
Configure bugmail: http://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

http://bugs.kde.org/show_bug.cgi?id=181964





--- Comment #1 from Gilles Caulier <caulier gilles gmail com>  2009-01-26 11:25:10 ---
Note: there are 2 cases: editor tool is use image preview widget with zomming
feature (sharp for ex.) or not (curves for ex.).

With Sharp tool:

1/ fit to window in editor, start sharp tool => fit to window action is
disabled

2/ apply sharp tool => fit to window action is enabled and zoom level restored
(it can be changed a little but this is duing to right sidebar splitter size
changes.

With Curves tool: like there is no zooming feature here, zoom+ and zoom-
actions must be disabled (this is not the case, but actions do not have effect)

All interaction betwen zoom action and tool are here :

http://lxr.kde.org/source/extragear/graphics/digikam/utilities/imageeditor/editor/editorstackview.cpp

Code to switch on/off standard action in editor is here :

http://lxr.kde.org/source/extragear/graphics/digikam/utilities/imageeditor/editor/editorwindow.cpp#973

...and is called by:

http://lxr.kde.org/source/extragear/graphics/digikam/utilities/imageeditor/editor/editortooliface.cpp#098
http://lxr.kde.org/source/extragear/graphics/digikam/utilities/imageeditor/editor/editortooliface.cpp#109

Gilles


--
Configure bugmail: http://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

http://bugs.kde.org/show_bug.cgi?id=181964





--- Comment #2 from Andi Clemens <andi clemens gmx net>  2009-01-26 12:29:03 ---
Is there a reason why we don't allow zooming in curves tool?
It can be very useful to zoom in, when I use Gimp and the curve tool in there,
I zoom a lot to see that I am not loosing too many details.


--
Configure bugmail: http://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

http://bugs.kde.org/show_bug.cgi?id=181964


Gilles Caulier caulier gilles gmail com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[hidden email]




--- Comment #3 from Gilles Caulier <caulier gilles gmail com>  2009-01-26 12:35:31 ---
This is the purpose to factorize all image plugins preview widget to a commun
implementation

Gilles


--
Configure bugmail: http://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

http://bugs.kde.org/show_bug.cgi?id=181964





--- Comment #4 from Andi Clemens <andi clemens gmx net>  2009-01-26 12:36:19 ---
Ok so we will do better here :-)

Andi


--
Configure bugmail: http://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

http://bugs.kde.org/show_bug.cgi?id=181964





--- Comment #5 from Andi Clemens <andi clemens gmx net>  2009-01-26 13:01:07 ---
Zoom is acting weird in general, found another issue:

1. Open a plugin that can zoom
2. Zoom out until the zoom out action is disabled
3. toggle fit-to-window
4. zoom in: zoom out action will not be enabled (sometimes it will when zooming
to 400% or more)

I think we should not put too much effort in this right now, it seems to be a
bigger problem and is easier to fix when switching to the new editor preview
widget?

Andi


--
Configure bugmail: http://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

http://bugs.kde.org/show_bug.cgi?id=181964


Gilles Caulier caulier gilles gmail com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|                            |FIXED




--- Comment #6 from Gilles Caulier <caulier gilles gmail com>  2009-01-26 15:35:47 ---
SVN commit 916945 by cgilles:

digiKam from trunk : fix some issues with zoom action between canvas and editor
tool preview.
For the moment, only Zoom+ and Zoom- actions are properly managed. Later, when
all Editor Tool
preview widget will be factored, we will improve zoom management to include
Zoom Fit and Zoom Combox.
BUG: 181964


 M  +6 -8      editorstackview.h  
 M  +11 -0     editortooliface.cpp  
 M  +14 -19    editorwindow.cpp  
 M  +1 -0      editorwindow.h  


WebSVN link: http://websvn.kde.org/?view=rev&revision=916945


--
Configure bugmail: http://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=181964


Gilles Caulier <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Version|0.10.0-rc2                  |0.10.0




--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=181964

Gilles Caulier <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Version Fixed In|                            |0.10.0

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel