[Bug 181940] New: image editor tools does not remember preview mode

[Anders Lund]

http://bugs.kde.org/show_bug.cgi?id=181940

           Summary: image editor tools does not remember preview mode
           Product: digikam
           Version: 0.10.0-rc1
          Platform: unspecified
        OS/Version: Linux
            Status: NEW
          Severity: normal
          Priority: NOR
         Component: general
        AssignedTo: [hidden email]
        ReportedBy: [hidden email]


Version:           0.10.0-rc1 (using 4.2.00 (KDE 4.2.0), Arch Linux)
Compiler:          gcc
OS:                Linux (x86_64) release 2.6.28-ARCH

that is a regression :( For someone not using defaults, this makes using the
image editor a PITA.


--
Configure bugmail: http://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

http://bugs.kde.org/show_bug.cgi?id=181940


Gilles Caulier caulier gilles gmail com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
          Component|general                     |Image Editor




--- Comment #1 from Gilles Caulier <caulier gilles gmail com>  2009-01-26 06:17:16 ---
Not reproducible here. Which editor tool is affected ?

Gilles Caulier


--
Configure bugmail: http://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

http://bugs.kde.org/show_bug.cgi?id=181940





--- Comment #2 from Andi Clemens <andi clemens gmx net>  2009-01-26 09:51:49 ---
I can confirm it, I only tested "sharpen" but there the issue is already
noticeable.

Andi


--
Configure bugmail: http://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

http://bugs.kde.org/show_bug.cgi?id=181940


Gilles Caulier caulier gilles gmail com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|                            |FIXED




--- Comment #3 from Gilles Caulier <caulier gilles gmail com>  2009-01-26 10:46:46 ---
SVN commit 916862 by cgilles:

digiKam from trunk : force to record EditorTool preview mode settings when tool
is closed.
BUG: 181940


 M  +2 -0      imageplugins/adjustcurves/adjustcurvestool.cpp  
 M  +2 -0      imageplugins/adjustlevels/adjustlevelstool.cpp  
 M  +1 -0      imageplugins/blurfx/blurfxtool.cpp  
 M  +2 -0      imageplugins/border/bordertool.cpp  
 M  +3 -1      imageplugins/channelmixer/channelmixertool.cpp  
 M  +1 -0      imageplugins/charcoal/charcoaltool.cpp  
 M  +1 -0      imageplugins/colorfx/colorfxtool.cpp  
 M  +1 -0      imageplugins/coreplugin/autocorrectiontool.cpp  
 M  +7 -6      imageplugins/coreplugin/bcgtool.cpp  
 M  +1 -0      imageplugins/coreplugin/blurtool.cpp  
 M  +1 -0      imageplugins/coreplugin/bwsepiatool.cpp  
 M  +1 -0      imageplugins/coreplugin/hsl/hsltool.cpp  
 M  +1 -0      imageplugins/coreplugin/iccprooftool.cpp  
 M  +1 -0      imageplugins/coreplugin/redeyetool.cpp  
 M  +1 -0      imageplugins/coreplugin/rgbtool.cpp  
 M  +1 -0      imageplugins/coreplugin/sharpnesseditor/sharpentool.cpp  
 M  +3 -2      imageplugins/distortionfx/distortionfxtool.cpp  
 M  +1 -0      imageplugins/emboss/embosstool.cpp  
 M  +3 -2      imageplugins/filmgrain/filmgraintool.cpp  
 M  +3 -2      imageplugins/freerotation/freerotationtool.cpp  
 M  +1 -0      imageplugins/hotpixels/hotpixelstool.cpp  
 M  +1 -0      imageplugins/infrared/infraredtool.cpp  
 M  +4 -4      imageplugins/inpainting/inpaintingtool.cpp  
 M  +2 -0    
imageplugins/lenscorrection/autocorrection/autocorrectiontool.cpp  
 M  +1 -0      imageplugins/lenscorrection/distortion/lensdistortiontool.cpp  
 M  +1 -0      imageplugins/lenscorrection/vignetting/antivignettingtool.cpp  
 M  +3 -2      imageplugins/noisereduction/noisereductiontool.cpp  
 M  +1 -0      imageplugins/oilpaint/oilpainttool.cpp  
 M  +1 -0      imageplugins/raindrop/raindroptool.cpp  
 M  +1 -0      imageplugins/restoration/restorationtool.cpp  
 M  +13 -12    imageplugins/sheartool/sheartool.cpp  
 M  +3 -2      imageplugins/texture/texturetool.cpp  
 M  +1 -0      imageplugins/whitebalance/whitebalancetool.cpp  
 M  +2 -1      libs/widgets/imageplugins/imagepanelwidget.h  
 M  +1 -1      libs/widgets/imageplugins/imagewidget.h  


WebSVN link: http://websvn.kde.org/?view=rev&revision=916862


--
Configure bugmail: http://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

http://bugs.kde.org/show_bug.cgi?id=181940





--- Comment #4 from Andi Clemens <andi clemens gmx net>  2009-01-26 10:55:46 ---
Wouldn't it be even better if this setting is saved as a general value?
If I change the preview mode in "Sharpen" and start "Blur" after that, I
somehow expect to have the same preview mode I had used in "Sharpen" before.

Andi


--
Configure bugmail: http://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

http://bugs.kde.org/show_bug.cgi?id=181940





--- Comment #5 from Gilles Caulier <caulier gilles gmail com>  2009-01-26 11:00:47 ---
Andi,

Well for the moment, each tool as a dedicated settings saved in rc file
section.

Perhaps we can factorize it when we preview widget will be redesigned in 0.11

Gilles


--
Configure bugmail: http://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

http://bugs.kde.org/show_bug.cgi?id=181940





--- Comment #6 from Gilles Caulier <caulier gilles gmail com>  2009-01-26 11:02:06 ---
SVN commit 916865 by cgilles:

backport commit #916862 from trunk
CCBUG: 181940


 M  +1 -0      imageplugins/adjustcurves/adjustcurvestool.cpp  
 M  +1 -0      imageplugins/adjustlevels/adjustlevelstool.cpp  
 M  +1 -0      imageplugins/antivignetting/antivignettingtool.cpp  
 M  +20 -19    imageplugins/blurfx/blurfxtool.cpp  
 M  +2 -0      imageplugins/border/bordertool.cpp  
 M  +2 -0      imageplugins/channelmixer/channelmixertool.cpp  
 M  +1 -0      imageplugins/charcoal/charcoaltool.cpp  
 M  +1 -0      imageplugins/colorfx/colorfxtool.cpp  
 M  +1 -0      imageplugins/coreplugin/autocorrectiontool.cpp  
 M  +1 -0      imageplugins/coreplugin/bcgtool.cpp  
 M  +1 -0      imageplugins/coreplugin/bwsepiatool.cpp  
 M  +1 -0      imageplugins/coreplugin/hsl/hsltool.cpp  
 M  +1 -0      imageplugins/coreplugin/iccprooftool.cpp  
 M  +1 -0      imageplugins/coreplugin/redeyetool.cpp  
 M  +17 -16    imageplugins/coreplugin/rgbtool.cpp  
 M  +1 -0      imageplugins/coreplugin/sharpnesseditor/sharpentool.cpp  
 M  +1 -0      imageplugins/distortionfx/distortionfxtool.cpp  
 M  +1 -0      imageplugins/emboss/embosstool.cpp  
 M  +1 -0      imageplugins/filmgrain/filmgraintool.cpp  
 M  +1 -0      imageplugins/freerotation/freerotationtool.cpp  
 M  +1 -0      imageplugins/hotpixels/hotpixelstool.cpp  
 M  +1 -0      imageplugins/infrared/infraredtool.cpp  
 M  +1 -0      imageplugins/inpainting/inpaintingtool.cpp  
 M  +1 -0      imageplugins/lensdistortion/lensdistortiontool.cpp  
 M  +1 -0      imageplugins/noisereduction/noisereductiontool.cpp  
 M  +1 -0      imageplugins/oilpaint/oilpainttool.cpp  
 M  +3 -2      imageplugins/raindrop/raindroptool.cpp  
 M  +1 -0      imageplugins/restoration/restorationtool.cpp  
 M  +1 -0      imageplugins/sheartool/sheartool.cpp  
 M  +1 -0      imageplugins/texture/texturetool.cpp  
 M  +1 -0      imageplugins/whitebalance/whitebalancetool.cpp  
 M  +2 -1      libs/widgets/imageplugins/imagepanelwidget.h  
 M  +10 -10    libs/widgets/imageplugins/imagewidget.h  
 M  +11 -11    project/project.kdevelop  


WebSVN link: http://websvn.kde.org/?view=rev&revision=916865


--
Configure bugmail: http://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Anders Lund]

http://bugs.kde.org/show_bug.cgi?id=181940





--- Comment #7 from Anders Lund <anders alweb dk>  2009-01-26 17:13:23 ---
Gilles, thank you for fixing so fast!

FWIW, I think that having a common setting is fine, it is probably mostly a
question of taste how one likes it. (I personally favor the "mouse over"
concept and uses it everywhere available)


--
Configure bugmail: http://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=181940


Gilles Caulier <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Version|0.10.0-rc1                  |0.10.0




--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel