[Bug 179766] New: Auto crop does not fully remove black corners created by free rotation

http://bugs.kde.org/show_bug.cgi?id=179766

           Summary: Auto crop does not fully remove black corners created by
                    free rotation
           Product: digikamimageplugins
           Version: unspecified
          Platform: unspecified
        OS/Version: Linux
            Status: UNCONFIRMED
          Severity: normal
          Priority: NOR
         Component: Free Rotation
        AssignedTo: [hidden email]
        ReportedBy: [hidden email]


Version:           unknown (using 4.1.85 (KDE 4.1.85 (KDE 4.2 Beta2)), Kubuntu
packages)
Compiler:          cc
OS:                Linux (x86_64) release 2.6.27-7-generic

When using the free rotation tool, the rotated image is put into an upright
rectangle such that the corners are black triangles. The auto crop options of
this tool are supposed to crop the picture to the widest or largest upright
rectangle selection avoiding these areas. But in the current version, using the
auto crop option often leaves parts of the black background triangles in the
cut final image, for sure an undesired effect.


--
Configure bugmail: http://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

http://bugs.kde.org/show_bug.cgi?id=179766


Gilles Caulier caulier gilles gmail com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Version|unspecified                 |0.10.0-svn




--- Comment #1 from Gilles Caulier <caulier gilles gmail com>  2009-01-06 06:34:59 ---
I let's black frame as well, or a part is croped ?

Image is really rotated ?

Gilles Caulier


--
Configure bugmail: http://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

http://bugs.kde.org/show_bug.cgi?id=179766





--- Comment #2 from Gandalf Lechner <gandalf lechner univie ac at>  2009-01-06 13:50:28 ---
Created an attachment (id=29969)
 --> (http://bugs.kde.org/attachment.cgi?id=29969)
screenshot

picture showing the result of free rotation without and with auto crop


--
Configure bugmail: http://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

http://bugs.kde.org/show_bug.cgi?id=179766


Gilles Caulier caulier gilles gmail com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |NEW
     Ever Confirmed|0                           |1




--- Comment #3 from Gilles Caulier <caulier gilles gmail com>  2009-01-26 11:30:14 ---
I confirm this problem with KDE4 and KDE3.

It's another side effect of Editor Tool port (i think)

Gilles


--
Configure bugmail: http://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

https://bugs.kde.org/show_bug.cgi?id=179766





--- Comment #4 from Andi Clemens <andi clemens gmx net>  2009-02-18 20:41:42 ---
This seems only to be true for portrait oriented images, landscape oriented
works fine here.

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=179766





--- Comment #5 from Gilles Caulier <caulier gilles gmail com>  2009-02-19 09:54:26 ---
The question is why? The code in this plugin (algorithm) is unchanged since a
while.

The only way to check is Editor Tool api port. This problem appear since plugin
dialog have been removed.

Perhaps a slots/signal race condition when plugin widget is raised from widget
stack ?

Gilles

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

https://bugs.kde.org/show_bug.cgi?id=179766





--- Comment #6 from Andi Clemens <andi clemens gmx net>  2009-04-07 18:55:17 ---
By quickly looking over the filter I ask myself if the auto-crop algorithms
were only written for landscape images?
Neither WidestArea nor LargestArea are working correctly if used with portrait
images.

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=179766


Gilles Caulier <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[hidden email]




--- Comment #7 from Gilles Caulier <caulier gilles gmail com>  2009-04-07 19:06:56 ---
One of algorithm have been written by Gerhard Kulzer. Ask to him...

Other one, By Renchi Raju if i remember (not available in team now...)

Look comments in code for details

Gilles

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gerhard Kulzer]

https://bugs.kde.org/show_bug.cgi?id=179766





--- Comment #8 from Gerhard Kulzer <gerhard kulzer net>  2009-04-08 09:27:19 ---
I'll have a look
Gerhard

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

https://bugs.kde.org/show_bug.cgi?id=179766





--- Comment #9 from Andi Clemens <andi clemens gmx net>  2009-04-26 20:09:58 ---
Is this auto crop code "borrowed" from Gimp? Because in Gimp auto-cropping
portrait images also doesn't work. If you set clipping in Gimp to "crop to
result", it works (seems to be what we call "widest area" in our tool.
But if you set clipping to "crop with aspect", it just shows a transparent
layer, at least on my machine (Gimp 2.6.6).

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

https://bugs.kde.org/show_bug.cgi?id=179766





--- Comment #10 from Andi Clemens <andi clemens gmx net>  2009-05-24 15:03:51 ---
I just installed KDE3 again (what a pain) to test this feature here.
I checked out everything from May 2008 till now and compiled it. Even in May
last year the crop didn't work so I don't think this is related to the changes
of the image editor. If this feature really worked before, it must have been in
2007 or so, because no significant changes where made to
imageplugins/freerotation/freerotation.cpp tool in the last 1 1/2 year.

I would assume it never worked. Unfortunately I'm not able to go back even more
in time, because everything below May 2008 will not compile here anymore.

Andi

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

https://bugs.kde.org/show_bug.cgi?id=179766





--- Comment #11 from Andi Clemens <andi clemens gmx net>  2009-05-24 19:30:19 ---
I checked out a VERY old version of the digikamimageplugins package from the
SVN repository. Even the version from 2005 doesn't differ from the current one,
so I would really assume it never worked for horizontal images.
Actually this can't be so hard to fix, I will take a look at it, too.
It's been a while since I had math classes, but I will try to analyze the code
now.

Andi

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

https://bugs.kde.org/show_bug.cgi?id=179766





--- Comment #12 from Andi Clemens <andi clemens gmx net>  2009-05-24 19:37:19 ---
(In reply to comment #11)
> ... so I would really assume it never worked for horizontal images.

Vertical / Portrait I mean.

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

https://bugs.kde.org/show_bug.cgi?id=179766


Andi Clemens <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[hidden email]




--- Comment #13 from Andi Clemens <andi clemens gmx net>  2009-05-30 15:29:16 ---
*** Bug 194660 has been marked as a duplicate of this bug. ***

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

https://bugs.kde.org/show_bug.cgi?id=179766





--- Comment #14 from Andi Clemens <andi clemens gmx net>  2009-05-30 17:19:54 ---
SVN commit 975580 by aclemens:

First attempt to fix auto-crop: I played around with the algorithm a
little and it seems to work quite well.
Can you confirm this?

Andi

CCBUG:179766

 M  +50 -28    freerotation.cpp  


WebSVN link: http://websvn.kde.org/?view=rev&revision=975580

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

https://bugs.kde.org/show_bug.cgi?id=179766





--- Comment #15 from Andi Clemens <andi clemens gmx net>  2009-05-30 17:21:28 ---
I only touched "Largest area" for now...

Andi

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

https://bugs.kde.org/show_bug.cgi?id=179766


Andi Clemens <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|                            |FIXED




--- Comment #16 from Andi Clemens <andi clemens gmx net>  2009-05-30 17:53:25 ---
I will close this one now, it should work for others, too :-D
"Widest Area"-Crop seems to be ok.

Andi

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

https://bugs.kde.org/show_bug.cgi?id=179766





--- Comment #17 from Mikolaj Machowski <mikmach wp pl>  2009-05-31 15:31:10 ---
There is strange bug:

When selecting Largest Area in options image is moved one pixel up and right
and along longer border appear black stripe. Looks like this doesn't affect
final output. Only preview problem.

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

https://bugs.kde.org/show_bug.cgi?id=179766





--- Comment #18 from Andi Clemens <andi clemens gmx net>  2009-05-31 15:37:43 ---
Yes, I know. Preview bug, because no rotation took place and so no cropping is
done. Don't know why... but the final will not be cropped.

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

https://bugs.kde.org/show_bug.cgi?id=179766





--- Comment #19 from Andi Clemens <andi clemens gmx net>  2009-05-31 15:38:27 ---
Hmm maybe we can ignore slotEffect when angle is 0.0. So this bug should be
gone. Will try this.

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel