[Bug 179548] New: additional guide for aspect ratio crop

http://bugs.kde.org/show_bug.cgi?id=179548





--- Comment #20 from Mikolaj Machowski <mikmach wp pl>  2009-01-09 01:35:24 ---
OK, don't know why but old build system turned off imageplugins and
themedesigner. Whatever.

Ad rem - I was wrong when reading patch, interface should be fixed:

- DM is separate way of composition its place is in menu, not in checkboxes
- flipping does nothing for this method (it is symmetrical) so when DM is
selected all checkboxes should be deactivated.


--
Configure bugmail: http://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

http://bugs.kde.org/show_bug.cgi?id=179548





--- Comment #21 from simon margo student utwente nl  2009-01-09 10:02:07 ---
Mikolaj

I agree with your comments, however I'm afraid my knowledge of the code and
libraries is not sufficient to do this myself :-(

Would you be willing to do this, or give me a hint on how to do this myself?

Cheers

Simon


--
Configure bugmail: http://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

http://bugs.kde.org/show_bug.cgi?id=179548


Mikolaj Machowski mikmach wp pl changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #30020|0                           |1
        is obsolete|                            |




--- Comment #22 from Mikolaj Machowski <mikmach wp pl>  2009-01-09 18:07:40 ---
Created an attachment (id=30063)
 --> (http://bugs.kde.org/attachment.cgi?id=30063)
New - simpler - patch for DM

This patch removes unnecessary elements/interactions from interface, also fixes
whitespace issues from previous patches.

One bug still remains (don't know how to fix this) - guides in Diagonal Method
don't react on changes in color and size.


--
Configure bugmail: http://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

http://bugs.kde.org/show_bug.cgi?id=179548





--- Comment #23 from simon margo student utwente nl  2009-01-10 23:29:50 ---
Hi Mikolaj, your patch works fine as well and deactivating the flips is better
this way.

Regarding the colour, it appears that the others are all drawing twice, once in
white, once in dotted line with the selected colour. This seems rather ugly in
the code, because it's all code that appears twice. I'd make a new function to
draw twice the same line in one go, but I don't know how much work this would
be to implement this now in existing code...

Cheers

Simon


--
Configure bugmail: http://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

http://bugs.kde.org/show_bug.cgi?id=179548





--- Comment #24 from simon margo student utwente nl  2009-01-11 13:48:48 ---
Created an attachment (id=30127)
 --> (http://bugs.kde.org/attachment.cgi?id=30127)
this one will also add the dotted coloured line (the ugly way)

In this patch, I've added the code to draw the dotted line in the way that all
the other methods do it (just copy the code after a change of pen style)

The good way to solve this and all the other methods would be to write a
function/method that will draw two lines (e.g. drawGuideLine() ) and use that
instead of drawLine() and setPen().

void drawGuideLine( QPainter* p, int x1, y1, x2, y2) {
 p->setPen(QPen(Qt::white, d->guideSize, Qt::SolidLine));
 p->drawLine(x1, y1, x2, y2);
 p->setPen(QPen(d->guideColor, d->guideSize, Qt::DotLine));
 p->drawLine(x1, y1, x2, y2);
}

Or something like that (my c++ isn't fresh ;-)

/Simon


--
Configure bugmail: http://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

http://bugs.kde.org/show_bug.cgi?id=179548


Mikolaj Machowski mikmach wp pl changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #30063|0                           |1
        is obsolete|                            |
  Attachment #30127|0                           |1
        is obsolete|                            |




--- Comment #25 from Mikolaj Machowski <mikmach wp pl>  2009-01-11 15:18:20 ---
Created an attachment (id=30130)
 --> (http://bugs.kde.org/attachment.cgi?id=30130)
final (I hope) version of patch for 0.9.x

Final version of patch for 0.9.x, fixes for Simon version:
- remove last unnecessary comments
- fixes white spaces
- swap DM and Harmonious Triangles. Latter use partially control panel below so
belon near Golden Mean


--
Configure bugmail: http://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

http://bugs.kde.org/show_bug.cgi?id=179548





--- Comment #26 from Mikolaj Machowski <mikmach wp pl>  2009-01-11 15:29:59 ---
Created an attachment (id=30131)
 --> (http://bugs.kde.org/attachment.cgi?id=30131)
Adding feature for 0.10


--
Configure bugmail: http://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

http://bugs.kde.org/show_bug.cgi?id=179548


Mikolaj Machowski mikmach wp pl changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|additional guide for aspect |additional guide for aspect
                   |ratio crop                  |ratio crop [patches for KDE3
                   |                            |and KDE4]




--
Configure bugmail: http://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

http://bugs.kde.org/show_bug.cgi?id=179548





--- Comment #27 from simon margo student utwente nl  2009-01-11 16:13:43 ---
Created an attachment (id=30132)
 --> (http://bugs.kde.org/attachment.cgi?id=30132)
This patch shows how I meant in the previous comment, to draw the lines

This one would conflict with the last patch from Mikolaj, but I think it would
be easy to resolve this. Consider it a proof of concept, but I tested the patch
and it works.

/Simon


--
Configure bugmail: http://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

http://bugs.kde.org/show_bug.cgi?id=179548





--- Comment #28 from Mikolaj Machowski <mikmach wp pl>  2009-01-16 16:58:03 ---
I'd like to remind about this one: it introduces new strings and on 18.01
string freeze kicks in.


--
Configure bugmail: http://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

http://bugs.kde.org/show_bug.cgi?id=179548





--- Comment #29 from simon margo student utwente nl  2009-01-16 20:07:25 ---
Mikolaj

what needs to be done?
I think only Gilles needs to approve the patches for 0.9.5 and 0.10.0?

/Simon


--
Configure bugmail: http://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

http://bugs.kde.org/show_bug.cgi?id=179548





--- Comment #30 from Gilles Caulier <caulier gilles gmail com>  2009-01-16 20:24:03 ---
I promise, i take a look soon.

Question : patch exist for KDE3 _and_ KDE4 ?

Gilles


--
Configure bugmail: http://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

http://bugs.kde.org/show_bug.cgi?id=179548





--- Comment #31 from simon margo student utwente nl  2009-01-16 20:53:02 ---
Although I haven't been able to test it (due to not having a working 4.2.x
setup) I believe Mikolaj's patch http://bugs.kde.org/attachment.cgi?id=30131 is
for the KDE4 version...

/Simon


--
Configure bugmail: http://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

http://bugs.kde.org/show_bug.cgi?id=179548





--- Comment #32 from Mikolaj Machowski <mikmach wp pl>  2009-01-16 21:26:26 ---
Yes, Gilles has to approve and commit patches :)

Yes, there are two patches, one for 0.9.5

http://bugs.kde.org/attachment.cgi?id=30130

and second for 0.10

http://bugs.kde.org/attachment.cgi?id=30131

Written by Simon, adjusted and tested by me (both for KDE3 and KDE4).


--
Configure bugmail: http://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

http://bugs.kde.org/show_bug.cgi?id=179548





--- Comment #33 from Gilles Caulier <caulier gilles gmail com>  2009-01-17 18:06:55 ---
SVN commit 912532 by cgilles:

digiKAm from KDE3 branch: added great patch from Simon Margo about to add new
composition guide in Ratio Crop Tool based on Diagonal Rules.
CCBUG: 179548
CCMAIL: [hidden email]


 M  +54 -12    imageselectionwidget.cpp  
 M  +2 -1      imageselectionwidget.h  
 M  +52 -39    ratiocroptool.cpp  
 M  +1 -1      ratiocroptool.h  


WebSVN link: http://websvn.kde.org/?view=rev&revision=912532


--
Configure bugmail: http://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

http://bugs.kde.org/show_bug.cgi?id=179548


Gilles Caulier caulier gilles gmail com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|                            |FIXED




--- Comment #34 from Gilles Caulier <caulier gilles gmail com>  2009-01-17 18:48:10 ---
SVN commit 912554 by cgilles:

backport commit #912532 from KDE3 branch
BUG: 179548
CCMAIL: [hidden email]


 M  +76 -33    imageselectionwidget.cpp  
 M  +16 -15    imageselectionwidget.h  
 M  +56 -45    ratiocroptool.cpp  
 M  +2 -2      ratiocroptool.h  


WebSVN link: http://websvn.kde.org/?view=rev&revision=912554


--
Configure bugmail: http://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=179548


Gilles Caulier <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
          Component|Core Plugin                 |Aspect Ratio Crop




--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[bugzilla_noreply]

https://bugs.kde.org/show_bug.cgi?id=179548

[hidden email] changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Version|0.9.5                       |4.9.0
          Component|Aspect Ratio Crop           |Tool-RatioCrop
            Product|digikamimageplugins         |digikam

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel