http://bugs.kde.org/show_bug.cgi?id=178061
Summary: [PATCH] scancontroller missing dependecy to CacheLock (CMAKE) Product: digikam Version: unspecified Platform: unspecified OS/Version: Linux Status: UNCONFIRMED Severity: normal Priority: NOR Component: general AssignedTo: [hidden email] ReportedBy: [hidden email] Version: Unbekannt (using 4.1.85 (KDE 4.1.85 (KDE 4.2 Beta2)), Gentoo) Compiler: x86_64-pc-linux-gnu-gcc OS: Linux (x86_64) release 2.6.26-tuxonice hi, current svn didn't build for me using a selfmade gentoo live ebuild, so i tried plain svn which also complained about scancontroller.cpp:(.text+0xab5): undefined reference to `Digikam::LoadingCache::CacheLock::CacheLock(Digikam::LoadingCache*)' i fiddled with it and at least it worked, i'm no cmake guy at all so please review! Index: themedesigner/CMakeLists.txt =================================================================== --- themedesigner/CMakeLists.txt (Revision 898349) +++ themedesigner/CMakeLists.txt (Arbeitskopie) @@ -94,6 +94,7 @@ ${libcameragui_SRCS} ${libsetup_SRCS} ${libbatch_SRCS} + ${libthreadimageio_SRCS} main.cpp mainwindow.cpp Index: digikam/CMakeLists.txt =================================================================== --- digikam/CMakeLists.txt (Revision 898349) +++ digikam/CMakeLists.txt (Arbeitskopie) @@ -178,6 +178,7 @@ ${libfuzzysearch_SRCS} ${libgpssearch_SRCS} ${libtimeline_SRCS} + ${libthreadimageio_SRCS} album.cpp albumiconview.cpp -- Configure bugmail: http://bugs.kde.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. _______________________________________________ Digikam-devel mailing list [hidden email] https://mail.kde.org/mailman/listinfo/digikam-devel |
http://bugs.kde.org/show_bug.cgi?id=178061
Gilles Caulier caulier gilles gmail com changed: What |Removed |Added ---------------------------------------------------------------------------- Version|unspecified |0.10.0-svn -- Configure bugmail: http://bugs.kde.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. _______________________________________________ Digikam-devel mailing list [hidden email] https://mail.kde.org/mailman/listinfo/digikam-devel |
In reply to this post by Simon Bühler
http://bugs.kde.org/show_bug.cgi?id=178061
Marcel Wiesweg marcel wiesweg gmx de changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |[hidden email] --- Comment #1 from Marcel Wiesweg <marcel wiesweg gmx de> 2008-12-19 09:51:54 --- Can you try this patch instead. Maybe your compiler treats visibility of inner classes differently than mine. The threadimageio sources are already included in libdigikamcore, which digikam links. diff --git a/libs/threadimageio/loadingcache.h b/libs/threadimageio/loadingcache.h index 515623f..813fc7c 100644 --- a/libs/threadimageio/loadingcache.h +++ b/libs/threadimageio/loadingcache.h @@ -127,7 +127,7 @@ public: /// !! All methods of LoadingCache shall only be called when a CacheLock is held !! - class CacheLock + class DIGIKAM_EXPORT CacheLock { public: -- Configure bugmail: http://bugs.kde.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. _______________________________________________ Digikam-devel mailing list [hidden email] https://mail.kde.org/mailman/listinfo/digikam-devel |
In reply to this post by Simon Bühler
http://bugs.kde.org/show_bug.cgi?id=178061
--- Comment #2 from Simon Bühler <simon aktionspotential de> 2008-12-21 12:40:49 --- thanks, this fixed it -- Configure bugmail: http://bugs.kde.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. _______________________________________________ Digikam-devel mailing list [hidden email] https://mail.kde.org/mailman/listinfo/digikam-devel |
In reply to this post by Simon Bühler
http://bugs.kde.org/show_bug.cgi?id=178061
--- Comment #3 from Marcel Wiesweg <marcel wiesweg gmx de> 2008-12-21 16:21:33 --- SVN commit 899773 by mwiesweg: Some compilers apparently treat inner classes visibility independent from the outer class, so that we need to set the visibility flag for CacheLock as well. CCBUG: 178061 M +1 -1 loadingcache.h WebSVN link: http://websvn.kde.org/?view=rev&revision=899773 -- Configure bugmail: http://bugs.kde.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. _______________________________________________ Digikam-devel mailing list [hidden email] https://mail.kde.org/mailman/listinfo/digikam-devel |
In reply to this post by Simon Bühler
http://bugs.kde.org/show_bug.cgi?id=178061
Marcel Wiesweg marcel wiesweg gmx de changed: What |Removed |Added ---------------------------------------------------------------------------- Status|UNCONFIRMED |RESOLVED Resolution| |FIXED -- Configure bugmail: http://bugs.kde.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. _______________________________________________ Digikam-devel mailing list [hidden email] https://mail.kde.org/mailman/listinfo/digikam-devel |
In reply to this post by Simon Bühler
https://bugs.kde.org/show_bug.cgi?id=178061
Gilles Caulier <[hidden email]> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|0.10.0-svn |0.10.0 -- Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. _______________________________________________ Digikam-devel mailing list [hidden email] https://mail.kde.org/mailman/listinfo/digikam-devel |
In reply to this post by Simon Bühler
https://bugs.kde.org/show_bug.cgi?id=178061
[hidden email] changed: What |Removed |Added ---------------------------------------------------------------------------- Component|general |Portability -- You are receiving this mail because: You are the assignee for the bug. |
In reply to this post by Simon Bühler
https://bugs.kde.org/show_bug.cgi?id=178061
[hidden email] changed: What |Removed |Added ---------------------------------------------------------------------------- Component|Portability |Bundle-Tarball -- You are receiving this mail because: You are the assignee for the bug. |
Free forum by Nabble | Edit this page |