[Bug 177329] New: quick sarch is case sensitive [regression]

http://bugs.kde.org/show_bug.cgi?id=177329

           Summary: quick sarch is case sensitive [regression]
           Product: digikam
           Version: unspecified
          Platform: Compiled Sources
        OS/Version: Linux
            Status: NEW
          Severity: normal
          Priority: NOR
         Component: Albums GUI
        AssignedTo: [hidden email]
        ReportedBy: [hidden email]


Version:            (using Devel)
Compiler:          gcc4.3.2
OS:                Linux
Installed from:    Compiled sources

In 0.9.x quick search was case insensitive and it was Good(tm).

Also other quick searches are case insensitive (in 0.10).

When not introducing configurability of this option as discussed in But 162206
case insensitive is much, much better default (read: as not configurable).


--
Configure bugmail: http://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

http://bugs.kde.org/show_bug.cgi?id=177329


Mikolaj Machowski mikmach wp pl changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Version|unspecified                 |0.10.0-beta7




--
Configure bugmail: http://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

http://bugs.kde.org/show_bug.cgi?id=177329


Gilles Caulier caulier gilles gmail com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|quick sarch is case         |quick search is case
                   |sensitive [regression]      |sensitive [regression]




--
Configure bugmail: http://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

http://bugs.kde.org/show_bug.cgi?id=177329


Gilles Caulier caulier gilles gmail com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|                            |FIXED




--- Comment #1 from Gilles Caulier <caulier gilles gmail com>  2008-12-22 23:03:57 ---
SVN commit 900460 by cgilles:

digiKam from trunk : add new option to match search text bar everywhere in
sensitive case or not.
The option is in context menu of search text bar where user enter string to
match.
By default, the option is dsable.
BUG: 162206
BUG: 177329


 M  +7 -8      digikam/albumfolderview.cpp  
 M  +2 -1      digikam/albumfolderview.h  
 M  +4 -5      digikam/albumiconviewfilter.cpp  
 M  +2 -1      digikam/albumiconviewfilter.h  
 M  +10 -10    digikam/albumlister.cpp  
 M  +2 -1      digikam/albumlister.h  
 M  +7 -9      digikam/albumselectdialog.cpp  
 M  +5 -1      digikam/albumselectdialog.h  
 M  +15 -16    digikam/digikamview.cpp  
 M  +1 -0      digikam/digikamview.h  
 M  +7 -8      digikam/tagfilterview.cpp  
 M  +2 -1      digikam/tagfilterview.h  
 M  +7 -8      digikam/tagfolderview.cpp  
 M  +2 -1      digikam/tagfolderview.h  
 M  +5 -9      libs/dialogs/rawcameradlg.cpp  
 M  +2 -1      libs/dialogs/rawcameradlg.h  
 M  +13 -14    libs/imageproperties/imagedescedittab.cpp  
 M  +3 -2      libs/imageproperties/imagedescedittab.h  
 M  +33 -2     libs/widgets/common/searchtextbar.cpp  
 M  +28 -1     libs/widgets/common/searchtextbar.h  
 M  +4 -4      libs/widgets/metadata/metadatalistview.cpp  
 M  +2 -1      libs/widgets/metadata/metadatalistview.h  
 M  +3 -3      libs/widgets/metadata/metadatawidget.cpp  
 M  +3 -1      project/project.kdevelop  
 M  +3 -4      utilities/fuzzysearch/fuzzysearchfolderview.cpp  
 M  +2 -1      utilities/fuzzysearch/fuzzysearchfolderview.h  
 M  +2 -2      utilities/fuzzysearch/fuzzysearchview.cpp  
 M  +4 -5      utilities/gpssearch/gpssearchfolderview.cpp  
 M  +2 -1      utilities/gpssearch/gpssearchfolderview.h  
 M  +2 -2      utilities/gpssearch/gpssearchview.cpp  
 M  +21 -25    utilities/kipiiface/kipiimagecollectionselector.cpp  
 M  +4 -3      utilities/kipiiface/kipiimagecollectionselector.h  
 M  +9 -11     utilities/kipiiface/kipiuploadwidget.cpp  
 M  +2 -1      utilities/kipiiface/kipiuploadwidget.h  
 M  +3 -4      utilities/searchwindow/searchfolderview.cpp  
 M  +2 -1      utilities/searchwindow/searchfolderview.h  
 M  +5 -6      utilities/setup/cameraselection.cpp  
 M  +5 -1      utilities/setup/cameraselection.h  
 M  +3 -4      utilities/timeline/timelinefolderview.cpp  
 M  +2 -1      utilities/timeline/timelinefolderview.h  
 M  +2 -2      utilities/timeline/timelineview.cpp  


WebSVN link: http://websvn.kde.org/?view=rev&revision=900460


--
Configure bugmail: http://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

http://bugs.kde.org/show_bug.cgi?id=177329





--- Comment #2 from Gilles Caulier <caulier gilles gmail com>  2008-12-22 23:08:06 ---
Mik,

Look my commit #900460 !

Please test all parts where search text bar exist and report if you see any
regression.

Thanks in advance

Gilles Caulier


--
Configure bugmail: http://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

http://bugs.kde.org/show_bug.cgi?id=177329





--- Comment #3 from Mikolaj Machowski <mikmach wp pl>  2008-12-23 18:46:00 ---
Works perfectly for Album list and Main window but quick search field in
Caption/Tags doesn't follow policy - filtering is always case insensitive.


--
Configure bugmail: http://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

http://bugs.kde.org/show_bug.cgi?id=177329





--- Comment #4 from Gilles Caulier <caulier gilles gmail com>  2008-12-23 19:31:41 ---
Mik,

Fixed with commit #900825.

Please check too these search tools:

- Metadata side bar.
- all folder view (Tags filter, Searches, Tags, TimeLine, Fuzzy Searches, Map
Searches)
- Camera settings page.

Thanks in advance

Gilles


--
Configure bugmail: http://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

http://bugs.kde.org/show_bug.cgi?id=177329


Mikolaj Machowski mikmach wp pl changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |REOPENED
         Resolution|FIXED                       |




--- Comment #5 from Mikolaj Machowski <mikmach wp pl>  2008-12-23 21:43:41 ---
This time proper testing:

Due to number of issues here I will reopen bug.

Everywhere: default completion should be "Dropdown list", it is default for
whole KDE and it should be default also for digiKam. Also "Automatic" has side
effect - current list is filtered against current guess. Example: enter m,
automatic completion is filled with Michelle and only those item is shown
although there are other elements which match this letter (Amy, Kamila, etc.)

Everywhere: "Dropdown list" is filled only according to expression "m*" while
items in list are filtered to "*m*". Cognitive distruption.

IMO unless two things are solved completion in quick filter fields should be
disabled. And frankly - I don't think it is worth of fixing. Quick filter is
only to narrow number of possible choices not to get precise one element.

Albums: when option is case insensitive after some letters I get no matches
although I know those elements are there, after inserting second letter
filtering is done right (letters k, g, s, i, e but not p, r). "No matches"
means tree is folded to root album - *real* no matches means everyghing
vanishes

This issue occurs only in this panel.

Timeline: Stranely looking thing with Last Search. This item has double name
Last Search and Current Search and although only one name is visible it is
filtered by both names. The best solution would be exclude this from all
filtering acitivities (item should be always visible, maybe different font to
differentiate from other searches).

Searches: This time Last Search/Current Search is to filter known *only* as
Current Search even when Last Search is visible.

Geo: cannot test, no sufficient

Metadata (right panel): This one is weird.

Case sensitive - insert "caption" shows "Caption", insert "Caption" shows
nothing
Case insensitive - works OK

Note: when filtering out whole sections (like Image Information), header of
this section should aslo vanish.


--
Configure bugmail: http://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

http://bugs.kde.org/show_bug.cgi?id=177329





--- Comment #6 from Gilles Caulier <caulier gilles gmail com>  2008-12-23 22:20:38 ---
>Everywhere: default completion should be "Dropdown list"

This can be configured from contextual menu.

>Everywhere: "Dropdown list" is filled only according to expression "m*" while >items in list are filtered to "*m*"

Here we manage nothing. this code come from KLineEdit code from KDElibs.

For all others points, i need to check indeep in code.

Gilles


--
Configure bugmail: http://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

http://bugs.kde.org/show_bug.cgi?id=177329





--- Comment #7 from Gilles Caulier <caulier gilles gmail com>  2008-12-23 22:29:12 ---
>Metadata (right panel): This one is weird.

Fixed with commit #900883.

Gilles


--
Configure bugmail: http://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

http://bugs.kde.org/show_bug.cgi?id=177329





--- Comment #8 from Gilles Caulier <caulier gilles gmail com>  2008-12-23 22:37:25 ---
Andi,

With this comment :

>Albums: when option is case insensitive after some letters I get no matches >although I know those elements are there, after inserting second letter >filtering is done right (letters k, g, s, i, e but not p, r). "No matches" means >tree is folded to root album - *real* no matches means everyghing vanishes This >issue occurs only in this panel.

Something is wrong with recursive tree parsing and search filter ? you have
patched something about if i remember...

Gilles


--
Configure bugmail: http://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

http://bugs.kde.org/show_bug.cgi?id=177329





--- Comment #9 from Andi Clemens <andi clemens gmx net>  2008-12-24 01:33:40 ---
I didn't change the parsing, only the collapsing of the tree. I don't really
understand the problem either, for me filtering works perfectly fine, in case
sensitive and insensitive mode.

Mik, can you describe this a little bit more?

Note: I'll be at my relatives for 3 days now, I will have my notebook with me
but I don't know if I can / will be online.

Andi


--
Configure bugmail: http://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

http://bugs.kde.org/show_bug.cgi?id=177329





--- Comment #10 from Mikolaj Machowski <mikmach wp pl>  2008-12-26 12:13:00 ---
#9, Andi

I have albums tree (examples, not everything):

/home/mikolaj/Imgs
- 2008-11-20
- 2008-12-22
- ekslibrisy
- grafika
- inne
- KrCoSt
- Kreta 2008
- rysunki

I set albums quick search for case insensitive and insert k (or K, doesn't
matter)

Whole tree collapses to

/home/mikolaj/Images

Background of quick search is green so digiKam *knows* there are matches, just
doesn't display them. If I add second k everything vanishes and background of
quick search field becomes red - proper reaction. When I add r (result kr) I
get correct result (the same for all other existing combinations).

/home/mikolaj/Imgs
- KrCoSt
- Kreta 2008

More systematic approach:

Letters which are working: b, c, d, f, n, p, q, r, t, u, v, w, x, y, z
Letters which are not: a, e, g, h, i, j, k, l, m, o, s


--
Configure bugmail: http://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

http://bugs.kde.org/show_bug.cgi?id=177329





--- Comment #11 from Andi Clemens <andi clemens gmx net>  2008-12-30 14:42:18 ---
What completion mode are you using? I can not confirm this at the moment, here
it filters fine.
I'll go through all letters now (dropdown list mode, case insensitive) to see
if I can reproduce the issue on my machine.

Andi


--
Configure bugmail: http://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

http://bugs.kde.org/show_bug.cgi?id=177329





--- Comment #12 from Mikolaj Machowski <mikmach wp pl>  2008-12-30 17:40:23 ---
Due to problems I reported earlier I turned off completion completely.


--
Configure bugmail: http://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

http://bugs.kde.org/show_bug.cgi?id=177329





--- Comment #13 from Andi Clemens <andi clemens gmx net>  2008-12-30 18:29:08 ---
SVN commit 903498 by aclemens:

fix quick search: always expand albumroot folders, otherwise not all
search results are visible. Also make sure to avoid root and albumroot
folder items when looking for parent matches.

CCBUG:177329

 M  +11 -7     albumfolderview.cpp  


WebSVN link: http://websvn.kde.org/?view=rev&revision=903498


--
Configure bugmail: http://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

http://bugs.kde.org/show_bug.cgi?id=177329





--- Comment #14 from Andi Clemens <andi clemens gmx net>  2008-12-30 18:31:41 ---
Mik,

quick search should be fixed now. Can you confirm this?
The problem occured when the letters where in the albumroot name. With too few
matching characters, the albumroot folder was just collapsed.

Andi


--
Configure bugmail: http://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

http://bugs.kde.org/show_bug.cgi?id=177329





--- Comment #15 from Mikolaj Machowski <mikmach wp pl>  2008-12-31 20:14:55 ---
Good news for Andi: yes, this issue was fixed.


--
Configure bugmail: http://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

http://bugs.kde.org/show_bug.cgi?id=177329





--- Comment #16 from Andi Clemens <andi clemens gmx net>  2009-01-03 11:39:23 ---
Is there anything else left to fix?

Andi


--
Configure bugmail: http://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

http://bugs.kde.org/show_bug.cgi?id=177329





--- Comment #17 from Mikolaj Machowski <mikmach wp pl>  2009-01-03 18:37:16 ---
This one is left:

Searches: This time Last Search/Current Search is to filter known *only* as
Current Search even when Last Search is visible.


--
Configure bugmail: http://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel