[Bug 175630] New: setting panels of imageeditor effects should be fully visible

[Simon Bühler]

http://bugs.kde.org/show_bug.cgi?id=175630

           Summary: setting panels of imageeditor effects should be fully
                    visible
           Product: digikam
           Version: unspecified
          Platform: unspecified
        OS/Version: Linux
            Status: UNCONFIRMED
          Severity: normal
          Priority: NOR
         Component: general
        AssignedTo: [hidden email]
        ReportedBy: [hidden email]


Version:           0.10.0-beta6 (using 4.1.80 (KDE 4.1.80 (KDE 4.2 Beta1)),
Gentoo)
Compiler:          x86_64-pc-linux-gnu-gcc
OS:                Linux (x86_64) release 2.6.26-tuxonice

as each property pages of the effects/filters in the image editor window have a
different width, one always has to manually adjust the divider to see
everything of the GUI elements, everytime a effect/filter is opened.

The minimal needed width for each panel should be automagically used, as it's
quite annoying when the controls are hidden


--
Configure bugmail: http://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

http://bugs.kde.org/show_bug.cgi?id=175630


Gilles Caulier caulier gilles gmail com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
          Component|general                     |Image Editor




--
Configure bugmail: http://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

http://bugs.kde.org/show_bug.cgi?id=175630


Andi Clemens andi clemens gmx net changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Version|unspecified                 |0.10.0-beta6




--
Configure bugmail: http://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

http://bugs.kde.org/show_bug.cgi?id=175630


Mikolaj Machowski mikmach wp pl changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |NEW
     Ever Confirmed|0                           |1




--- Comment #1 from Mikolaj Machowski <mikmach wp pl>  2008-12-08 16:47:45 ---
Confirming for 0.10b7svn and 0.9.5svn.

It is really awkward. In the first moment I always think something is wrong
because some info isn't visible.

Several possible solution:
1) redesing settings to accomodate in default minimum width of right panel
2) increase minimum width of right panel to accomodate all settings panels
3) automatically adjust width of right panel to make everything visible


--
Configure bugmail: http://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

http://bugs.kde.org/show_bug.cgi?id=175630





--- Comment #2 from Gilles Caulier <caulier gilles gmail com>  2008-12-08 16:54:14 ---
Marcel,

This problem come from of QScrollView (QScrollArea) used to display sidebar
contents to be compatible with small screen size as with EEEPC.

The problem is how to get the right widget size hosted by scroll view. It's
never right here...

Andi,

We need to optimize also the design on the bottom of settings view. Perhaps
some buttons text can be removed to optimize space, and let's only icons alone
on buttons...

Gilles Caulier


--
Configure bugmail: http://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Simon Bühler]

http://bugs.kde.org/show_bug.cgi?id=175630





--- Comment #3 from Simon Bühler <simon aktionspotential de>  2008-12-08 17:03:59 ---
hi,

imho "small screen size as with EEEP" are definetely not the main target a
image managing software should be optimized for.

i vote for option 3) outlined in comment #1; a option could switch if the
scrollbars should be used or not (small size displays)


--
Configure bugmail: http://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

http://bugs.kde.org/show_bug.cgi?id=175630





--- Comment #4 from Gilles Caulier <caulier gilles gmail com>  2008-12-08 18:33:25 ---
This is not only for EEEPC. Problem appears with 19/9 laptop screen (like mine)
where digiKam window become behing KDE task bar.

Gilles Caulier


--
Configure bugmail: http://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

http://bugs.kde.org/show_bug.cgi?id=175630





--- Comment #5 from Andi Clemens <andi clemens gmx net>  2008-12-08 18:38:29 ---
We should change the hardware specs: Linux 2.6.xx + widescreen beamer :-)


--
Configure bugmail: http://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

http://bugs.kde.org/show_bug.cgi?id=175630





--- Comment #6 from Mikolaj Machowski <mikmach wp pl>  2008-12-08 20:30:14 ---
About design - quick review of plugins:
Method: resized 0.9.5svn IE window to 800x600 (including window decoration);
set right panel width to minimum size where Caption/Tags panel fit (the widest
default panel - small surprise, always thought Colors is due to histogram).

Looks like *all* plugins are resizing dialog to 830-840px PLUS they don't allow
to resize window below this width - so for practical reasons test is for 840px
width - which is already 40px too much.

Notes below are not bugs per se but things where some pixels of width can be
gained, "OK" means only plugin fits withou horizontal scrollbar:

Auto-Correction: OK
B/C/G: OK
H/S/L: OK
Color correction: value fields are too wide
B&W: just few pixels, value field too wide? in this width mess with buttons
Color management: OK
Levels: value fields too wide? broken vertical scrolling - one histogram stays
in place while the rest is moving
Color Effects: OK
White Balance: sliders could be more compressed - due to precise nature of
corrections they are already almost unusable - get rid of them?
Curves: OK
Channel mixer: OK
Sharpen: OK
Blur: OK
Red eye: OK
Inpainting: sliders, value fields too wide
Noise reducton: sliders, value fields too wide
Hot pixels: OK
Lens distortion: sliders, value fields too wide
Restoration: sliders, value fields too wide
Vignetting: OK - due to <br> between label and slider - solution everywhere?
Aspect ratio crop: too much everything
Shear: sliders, fields, even <br> doesn't help
Free rotation: as in Shear
Perspective: OK
Texture: OK
Border: OK
Text: narrower font Size column and text alignment buttons
Template superimpose: not OK, no idea how help
Raindrops, Infra red, Oil paint, Emboss, Film grain, Blur effects, Charcoal: OK
Distorition: sliders, value fields too wide

General notes: a) in many UIs width was broken due to adding of reset button
without adjusting the rest of the dialog

HTH


--
Configure bugmail: http://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Geoff King-4]

http://bugs.kde.org/show_bug.cgi?id=175630


Geoff King gsking1 gmail com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[hidden email]




--- Comment #7 from Geoff King <gsking1 gmail com>  2008-12-20 17:02:28 ---
I didn't see this comment before.  Looks like what I just reported here:
http://bugs.kde.org/show_bug.cgi?id=178291


--
Configure bugmail: http://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Geoff King-4]

http://bugs.kde.org/show_bug.cgi?id=175630





--- Comment #8 from Geoff King <gsking1 gmail com>  2008-12-20 17:05:06 ---
*** Bug 178291 has been marked as a duplicate of this bug. ***


--
Configure bugmail: http://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

http://bugs.kde.org/show_bug.cgi?id=175630


Gilles Caulier caulier gilles gmail com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[hidden email]




--- Comment #9 from Gilles Caulier <caulier gilles gmail com>  2008-12-22 09:45:22 ---
Marcel,

Are you see my comment #2 ?

Gilles


--
Configure bugmail: http://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Marcel Wiesweg]

http://bugs.kde.org/show_bug.cgi?id=175630





--- Comment #10 from Marcel Wiesweg <marcel wiesweg gmx de>  2008-12-22 21:58:38 ---
SVN commit 900430 by mwiesweg:

Reimplement minimumSizeHint of the scroll area.
The minimumSizeHint of a QScrollArea is usually independent of the widget
contained,
but here we want to have a certain amount of minimum horizontal space.
Limit minimum size to 40% of desktop width.

CCBUG: 175630

 M  +23 -9     editortoolsettings.cpp  
 M  +2 -0      editortoolsettings.h  


WebSVN link: http://websvn.kde.org/?view=rev&revision=900430


--
Configure bugmail: http://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Marcel Wiesweg]

http://bugs.kde.org/show_bug.cgi?id=175630





--- Comment #11 from Marcel Wiesweg <marcel wiesweg gmx de>  2008-12-22 22:02:43 ---
With this commit the sidebar is automatically extended to the needed size in
the horizontal direction, vertical is untouched.
We can limit the required space according to desktop size (currently it's 40%
of desktop width).
It also seems to behave quite well when resizing the window.
Please test, if you find no problems we can mark this as fixed.


--
Configure bugmail: http://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

http://bugs.kde.org/show_bug.cgi?id=175630





--- Comment #12 from Gilles Caulier <caulier gilles gmail com>  2008-12-25 14:34:07 ---
Marcel,

Your patch work fine here. Great...

Note: your patch need to be backported to KDE3 branch because the same
implementation is used with scroll view container in editor tool settings page.

Gilles Caulier


--
Configure bugmail: http://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Geoff King-4]

http://bugs.kde.org/show_bug.cgi?id=175630





--- Comment #13 from Geoff King <gsking1 gmail com>  2008-12-26 03:35:32 ---
Looks good to me.  Problem solved.


--
Configure bugmail: http://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Marcel Wiesweg]

http://bugs.kde.org/show_bug.cgi?id=175630


Marcel Wiesweg marcel wiesweg gmx de changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|                            |FIXED




--
Configure bugmail: http://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Marcel Wiesweg]

http://bugs.kde.org/show_bug.cgi?id=175630


Marcel Wiesweg marcel wiesweg gmx de changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[hidden email]




--- Comment #14 from Marcel Wiesweg <marcel wiesweg gmx de>  2008-12-29 22:38:55 ---
*** Bug 178190 has been marked as a duplicate of this bug. ***


--
Configure bugmail: http://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

http://bugs.kde.org/show_bug.cgi?id=175630


Gilles Caulier caulier gilles gmail com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[hidden email]




--- Comment #15 from Gilles Caulier <caulier gilles gmail com>  2009-01-01 14:31:23 ---
Marcel,

Are you see my comment #12 ? KDE3 still not patched yet ?

Gilles Caulier


--
Configure bugmail: http://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Marcel Wiesweg]

http://bugs.kde.org/show_bug.cgi?id=175630





--- Comment #16 from Marcel Wiesweg <marcel wiesweg gmx de>  2009-01-01 18:09:15 ---
SVN commit 904225 by mwiesweg:

Backport commit 900430 to KDE3:

Reimplement minimumSizeHint of the scroll area.
The minimumSizeHint of a QScrollView is usually independent of the widget
contained, but here we want to have a certain amount of minimum horizontal
space.
Limit minimum size to 40% of desktop width.

CCBUG: 175630


 M  +22 -7     editortoolsettings.cpp  
 M  +2 -0      editortoolsettings.h  


WebSVN link: http://websvn.kde.org/?view=rev&revision=904225


--
Configure bugmail: http://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel