[Bug 172912] New: "Slide" becomes "Slideshow" text on button in Main window. One-line change

http://bugs.kde.org/show_bug.cgi?id=172912

           Summary: "Slide" becomes "Slideshow" text on button in Main
                    window. One-line change
           Product: digikam
           Version: unspecified
          Platform: Compiled Sources
        OS/Version: unspecified
            Status: UNCONFIRMED
          Severity: wishlist
          Priority: NOR
         Component: general
        AssignedTo: [hidden email]
        ReportedBy: [hidden email]


Version:            (using Devel)
Installed from:    Compiled sources

My patch cotains other unmerged changes, so I'll paste in the tiny relevant
section. It's just the addition of 4 letters to a button text.


@@ -877,7 +877,7 @@                                                            

     // -----------------------------------------------------------            

-    d->slideShowAction = new KActionMenu(KIcon("view-presentation"),
i18n("Slide"), this);                    
+    d->slideShowAction = new KActionMenu(KIcon("view-presentation"),
i18n("Slideshow"), this);                
     d->slideShowAction->setDelayed(false);                                    
     actionCollection()->addAction("slideshow", d->slideShowAction);


--
Configure bugmail: http://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

http://bugs.kde.org/show_bug.cgi?id=172912





--- Comment #1 from Brendan Barry <mailinglist endosquid com>  2008-10-16 04:16:30 ---
File changed is digikam/digikamapp.cpp


--
Configure bugmail: http://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

http://bugs.kde.org/show_bug.cgi?id=172912


Gilles Caulier caulier gilles gmail com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
          Component|general                     |SlideShow




--
Configure bugmail: http://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

http://bugs.kde.org/show_bug.cgi?id=172912


Andi Clemens andi clemens gmx net changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |RESOLVED
         Resolution|                            |FIXED




--- Comment #2 from Andi Clemens <andi clemens gmx net>  2008-10-16 10:25:53 ---
Right, I think this is better. Never seen this before since I use only icons in
the toolbar without text.
I will commit this immediately.

Andi


--
Configure bugmail: http://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

http://bugs.kde.org/show_bug.cgi?id=172912





--- Comment #3 from Andi Clemens <andi clemens gmx net>  2008-10-16 10:30:47 ---
SVN commit 871988 by aclemens:

use 'Slideshow' for the tool-button's text, it is more clear for users.

BUG:172912

 M  +2 -1      NEWS  
 M  +1 -1      digikam/digikamapp.cpp  


WebSVN link: http://websvn.kde.org/?view=rev&revision=871988


--
Configure bugmail: http://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

http://bugs.kde.org/show_bug.cgi?id=172912





--- Comment #4 from Gilles Caulier <caulier gilles gmail com>  2008-10-16 11:10:21 ---
NOTE: i have set "Slide" in the pass to reduce text size under icons (default
mode in KDE4), else tool bar become larger.

The same issue is done in other tool bar button...

Gilles Caulier


--
Configure bugmail: http://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

http://bugs.kde.org/show_bug.cgi?id=172912





--- Comment #5 from Andi Clemens <andi clemens gmx net>  2008-10-16 11:25:53 ---
Oh so this change was wrong? But "Full Screen" button isn't smaller, too...


Andi


--
Configure bugmail: http://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

http://bugs.kde.org/show_bug.cgi?id=172912


Gilles Caulier caulier gilles gmail com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[hidden email]




--- Comment #6 from Gilles Caulier <caulier gilles gmail com>  2008-10-16 11:31:10 ---
Andi,

If "SlideShow" is better than "Slide", it's fine for me... I'm not a good
English speaker (:=)))

I justify the reason why "Slide" words is used here.

And yes "Full Screen" is long... But i have already fixed that: before this
string been "Full Screen Mode"...

Gilles


--
Configure bugmail: http://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

http://bugs.kde.org/show_bug.cgi?id=172912





--- Comment #7 from Andi Clemens <andi clemens gmx net>  2008-10-16 11:47:06 ---
:-)
Yes Full Screen Mode is long.

I'm done with Brendan's patches so far, the welcome page is something I'm not
happy with now (due to the use of nested lists), but we can decide what to do.
I'll create a patch with hunks I'm unsure about and post it on ML.

Andi


--
Configure bugmail: http://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel