[Bug 167778] New: Assigning ratings in image editor via shortcuts or toolbar not working

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
         
http://bugs.kde.org/show_bug.cgi?id=167778         
           Summary: Assigning ratings in image editor via shortcuts or
                    toolbar not working
           Product: digikam
           Version: unspecified
          Platform: unspecified
        OS/Version: Linux
            Status: UNCONFIRMED
          Severity: normal
          Priority: NOR
         Component: general
        AssignedTo: digikam-devel kde org
        ReportedBy: gandalf.lechner esi ac at


Version:           0.10.0-beta2 (rev.: 839714) (using 4.1.00 (KDE 4.1.0), Kubuntu packages)
Compiler:          gcc
OS:                Linux (x86_64) release 2.6.24-17-generic

In the image editor, one can assign ratings

a) from the context menu given by right click on the pic
b) with the shortcuts Ctrl+X
c) by putting a corresponding entry in the toolbar and clicking it

Here a) works, but b) and c) don't.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
         
http://bugs.kde.org/show_bug.cgi?id=167778         




------- Additional Comments From gandalf.lechner esi ac at  2008-07-30 21:11 -------
One more thing: In the digikam main window, all three methods work.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
         
http://bugs.kde.org/show_bug.cgi?id=167778         
andi.clemens gmx net changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |NEW
          Component|general                     |Image Editor
      everconfirmed|0                           |1
            Version|unspecified                 |0.10.0-svn
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
         
http://bugs.kde.org/show_bug.cgi?id=167778         




------- Additional Comments From andi.clemens gmx net  2008-07-30 21:21 -------
Can confirm this, I will have a look...
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
         
http://bugs.kde.org/show_bug.cgi?id=167778         




------- Additional Comments From gandalf.lechner esi ac at  2008-07-30 21:38 -------
same bug in the 0.9 version
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
         
http://bugs.kde.org/show_bug.cgi?id=167778         




------- Additional Comments From andi.clemens gmx net  2008-07-30 22:14 -------
The rating is assigned, but there are some signals missing. Open up the right
sidebar Caption/Tags, you will see that they are assigned.
I'll fix it...

Andi
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
         
http://bugs.kde.org/show_bug.cgi?id=167778         
andi.clemens gmx net changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Version|0.10.0-svn                  |0.10.0-beta2
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
         
http://bugs.kde.org/show_bug.cgi?id=167778         




------- Additional Comments From andi.clemens gmx net  2008-07-30 22:52 -------
Created an attachment (id=26510)
 --> (http://bugs.kde.org/attachment.cgi?id=26510&action=view)
patch #1

fixes the assigning of ratings in editorwindow...
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
         
http://bugs.kde.org/show_bug.cgi?id=167778         




------- Additional Comments From caulier.gilles gmail com  2008-08-01 15:28 -------
Andi,

Patch is fine for me.

Gilles
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
         
http://bugs.kde.org/show_bug.cgi?id=167778         




------- Additional Comments From andi.clemens gmx net  2008-08-01 20:41 -------
Gilles,

maybe we should factorize this too. We call those 6 functions added in the patch (slotAssignRatingNoStar()...) in three places I guess, in main window, lighttable and now image editor. But as a start I will commit this to fix the issue...
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
         
http://bugs.kde.org/show_bug.cgi?id=167778         




------- Additional Comments From andi.clemens gmx net  2008-08-01 20:48 -------
SVN commit 840766 by aclemens:

When using shortcuts to assign ratings in image editor, apply them immediately.

CCBUGS:126871

 M  +36 -6     imagewindow.cpp  
 M  +7 -0      imagewindow.h  


WebSVN link: http://websvn.kde.org/?view=rev&revision=840766
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
         
http://bugs.kde.org/show_bug.cgi?id=167778         




------- Additional Comments From andi.clemens gmx net  2008-08-01 20:49 -------
SVN commit 840766 by aclemens:

When using shortcuts to assign ratings in image editor, apply them immediately.

CCBUGS:167778

 M  +36 -6     imagewindow.cpp  
 M  +7 -0      imagewindow.h  


WebSVN link: http://websvn.kde.org/?view=rev&revision=840766
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
         
http://bugs.kde.org/show_bug.cgi?id=167778         
gandalf.lechner esi ac at changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|                            |WORKSFORME



------- Additional Comments From gandalf.lechner esi ac at  2008-08-01 21:39 -------
Works fine here, thanks
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
         
http://bugs.kde.org/show_bug.cgi?id=167778         




------- Additional Comments From andi.clemens gmx net  2008-08-01 22:16 -------
SVN commit 840783 by aclemens:

backport commit #840766 from KDE4

CCBUGS:167778

 M  +68 -38    imagewindow.cpp  
 M  +9 -2      imagewindow.h  


WebSVN link: http://websvn.kde.org/?view=rev&revision=840783
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel