[Bug 161369] New: Quick filter indicator lamp is not working properly in recursive image folder view mode

[Gilles Caulier-4]

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
         
http://bugs.kde.org/show_bug.cgi?id=161369         




------- Additional Comments From caulier.gilles gmail com  2008-05-21 15:01 -------
Andi, Julien,

I'm still not able to reproduce the crash here, using keyboard shortcuts...

Gilles
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
         
http://bugs.kde.org/show_bug.cgi?id=161369         




------- Additional Comments From andi.clemens gmx net  2008-05-21 15:05 -------
Hmm so its 2:1... we win!!! ;-)
I don't know why it is happening, but I tried it on a totally different computer now (my fileserver, where I installed KDE just for this test). It is a Debian system. Crash can be confirmed as well.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
         
http://bugs.kde.org/show_bug.cgi?id=161369         




------- Additional Comments From Julien narboux fr  2008-05-21 15:33 -------
Gilles,

Tell me if this helps.

Julien

Using host libthread_db library "/lib/tls/i686/cmov/libthread_db.so.1".
[Thread debugging using libthread_db enabled]
[New Thread -1250280832 (LWP 29304)]
[KCrash handler]
#6  0xb7c68cba in Digikam::IconItem::isSelected (this=0x2f0032)
    at iconitem.cpp:126
#7  0xb7c12f80 in Digikam::AlbumIconView::slotAssignRating (this=0x81324a0,
    rating=1) at albumiconview.cpp:2370
#8  0xb7c52472 in Digikam::DigikamView::slotAssignRatingOneStar (
    this=0x812e388) at digikamview.cpp:1423
#9  0xb7c58be7 in Digikam::DigikamView::qt_invoke (this=0x812e388, _id=96,
    _o=0xbfceb3ac) at digikamview.moc:535
#10 0xb6104893 in QObject::activate_signal () from /usr/lib/libqt-mt.so.3
#11 0xb6105338 in QObject::activate_signal () from /usr/lib/libqt-mt.so.3
#12 0xb6a6f3d9 in KAction::activated () from /usr/lib/libkdeui.so.4
#13 0xb6ab1ca2 in KAction::slotActivated () from /usr/lib/libkdeui.so.4
#14 0xb6bafb2f in KAction::qt_invoke () from /usr/lib/libkdeui.so.4
#15 0xb6104893 in QObject::activate_signal () from /usr/lib/libqt-mt.so.3
#16 0xb6105338 in QObject::activate_signal () from /usr/lib/libqt-mt.so.3
#17 0xb6793109 in KAccelPrivate::menuItemActivated ()
   from /usr/lib/libkdecore.so.4
#18 0xb67e0b17 in KAccelPrivate::emitActivatedSignal ()
   from /usr/lib/libkdecore.so.4
#19 0xb684b17e in KAccelPrivate::eventFilter () from /usr/lib/libkdecore.so.4
#20 0xb6103e40 in QObject::activate_filters () from /usr/lib/libqt-mt.so.3
#21 0xb6103ebe in QObject::event () from /usr/lib/libqt-mt.so.3
#22 0xb613b5b3 in QWidget::event () from /usr/lib/libqt-mt.so.3
#23 0xb6211c5a in QMainWindow::event () from /usr/lib/libqt-mt.so.3
#24 0xb609baf0 in QApplication::internalNotify () from /usr/lib/libqt-mt.so.3
#25 0xb609dac0 in QApplication::notify () from /usr/lib/libqt-mt.so.3
#26 0xb687ccd2 in KApplication::notify () from /usr/lib/libkdecore.so.4
#27 0xb67eeaf7 in KAccelEventHandler::x11Event ()
   from /usr/lib/libkdecore.so.4
#28 0xb687b103 in KApplication::x11EventFilter ()
   from /usr/lib/libkdecore.so.4
#29 0xb601a153 in ?? () from /usr/lib/libqt-mt.so.3
#30 0xbfcebee0 in ?? ()
#31 0xbfcebca8 in ?? ()
#32 0x00000001 in ?? ()
#33 0xb65cc8d0 in ?? () from /usr/lib/libqt-mt.so.3
#34 0xbfcebca8 in ?? ()
#35 0xb65cc8d0 in ?? () from /usr/lib/libqt-mt.so.3
#36 0xbfcebb48 in ?? ()
#37 0xb602a8e2 in QApplication::x11ProcessEvent () from /usr/lib/libqt-mt.so.3
Backtrace stopped: frame did not save the PC
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
         
http://bugs.kde.org/show_bug.cgi?id=161369         




------- Additional Comments From andi.clemens gmx net  2008-05-21 15:36 -------
Well this is nearly the same backtrace I posted before... so we have the same issue going on here...
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
         
http://bugs.kde.org/show_bug.cgi?id=161369         




------- Additional Comments From andi.clemens gmx net  2008-05-25 15:33 -------
Just to be sure, here is a new backtrace (because of huge differences dicussed in IRC):

Using host libthread_db library "/lib/libthread_db.so.1".
[Thread debugging using libthread_db enabled]
[New Thread 0xb5a1f8e0 (LWP 25033)]
[KCrash handler]
#6  0xb7cb41b3 in Digikam::AlbumIconItem::imageInfo (this=0x89fb2d0)
    at albumiconitem.cpp:159
#7  0xb7cbcd55 in Digikam::AlbumIconView::slotAssignRating (this=0x8795020,
    rating=0) at albumiconview.cpp:2248
#8  0xb7cfbeb6 in Digikam::DigikamView::slotAssignRatingNoStar (this=0x8790fd0)
    at digikamview.cpp:1418
#9  0xb7d026b7 in Digikam::DigikamView::qt_invoke (this=0x8790fd0, _id=94,
    _o=0xbfc407f4) at digikamview.moc:534
#10 0xb628b558 in QObject::activate_signal () from /opt/qt/lib/libqt-mt.so.3
#11 0xb628d3e3 in QObject::activate_signal () from /opt/qt/lib/libqt-mt.so.3
#12 0xb6afafa4 in KAction::activated () from /opt/kde/lib/libkdeui.so.4
#13 0xb6b406eb in KAction::slotActivated () from /opt/kde/lib/libkdeui.so.4
#14 0xb6be4f05 in KAction::qt_invoke () from /opt/kde/lib/libkdeui.so.4
#15 0xb628b558 in QObject::activate_signal () from /opt/qt/lib/libqt-mt.so.3
#16 0xb628d3e3 in QObject::activate_signal () from /opt/qt/lib/libqt-mt.so.3
#17 0xb683bd6e in KAccelPrivate::menuItemActivated ()
   from /opt/kde/lib/libkdecore.so.4
#18 0xb685db99 in KAccelPrivate::emitActivatedSignal ()
   from /opt/kde/lib/libkdecore.so.4
#19 0xb692f7c1 in KAccelPrivate::eventFilter ()
   from /opt/kde/lib/libkdecore.so.4
#20 0xb628b5fb in QObject::activate_filters () from /opt/qt/lib/libqt-mt.so.3
#21 0xb628b664 in QObject::event () from /opt/qt/lib/libqt-mt.so.3
#22 0xb62c1c4d in QWidget::event () from /opt/qt/lib/libqt-mt.so.3
#23 0xb6378273 in QMainWindow::event () from /opt/qt/lib/libqt-mt.so.3
#24 0xb622b7c3 in QApplication::internalNotify ()
   from /opt/qt/lib/libqt-mt.so.3
#25 0xb622d2df in QApplication::notify () from /opt/qt/lib/libqt-mt.so.3
#26 0xb6927154 in KApplication::notify () from /opt/kde/lib/libkdecore.so.4
#27 0xb68515fc in KAccelEventHandler::x11Event ()
   from /opt/kde/lib/libkdecore.so.4
#28 0xb692c54d in KApplication::x11EventFilter ()
   from /opt/kde/lib/libkdecore.so.4
#29 0xb61b7f5d in ?? () from /opt/qt/lib/libqt-mt.so.3
#30 0xbfc41194 in ?? ()
#31 0xbfc41088 in ?? ()
#32 0x00000001 in ?? ()
#33 0xb66d75a4 in ?? () from /opt/qt/lib/libqt-mt.so.3
#34 0xb66d75a4 in ?? () from /opt/qt/lib/libqt-mt.so.3
#35 0x00000013 in ?? ()
#36 0xbfc40f38 in ?? ()
#37 0xb61c62dc in QApplication::x11ProcessEvent ()
   from /opt/qt/lib/libqt-mt.so.3
Backtrace stopped: frame did not save the PC
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
         
http://bugs.kde.org/show_bug.cgi?id=161369         
andi.clemens gmx net changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #24861|0                           |1
        is obsolete|                            |



------- Additional Comments From caulier.gilles gmail com  2008-05-25 15:49 -------
SVN commit 812423 by cgilles:

try to fix crash with rating keyboard shortcuts.
CCBUGS: 161369


 M  +13 -10    albumiconview.cpp  


WebSVN link: http://websvn.kde.org/?view=rev&revision=812423


------- Additional Comments From andi.clemens gmx net  2008-05-25 15:49 -------
Created an attachment (id=24931)
 --> (http://bugs.kde.org/attachment.cgi?id=24931&action=view)
after applying the patch
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
         
http://bugs.kde.org/show_bug.cgi?id=161369         




------- Additional Comments From caulier.gilles gmail com  2008-05-25 15:49 -------
SVN commit 812423 by cgilles:

try to fix crash with rating keyboard shortcuts.
CCBUGS: 161369


 M  +13 -10    albumiconview.cpp  


WebSVN link: http://websvn.kde.org/?view=rev&revision=812423
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
         
http://bugs.kde.org/show_bug.cgi?id=161369         
andi.clemens gmx net changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #24931|0                           |1
        is obsolete|                            |



------- Additional Comments From andi.clemens gmx net  2008-05-25 15:59 -------
Created an attachment (id=24932)
 --> (http://bugs.kde.org/attachment.cgi?id=24932&action=view)
backtrace after applying SVN changes
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
         
http://bugs.kde.org/show_bug.cgi?id=161369         
caulier.gilles gmail com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |marcel.wiesweg gmx de



------- Additional Comments From caulier.gilles gmail com  2008-05-25 16:07 -------
==> Marcel,

What do you think about the backtrace reproted by Andy. It's sound like a race condition. Or...

...something change iconviewitem instance in memory (corruption) ?

Can you reproduce the crash ? (me i cannot). Look #23 for details.

==> Mik,

Are you able to reproduce the crash on your computer ?

Gilles
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
         
http://bugs.kde.org/show_bug.cgi?id=161369         




------- Additional Comments From andi.clemens gmx net  2008-05-25 16:13 -------
Created an attachment (id=24933)
 --> (http://bugs.kde.org/attachment.cgi?id=24933&action=view)
valgrind output (including normal debugging output from digikam)
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
         
http://bugs.kde.org/show_bug.cgi?id=161369         




------- Additional Comments From andi.clemens gmx net  2008-05-25 16:38 -------
Some notes concerning the crashing of digikam while rating images using a quickfilter:

When using valgrind, the program is running very slow, so you can actually see exactly what is going on.
When using the context menu, the images are displayed in the quick filter until all rating is done, using the keyboard shortcut, they disappear while assigning the rating.
For example the first row in the iconview contains 4 images. The quickfilter is set and the rating will be removed with the keyboard shortcut. After a while, the first row disappears from the iconview, while the forth image (the last in the row) is still assigned with the new rating.
After that, digiKam crashes.
Using the context menu, everything is displayed until the rating is done completely.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
         
http://bugs.kde.org/show_bug.cgi?id=161369         




------- Additional Comments From andi.clemens gmx net  2008-05-25 16:46 -------
One little note, for those of you who are not able to reproduce the crash.

When you have enabled the following setting:
Settings->Metadata->Common Metadata Actions->save image rating as tags

the chance is that digiKam runs so slow that the error will not appear. So try to uncheck this option and redo the steps from #23
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
         
http://bugs.kde.org/show_bug.cgi?id=161369         




------- Additional Comments From caulier.gilles gmail com  2008-05-25 18:02 -------
SVN commit 812500 by cgilles:

second try to fix Rating assign from keybord shortcuts
CCBUGS: 161369


 M  +5 -3      albumiconview.cpp  


WebSVN link: http://websvn.kde.org/?view=rev&revision=812500
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
         
http://bugs.kde.org/show_bug.cgi?id=161369         




------- Additional Comments From caulier.gilles gmail com  2008-05-25 18:19 -------
SVN commit 812506 by cgilles:

same problem here. we need to block AlbumLister when Rating is assigned
CCBUGS: 161369


 M  +3 -0      imagedescedittab.cpp  


WebSVN link: http://websvn.kde.org/?view=rev&revision=812506
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
         
http://bugs.kde.org/show_bug.cgi?id=161369         




------- Additional Comments From caulier.gilles gmail com  2008-05-25 18:31 -------
SVN commit 812510 by cgilles:

Same problem here with tags assignement and tags filter about AlbumLister handling
CCBUGS: 161369


 M  +2 -0      digikam/albumiconview.cpp  
 M  +2 -0      digikam/tagfilterview.cpp  
 M  +4 -1      digikam/tagfolderview.cpp  
 M  +3 -0      libs/imageproperties/talbumlistview.cpp  
 M  +2 -2      project/project.kdevelop  


WebSVN link: http://websvn.kde.org/?view=rev&revision=812510
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
         
http://bugs.kde.org/show_bug.cgi?id=161369         




------- Additional Comments From caulier.gilles gmail com  2008-05-25 19:41 -------
SVN commit 812535 by cgilles:

backport commits #812500, 812506, 812510 from KDE branch
CCBUGS: 161369


 M  +25 -23    digikam/albumiconview.cpp  
 M  +15 -15    digikam/tagfilterview.cpp  
 M  +16 -15    digikam/tagfolderview.cpp  
 M  +30 -24    libs/imageproperties/imagedescedittab.cpp  
 M  +16 -15    libs/imageproperties/talbumlistview.cpp  
 M  +18 -2     project/project.kdevelop  


WebSVN link: http://websvn.kde.org/?view=rev&revision=812535
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
         
http://bugs.kde.org/show_bug.cgi?id=161369         




------- Additional Comments From caulier.gilles gmail com  2008-05-25 20:00 -------
Andy, i'm back to the origin problem from this thread.

Can you check if your can reproduce the problem to enable all Metadata settings in config panel ? Note : this is my configuration...

Gilles
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
         
http://bugs.kde.org/show_bug.cgi?id=161369         




------- Additional Comments From andi.clemens gmx net  2008-05-25 22:06 -------
Created an attachment (id=24939)
 --> (http://bugs.kde.org/attachment.cgi?id=24939&action=view)
video showing the indicator issue
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
         
http://bugs.kde.org/show_bug.cgi?id=161369         




------- Additional Comments From andi.clemens gmx net  2008-06-17 14:42 -------
I tested again the indicator lamp issue, and the problem is that filtering is done for every single image... look at albumlister.cpp:617-632:

ImageInfo* info = new ImageInfo(imageID, albumID, name,
                                        QDateTime::fromString(date, Qt::ISODate),
                                        size, dims);

        if (matchesFilter(info, foundText))
        {
            match = true;
            newFilteredItemsList.append(info);
        }

        newItemsList.append(info);
        d->itemList.append(info);

        if (foundText)
            matchForText = true;

Every single time the two boolean vars matchForText and match are set so in recursive album view this results in the described problem.
We have to call the slotFilterItems() or the timer instead of emitting the two signals in line 634 so the new filtered imagelist is scanned and the lamp is set to either green or red.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
         
http://bugs.kde.org/show_bug.cgi?id=161369         
andi.clemens gmx net changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #24578|0                           |1
        is obsolete|                            |



------- Additional Comments From andi.clemens gmx net  2008-06-17 14:54 -------
Created an attachment (id=25403)
 --> (http://bugs.kde.org/attachment.cgi?id=25403&action=view)
possible fix
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel