[Bug 161084] New: not properly updates status bar info

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
         
http://bugs.kde.org/show_bug.cgi?id=161084         
           Summary: not properly updates status bar info
           Product: digikam
           Version: 0.9.4-svn
          Platform: Compiled Sources
        OS/Version: Linux
            Status: NEW
          Severity: normal
          Priority: NOR
         Component: Albums GUI
        AssignedTo: digikam-devel kde org
        ReportedBy: mikmach wp pl


Version:           0.9.4-svn (using Devel)
Installed from:    Compiled sources
Compiler:          gcc4.3
OS:                Linux

After filtering on status line (as with rating) image description isn't
updated automatically. Example:

Focus is on image.jpg . This is 6th image of 120. Status line is:

image.jpg (6 of 120)

Set rating of this image to five stars. Start filtering, Even when
filtering left only this one image text in status line is the same. Only
change of focus brings change.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
         
http://bugs.kde.org/show_bug.cgi?id=161084         
mikmach wp pl changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Priority|NOR                         |HI



------- Additional Comments From mikmach wp pl  2008-04-20 21:45 -------
According to Gilles' wish on mailing list upping priority.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Marcel Wiesweg]

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
         
http://bugs.kde.org/show_bug.cgi?id=161084         




------- Additional Comments From marcel.wiesweg gmx de  2008-04-22 15:01 -------
This would be a working, quick fix:
Index: digikam/iconview.cpp
===================================================================
--- digikam/iconview.cpp        (Revision 799809)
+++ digikam/iconview.cpp        (Arbeitskopie)
 @ -517,7 +517,8  @

     // Remove from selected item list
     d->selectedItems.remove(item);
-    if (item->isSelected())
+    // See bug 161084
+    if (d->selectedItems.count() || item->isSelected())
         d->needEmitSelectionChanged = true;

     if (d->toolTipItem == item)

but there has not been any change in that area lately, so if as Gilles said this bug was introduced since beta1, the reason must be elsewhere. Currently I dont know how this could have worked. The status line is updated on signalSelectionChanged, and when one item is selected and remains selected, although all other items are removed, the selection does not changed. The patch above causes emitting the signal always if there is a selection and any item is removed (so it's then signalSelectionChangedOrTotalNumberOfItemsChanged() actually ;-) )
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
         
http://bugs.kde.org/show_bug.cgi?id=161084         




------- Additional Comments From caulier.gilles gmail com  2008-04-22 15:53 -------
Marcel,

Sound like you patch fix the problem. But i'm not sure than it solve the real problem... (:=)))

Are you tried to reproduce the 2nd problem discuted on irc :

- 1/ Open right sidebar in metadata or properties tab.
- 2/ Select an album with items.
- 3/ Close digikam
- 4/ Restart it.
- 5/ Sometimes, the right sidebar is not updated with the first item selected from last open album, just after startup.

Notes :

- This is not reproductible each time.
- I have not yet tested on my laptop with your patch to see if this problem is fixed too.

Mik, can you confirm if patch work for you ?

Gilles
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
         
http://bugs.kde.org/show_bug.cgi?id=161084         




------- Additional Comments From mikmach wp pl  2008-04-22 20:22 -------
> Mik, can you confirm if patch work for you ?


Fixes partially. Status info changes when before filtering action focus
wasn't on one of images which will stay visible after filtering. In
other words - when focus change will be enforced by reduced number of
visible items. If focus is on one of images which would be visible after
filter action - status bar text is not changed.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
         
http://bugs.kde.org/show_bug.cgi?id=161084         




------- Additional Comments From caulier.gilles gmail com  2008-04-25 12:16 -------
Mik,

It's not clear for me. Can you give me a action list to do to reproduce it ?

Thanks in advance

Gilles
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
         
http://bugs.kde.org/show_bug.cgi?id=161084         




------- Additional Comments From caulier.gilles gmail com  2008-04-25 12:18 -------
SVN commit 800961 by cgilles:

patch fromMarcel to force updating of status bar with selection
CCBUGS: 161084


 M  +2 -1      iconview.cpp  


WebSVN link: http://websvn.kde.org/?view=rev&revision=800961
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
         
http://bugs.kde.org/show_bug.cgi?id=161084         




------- Additional Comments From caulier.gilles gmail com  2008-04-25 12:20 -------
SVN commit 800964 by cgilles:

backport commit #800961 from KDE3 branch
CCBUGS: 161084


 M  +2 -1      iconview.cpp  


WebSVN link: http://websvn.kde.org/?view=rev&revision=800964
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
         
http://bugs.kde.org/show_bug.cgi?id=161084         




------- Additional Comments From mikmach wp pl  2008-04-26 08:25 -------
After clean compilation works for me. One side effect: after assignment of rating status bar info is cleared.

May I close this bug report or something else is to be done?
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
         
http://bugs.kde.org/show_bug.cgi?id=161084         




------- Additional Comments From caulier.gilles gmail com  2008-04-26 08:40 -------
Mik,

Agree. I have already seen a dysfunction between Rating filter and Filter spot light. I suspect something wrong in AlbumLister class. This is another problem.

Gilles
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
         
http://bugs.kde.org/show_bug.cgi?id=161084         
caulier.gilles gmail com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|                            |FIXED



------- Additional Comments From caulier.gilles gmail com  2008-04-26 09:42 -------
Mik,

I close this file. Please open a new one about comment #8. Thanks in advance

Gilles
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel