[Bug 158174] New: precise aspect ratio crop feature

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
         
http://bugs.kde.org/show_bug.cgi?id=158174         
           Summary: precise aspect ratio crop feature
           Product: digikam
           Version: unspecified
          Platform: Compiled Sources
        OS/Version: Linux
            Status: UNCONFIRMED
          Severity: wishlist
          Priority: NOR
         Component: general
        AssignedTo: digikam-devel kde org
        ReportedBy: roberto.castagnola gmail com


Version:            (using KDE 3.5.8)
Installed from:    Compiled From Sources

Next attached patch adds a precise ratio crop feature as suggested by Arnd (Bug 128293 Comment #12).
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
         
http://bugs.kde.org/show_bug.cgi?id=158174         




------- Additional Comments From roberto.castagnola gmail com  2008-02-21 18:06 -------
Created an attachment (id=23652)
 --> (http://bugs.kde.org/attachment.cgi?id=23652&action=view)
ratiocrop-precisecrop.patch

Changes:
- new option to force a precise aspect ratio crop.
- reuse code from applyAspectRatio function when drawing a symmetric selection
with mouse, thus computeAspectRatio function is no more needed.
- few more comments added to code.

Arnd, does it work as you thought?
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Arnd Baecker]

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
         
http://bugs.kde.org/show_bug.cgi?id=158174         




------- Additional Comments From arnd.baecker web de  2008-02-21 20:06 -------
SVN commit 777847 by abaecker:

When using the aspect ratio crop, it is now possible to ensure that the
aspect ratio is fulfilled exactly. This is done by only allowing
those combinations of width/heights which lead to the correct aspect ratio
(thanks to Roberto Castagnola who wrote the patch).

CCBUGS: 158174
TODO:KDE4PORT



 M  +3 -1      NEWS  
 M  +25 -4     imageplugins/coreplugin/ratiocrop/imageeffect_ratiocrop.cpp  
 M  +2 -0      imageplugins/coreplugin/ratiocrop/imageeffect_ratiocrop.h  
 M  +138 -170  imageplugins/coreplugin/ratiocrop/imageselectionwidget.cpp  
 M  +7 -2      imageplugins/coreplugin/ratiocrop/imageselectionwidget.h  


WebSVN link: http://websvn.kde.org/?view=rev&revision=777847
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
         
http://bugs.kde.org/show_bug.cgi?id=158174         
caulier.gilles gmail com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Product|digikam                     |digikamimageplugins



------- Additional Comments From caulier.gilles gmail com  2008-02-21 20:19 -------
Roberto, thanls again for this patch...

Arnd, this file is not yet closed...

Gilles
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
         
http://bugs.kde.org/show_bug.cgi?id=158174         
caulier.gilles gmail com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
          Component|general                     |Core Plugin
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
         
http://bugs.kde.org/show_bug.cgi?id=158174         




------- Additional Comments From caulier.gilles gmail com  2008-02-21 20:21 -------
Arnd,

I'm stupid (:=))). It's not yet closed because the code is not yet ported to KDE4...

Sorry for the sound (:=)))

Gilles
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Arnd Baecker]

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
         
http://bugs.kde.org/show_bug.cgi?id=158174         




------- Additional Comments From arnd.baecker web de  2008-02-21 22:40 -------
Roberto,

everything works perfect in all the cases I checked.
Thanks a lot for your patch, it is very much appreciated!!

Best wishes,

Arnd
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
         
http://bugs.kde.org/show_bug.cgi?id=158174         




------- Additional Comments From caulier.gilles gmail com  2008-03-14 12:31 -------
SVN commit 785562 by cgilles:

digiKam from trunk (KDE4) : Ratio crop tool : backport commit #777847 from KDE3 branch
CCBUGS: 158174


 M  +27 -6     imageeffect_ratiocrop.cpp  
 M  +2 -0      imageeffect_ratiocrop.h  
 M  +140 -171  imageselectionwidget.cpp  
 M  +9 -4      imageselectionwidget.h  


WebSVN link: http://websvn.kde.org/?view=rev&revision=785562
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
         
http://bugs.kde.org/show_bug.cgi?id=158174         




------- Additional Comments From caulier.gilles gmail com  2008-03-14 12:45 -------
Roberto,

Your patch have been ported to KDE4 implementation.

But i recommend to test if all work fine for you. Your patch is huge and i hope to not have forget something (:=)))

Thanks in advance

Gilles Caulier
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
         
http://bugs.kde.org/show_bug.cgi?id=158174         




------- Additional Comments From caulier.gilles gmail com  2008-03-14 12:54 -------
Screenshot of Showfoto for KDE4 running Ratio Crop tool using "Desert" color scheme theme:

http://digikam3rdparty.free.fr/Screenshots/FullColorThemeSupport/fullcolortheme6.png

This rock no ???

Gilles Caulier
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
         
http://bugs.kde.org/show_bug.cgi?id=158174         




------- Additional Comments From mikmach wp pl  2008-03-14 23:32 -------
> This rock no ???


Yes, it rocks :)
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
         
http://bugs.kde.org/show_bug.cgi?id=158174         




------- Additional Comments From roberto.castagnola gmail com  2008-03-15 11:27 -------
It's a PITA for me to download it with svn at home using 56K modem, and I don't know how to download it at work using windows. Is there any kde4 port snapshot available?
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
         
http://bugs.kde.org/show_bug.cgi?id=158174         




------- Additional Comments From caulier.gilles gmail com  2008-03-15 14:31 -------
Roberto,

Yes, there are daily snapshot created automatically by a script hosted by KDE. Look here :

ftp://ftp.kde.org/pub/kde/unstable/snapshots/

Gilles
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
         
http://bugs.kde.org/show_bug.cgi?id=158174         




------- Additional Comments From roberto.castagnola gmail com  2008-03-15 15:24 -------
Gilles,

I will hopefully try it next week, thanks.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
         
http://bugs.kde.org/show_bug.cgi?id=158174         
caulier.gilles gmail com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |RESOLVED
         Resolution|                            |FIXED



------- Additional Comments From caulier.gilles gmail com  2008-03-20 14:53 -------
Code is now backported to KDE4. I close this file.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel