[Bug 156847] New: Missing thumbnails in album overview

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
         
http://bugs.kde.org/show_bug.cgi?id=156847         




------- Additional Comments From achim luecking-brothers de  2008-03-11 22:32 -------
Arnd,

I set the ratings of value -1 bach to 0 using sqlite3 from command line. Now everything works fine with 0.9.3 :)

So we have to check how ratings < 0 were inserted into database and need an idea how to correct them for users without a manual command line database modification...
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Arnd Baecker]

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
         
http://bugs.kde.org/show_bug.cgi?id=156847         
arnd.baecker web de changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |NEW
      everconfirmed|0                           |1



------- Additional Comments From arnd.baecker web de  2008-03-11 22:42 -------
Achim,

negative ratings were possible before this  bug
  http://bugs.kde.org/show_bug.cgi?id=151357
was fixed (with 0.9.3).

About the command you used for the database: maybe you could also post
it here, because it might be useful to others?

The general solution will be to perform an automatic check on startup
(maybe triggered only once, when an update to 0.9.3 is done).
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
         
http://bugs.kde.org/show_bug.cgi?id=156847         




------- Additional Comments From achim luecking-brothers de  2008-03-11 23:00 -------
Arnd,

sure, here is the used database modification:

achim cs01:~/Pics> sqlite3 digikam.db
sqlite> update ImageProperties set value=0 where property='Rating' and value=-1;
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
         
http://bugs.kde.org/show_bug.cgi?id=156847         




------- Additional Comments From rob tenfoot org uk  2008-03-11 23:08 -------
It looks like a fix is already in the trunk branch: AlbumLister::matchesFilter includes a check for rating == -1 and sets it to 0 for use in the comparison.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
         
http://bugs.kde.org/show_bug.cgi?id=156847         




------- Additional Comments From achim luecking-brothers de  2008-03-12 09:31 -------
Thanks for the info, Rob.

But: what is the better way for this problem? Add a check for rating -1 to the filter and keep the negative ratings (as it seeemed to be done in the main trunk) or set the negative ratings to 0 in the database on startup?

I think the last one is the better way, because it prevents possible and similar problems in the future.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Marcel Wiesweg]

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
         
http://bugs.kde.org/show_bug.cgi?id=156847         




------- Additional Comments From marcel.wiesweg gmx de  2008-03-16 17:20 -------
For the KDE4 version, -1 is a valid value: sometime ago there was a discussion about the difference of "not rated" and "rating 0", with the result that there is a difference, so now -1 means "not rated" (although there is no UI to reset a rating of 0 to "not rated"). The effect is the -1 and 0 are treated mostly identical, but probably -1 can be searched for as "not rated".
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Arnd Baecker]

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
         
http://bugs.kde.org/show_bug.cgi?id=156847         




------- Additional Comments From arnd.baecker web de  2008-03-16 22:58 -------
Question: when you have the negative ratings, do these also appear
in the file itself (i.e. if you decided to store the rating in the exif)?
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
         
http://bugs.kde.org/show_bug.cgi?id=156847         




------- Additional Comments From rob tenfoot org uk  2008-03-18 11:06 -------
Exiftool doesn't report any tags called "Rating" or similar in any of the files that were affected.  

I only use digikam for managing my photos, so if that tag was set, then it would have come from digikam.  I don't usually sync the meta data back to the files, so the exif wouldn't have changed from when they were taken
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Marcel Wiesweg]

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
         
http://bugs.kde.org/show_bug.cgi?id=156847         




------- Additional Comments From marcel.wiesweg gmx de  2008-03-19 23:03 -------
I think I can confirm that digikam has a range check before writing the rating value in the images. This means that in the worst case, images will lack rating information.
This also means fixing the database is the way to go for 0.9.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
         
http://bugs.kde.org/show_bug.cgi?id=156847         




------- Additional Comments From andi.clemens gmx net  2008-08-16 10:45 -------
What about this report here? The original problem seems to be fixed, so I guess we can at least mark it as FIXED to reduce the digikam bug count...
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel