[Bug 149654] New: fullscreen icon changes image's zoom to 100% (should fit to screen)

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
         
http://bugs.kde.org/show_bug.cgi?id=149654         
           Summary: fullscreen icon changes image's zoom to 100% (should fit
                    to screen)
           Product: digikam
           Version: unspecified
          Platform: unspecified
        OS/Version: Linux
            Status: UNCONFIRMED
          Severity: normal
          Priority: NOR
         Component: general
        AssignedTo: digikam-devel kde org
        ReportedBy: nadavkav gmail com


Version:           0.9.2-final (using KDE 3.5.7, Debian Package 4:3.5.7.dfsg.1-5 (lenny/sid))
Compiler:          Target: i486-linux-gnu
OS:                Linux (i686) release 2.6.21-2-686

when i click the "full screen mode" icon, the current image is zoomed to 100% and not to "fit screen size" as i think it should.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
         
http://bugs.kde.org/show_bug.cgi?id=149654         




------- Additional Comments From caulier.gilles gmail com  2007-09-08 17:00 -------
Nadav,

Full screen from album gui or image editor ?

Gilles caulier
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
         
http://bugs.kde.org/show_bug.cgi?id=149654         




------- Additional Comments From nadavkav gmail com  2007-09-08 18:54 -------
album gui


On 8 Sep 2007 15:00:55 -0000, Gilles Caulier <caulier.gilles gmail com>
wrote:
[bugs.kde.org quoted mail]
album gui<br><br><br><div><span class="gmail_quote">On 8 Sep 2007 15:00:55 -0000, <b class="gmail_sendername">Gilles Caulier</b> &lt;<a href="mailto:caulier.gilles gmail com">caulier gilles gmail com</a>&gt; wrote:</span><blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;">
------- You are receiving this mail because: -------<br>You reported the bug, or are watching the reporter.<br><br><a href="http://bugs.kde.org/show_bug.cgi?id=149654">http://bugs.kde.org/show_bug.cgi?id=149654</a><br><br>
<br><br><br>------- Additional Comments From caulier.gilles gmail com&nbsp;&nbsp;2007-09-08 17:00 -------<br>Nadav,<br><br>Full screen from album gui or image editor ?<br><br>Gilles caulier<br></blockquote></div><br>
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
         
http://bugs.kde.org/show_bug.cgi?id=149654         




------- Additional Comments From nadavkav gmail com  2007-09-08 18:56 -------
and...
after the image's thumb was pressed.
because if you don't click the image's thumb and just move to Full Screen
Mode and then click any image thumb then all is ok.

On 8 Sep 2007 15:00:55 -0000, Gilles Caulier <caulier.gilles gmail com>
wrote:
[bugs.kde.org quoted mail]
and...<br>after the image&#39;s thumb was pressed.<br>because if you don&#39;t click the image&#39;s thumb and just move to Full Screen Mode and then click any image thumb then all is ok.<br><br><div><span class="gmail_quote">
On 8 Sep 2007 15:00:55 -0000, <b class="gmail_sendername">Gilles Caulier</b> &lt;<a href="mailto:caulier.gilles gmail com">caulier gilles gmail com</a>&gt; wrote:</span><blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;">
------- You are receiving this mail because: -------<br>You reported the bug, or are watching the reporter.<br><br><a href="http://bugs.kde.org/show_bug.cgi?id=149654">http://bugs.kde.org/show_bug.cgi?id=149654</a><br><br>
<br><br><br>------- Additional Comments From caulier.gilles gmail com&nbsp;&nbsp;2007-09-08 17:00 -------<br>Nadav,<br><br>Full screen from album gui or image editor ?<br><br>Gilles caulier<br></blockquote></div><br>
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
         
http://bugs.kde.org/show_bug.cgi?id=149654         




------- Additional Comments From nadavkav gmail com  2007-09-08 18:59 -------
sorry for the gmail garbedge
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
         
http://bugs.kde.org/show_bug.cgi?id=149654         
caulier.gilles gmail com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
          Component|general                     |Preview
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
         
http://bugs.kde.org/show_bug.cgi?id=149654         




------- Additional Comments From andi.clemens gmx net  2008-04-30 20:42 -------
I can confirm this bug... it doesn't seem to be fixed in 0.9.4beta4.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Arnd Baecker]

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
         
http://bugs.kde.org/show_bug.cgi?id=149654         




------- Additional Comments From arnd.baecker web de  2008-04-30 21:21 -------
Wouldn't it be even better, if the current zoom-level and
center position is kept ?
I.e.: if fit-to-window is the current view, then also do a fit-to-window
in full-screen mode. But if a different zoom (eg. 100% etc.) and
centering is done, this should be kept.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Arnd Baecker]

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
         
http://bugs.kde.org/show_bug.cgi?id=149654         
arnd.baecker web de changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |NEW
      everconfirmed|0                           |1
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
         
http://bugs.kde.org/show_bug.cgi?id=149654         




------- Additional Comments From andi.clemens gmx net  2008-05-27 11:46 -------
Arnd, yes I think it should keep the current settings, but right now it is not working as expected. If you have "fit-to-window" enabled, click on a thumbnail to open the image viewer and click on the fullscreen icon, the image is displayed in its full size (1:1).
You have to return into thumbnail view mode and click on the image again to have it "fit-to-window". So when switching into fullscreen mode while looking at an image you have to click the mouse 3 times (fullscreen icon, image->thumbnail view, image->image view) to get the result you expect.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
         
http://bugs.kde.org/show_bug.cgi?id=149654         




------- Additional Comments From andi.clemens gmx net  2008-06-19 11:34 -------
Created an attachment (id=25453)
 --> (http://bugs.kde.org/attachment.cgi?id=25453&action=view)
patch #1

After testing millions of signals and slots I found a solution that works...
Another solution was setting an additional fit2window boolean variable and
calling 4 signals, but in the end this seems to be much easier and the
displaying is much faster.

Gilles, what do you think?
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
         
http://bugs.kde.org/show_bug.cgi?id=149654         




------- Additional Comments From gerhard.dirschl gmx de  2008-06-26 10:51 -------
Created an attachment (id=25615)
 --> (http://bugs.kde.org/attachment.cgi?id=25615&action=view)
Another fix

It's caused by slotZoomSliderChanged(d->albumSettings->getDefaultIconSize()) in
DigikamApp::show() which is called when switching to fullscreen.
slotZoomSliderChanged(d->albumSettings->getDefaultIconSize()) sets the
zoomFactor to a value larger than calcAutoZoomFactor(ZoomInOnly), and hence
ImagePreviewView::resizeEvent(...) does not set the fit-to-window zoom factor.

I simply removed slotZoomSliderChanged(d->albumSettings->getDefaultIconSize())
(see attachment).
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
         
http://bugs.kde.org/show_bug.cgi?id=149654         




------- Additional Comments From caulier.gilles gmail com  2008-06-26 10:56 -------
Andi,

Please look fix from Gerhard. We will take a look together whole changes before inclusion in svn...

Gilles
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
         
http://bugs.kde.org/show_bug.cgi?id=149654         




------- Additional Comments From andi.clemens gmx net  2008-06-26 11:03 -------
Seems to work fine...
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
         
http://bugs.kde.org/show_bug.cgi?id=149654         
andi.clemens gmx net changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|                            |FIXED



------- Additional Comments From andi.clemens gmx net  2008-07-02 13:45 -------
SVN commit 827143 by aclemens:

fixed image resize issue when switching to fullscreen mode

BUG:149654

 M  +2 -1      NEWS  
 M  +0 -3      digikam/digikamapp.cpp  
 M  +1 -1      digikam/digikamappprivate.h  


WebSVN link: http://websvn.kde.org/?view=rev&revision=827143
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
         
http://bugs.kde.org/show_bug.cgi?id=149654         
andi.clemens gmx net changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |toralf.foerster gmx de



------- Additional Comments From andi.clemens gmx net  2008-07-28 21:57 -------
*** Bug 159788 has been marked as a duplicate of this bug. ***
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel