[Bug 148072] New: zoom tool for sharpen tool is ankward

[Laurent COOPER]

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
         
http://bugs.kde.org/show_bug.cgi?id=148072         
           Summary: zoom tool for sharpen tool is ankward
           Product: digikam
           Version: unspecified
          Platform: Ubuntu Packages
        OS/Version: Linux
            Status: UNCONFIRMED
          Severity: wishlist
          Priority: NOR
         Component: general
        AssignedTo: digikam-devel kde org
        ReportedBy: laurent.cooper free fr


Version:           0.9.2-final (using KDE KDE 3.5.6)
Installed from:    Ubuntu Packages

In previous digikam version, when using the sharpen tool, there was an easy zoom chooser : 1x 2x 0.5x ...

Now, there is a slider with an apparently continuous choice.

But the result is much difficult to see. With a sharpen tool, I like to "a priori" have a 100% view, to see the real effect. Are fringes appearing? Is there a real improve?

With this slider, it's particulary complex to set zoom to 100%. And the question arise : are the effect dissolved into resizing? Specialy important for pictures who are to be sent to a labo for printing.

A simple button zoom choice should be an option at least. And 100% should be the default (not the full size of the picture height)

BTW, it's no more possible to save the unsharp mask parameters? (another bug to be opened or I'm just lost?)
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
         
http://bugs.kde.org/show_bug.cgi?id=148072         
caulier.gilles gmail com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Product|digikam                     |digikamimageplugins
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
         
http://bugs.kde.org/show_bug.cgi?id=148072         
caulier.gilles gmail com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
          Component|general                     |Unsharp
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Dik Takken]

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
         
http://bugs.kde.org/show_bug.cgi?id=148072         




------- Additional Comments From d.h.j.takken phys uu nl  2007-07-26 22:18 -------
I agree on this one. Before deciding if your settings are producing the desired result, you MUST be sure that you are looking at the original pixels. Unscaled, unprocessed in any way. A 100% zoom setting is really needed here.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
         
http://bugs.kde.org/show_bug.cgi?id=148072         




------- Additional Comments From rbr28 yahoo com  2007-09-25 16:51 -------
I agree this is a high priority.  I don't care how it is done, but a simple and quick way to choose 100% view in the edit preview would be a great help.

Thanks,
Vern
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Arnd Baecker]

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
         
http://bugs.kde.org/show_bug.cgi?id=148072         
arnd.baecker web de changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |NEW
      everconfirmed|0                           |1
           Priority|NOR                         |HI



------- Additional Comments From arnd.baecker web de  2007-11-05 11:02 -------
I agree, unsharp needs a 100% view.
(note also the related bug http://bugs.kde.org/show_bug.cgi?id=147542)
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
         
http://bugs.kde.org/show_bug.cgi?id=148072         




------- Additional Comments From mikmach wp pl  2007-11-13 09:22 -------
Probably simplest solution would be make +- buttons jump to predefined
values, not change by some random(?) value. Eg. always jump to x0% (10,
20, 30, 40, 50, 60, 70, 80, etc.).
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Arnd Baecker]

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
         
http://bugs.kde.org/show_bug.cgi?id=148072         




------- Additional Comments From arnd.baecker web de  2007-11-13 09:30 -------
Zooming is in a non-linear way because
going from 10% to 20% is a huge step, while going from 100% to 110%
is only a small one.

Wouldn't a [100%] button at the side just do the job
(+ keyboard shortcut)?
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
         
http://bugs.kde.org/show_bug.cgi?id=148072         




------- Additional Comments From mikmach wp pl  2007-11-13 11:38 -------
Not additional button - it is cluttering of interface.

Maybe creating some smarter chain of predefined zoom factors. I remember
in old Photoshop 4 in navigation tool, zoom buttons where giving steps
like: 16%, 33%, 50%, 75%(?), 100%, 130%, more I don't remember.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
         
http://bugs.kde.org/show_bug.cgi?id=148072         




------- Additional Comments From caulier.gilles gmail com  2007-11-13 11:50 -------
Mik,

This is my reference (:=))):

http://www.powerretouche.com/Windows_plugins/sharpness_plugin.jpg

Look on the bottom/left : you have a slider (like 0.9.3) and buttons (like 0.9.2)...

We just need to have both at the same time... When i have used the zoom slider in image plugins, i have thinking this will be enough, without buttons. This is a wrong judgment from me...

Gilles
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
         
http://bugs.kde.org/show_bug.cgi?id=148072         




------- Additional Comments From caulier.gilles gmail com  2007-11-13 11:53 -------
>Look on the bottom/left : you have a slider (like 0.9.3) and buttons (like 0.9.2)...

Oups, "and buttons (like 0.9.1)" i want mean...

Gilles
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
         
http://bugs.kde.org/show_bug.cgi?id=148072         




------- Additional Comments From mikmach wp pl  2007-11-13 12:06 -------
Ah. Yes, looks like PR got it right :)
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gerhard Kulzer-3]

Am Tuesday 13 November 2007 schrieb Gilles Caulier:

> ------- You are receiving this mail because: -------
> You are the assignee for the bug, or are watching the assignee.
>
> http://bugs.kde.org/show_bug.cgi?id=148072
>
>
>
>
> ------- Additional Comments From caulier.gilles gmail com  2007-11-13 11:50
> ------- Mik,
>
> This is my reference (:=))):
>
> http://www.powerretouche.com/Windows_plugins/sharpness_plugin.jpg
>
> Look on the bottom/left : you have a slider (like 0.9.3) and buttons (like
> 0.9.2)...
>
> We just need to have both at the same time... When i have used the zoom
> slider in image plugins, i have thinking this will be enough, without
> buttons. This is a wrong judgment from me...
>
> Gilles

I agree Gilles, but for sharpening we need a 100% or 1x zomm default + button

Gerhard

_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
         
http://bugs.kde.org/show_bug.cgi?id=148072         




------- Additional Comments From caulier.gilles gmail com  2007-12-02 10:31 -------
To original post from Laurent :

>In previous digikam version, when using the sharpen tool, there was an easy >zoom chooser : 1x 2x 0.5x ...

>Now, there is a slider with an apparently continuous choice.

>But the result is much difficult to see. With a sharpen tool, I like to "a >priori" have a 100% view, to see the real effect. Are fringes appearing? Is >there a real improve?

Oh yes ! Zoom is performed imediatly in memory without to allocate more memory space. Previous implementation recompute the whole image to scale it. This way is definitivly wrong !!!

>With this slider, it's particulary complex to set zoom to 100%. And the >question arise : are the effect dissolved into resizing? Specialy important for >pictures who are to be sent to a labo for printing.

>A simple button zoom choice should be an option at least. And 100% should be >the default (not the full size of the picture height)

Yes, a 100% button can be done, but for small image (with a size smaller than screen size), 100% zoom value will not work properlly in preview. Something is wrong in preview widget implementation (indeep)

Look screenshot from my computer...


>BTW, it's no more possible to save the unsharp mask parameters? (another bug to >be opened or I'm just lost?)

Use Load and SaveAs button on the bottom of dialog...

Gilles
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
         
http://bugs.kde.org/show_bug.cgi?id=148072         




------- Additional Comments From caulier.gilles gmail com  2007-12-02 10:34 -------
Created an attachment (id=22276)
 --> (http://bugs.kde.org/attachment.cgi?id=22276&action=view)
dysfunction of preview in Sharpen tool with small picture and x1 zoom
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
         
http://bugs.kde.org/show_bug.cgi?id=148072         




------- Additional Comments From caulier.gilles gmail com  2007-12-02 10:42 -------
Created an attachment (id=22277)
 --> (http://bugs.kde.org/attachment.cgi?id=22277&action=view)
Patch to test x1 zoom dysfunction with sharpen preview widget

Note : With large images, of course X1 button always work...
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Markus Spring]

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
         
http://bugs.kde.org/show_bug.cgi?id=148072         




------- Additional Comments From m.spring gmx de  2007-12-18 12:15 -------
The "Patch to test x1 zoom dysfunction with sharpen preview widget" resolves this problem. I would suggest to add it to trunk.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Arnd Baecker]

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
         
http://bugs.kde.org/show_bug.cgi?id=148072         




------- Additional Comments From arnd.baecker web de  2007-12-19 21:21 -------
I think the first problem is the slider range, as computed in
void ImageRegionWidget::resizeEvent(QResizeEvent* e)
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Arnd Baecker]

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
         
http://bugs.kde.org/show_bug.cgi?id=148072         




------- Additional Comments From arnd.baecker web de  2007-12-20 11:02 -------
The slider range issue could be overcome by this:
--- libs/widgets/imageplugins/imageregionwidget.cpp     (revision 750612)
+++ libs/widgets/imageplugins/imageregionwidget.cpp     (working copy)
 @ -118,6 +118,10  @
     double dstWidth  = contentsRect().width();
     double dstHeight = contentsRect().height();
     double zoom      = QMAX(dstWidth/srcWidth, dstHeight/srcHeight);
+
+    // For small images we start with 100% zoom, i.e. smaller than contentsRect.
+    if (zoom>1.0)
+        zoom = 1.0;

     setZoomMin(zoom);
     setZoomMax(zoom*12.0);

------------

But this (of course) addresses non of the problems one gets.

Gilles, I think Markus suggestion #c13 to apply your patch
is a good one: for normal images everything is ok (and that is really the majority I would guess), while for small images we have
to find the origin of the problem (seems not an easy one at first glance).
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Arnd Baecker]

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
         
http://bugs.kde.org/show_bug.cgi?id=148072         




------- Additional Comments From arnd.baecker web de  2008-04-24 09:49 -------
Gilles, I just came across
http://bugs.kde.org/show_bug.cgi?id=148234
"Small images cause zoom slider crazyness"
Most likely the dysfunction you show in #c11
is related to that bug.
(So let me repeat my suggestion: let's get your patch  #c12 in,
maybe also #c15, and solve the remaining issue for small images in the other
bug ....)
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel