[Bug 147689] New: cameras.xml file not closed

[Mark Asselstine]

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
         
http://bugs.kde.org/show_bug.cgi?id=147689         
           Summary: cameras.xml file not closed
           Product: digikam
           Version: unspecified
          Platform: Debian stable
        OS/Version: Linux
            Status: UNCONFIRMED
          Severity: normal
          Priority: NOR
         Component: general
        AssignedTo: digikam-devel kde org
        ReportedBy: asselsm gmail com


Version:           cvs HEAD (using KDE KDE 3.5.5)
Installed from:    Debian stable Packages
OS:                Linux

In examining the digikam code base in subversion I notice that CameraList::load() does not close the file opened in the function. This will of course not necessarily crash the application but is not generally a good idea and I suspect that it was just missed.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Mark Asselstine]

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
         
http://bugs.kde.org/show_bug.cgi?id=147689         




------- Additional Comments From asselsm gmail com  2007-07-09 04:50 -------
Created an attachment (id=21094)
 --> (http://bugs.kde.org/attachment.cgi?id=21094&action=view)
possible fix
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
         
http://bugs.kde.org/show_bug.cgi?id=147689         
caulier.gilles gmail com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
          Component|general                     |Camera GUI
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
         
http://bugs.kde.org/show_bug.cgi?id=147689         
caulier.gilles gmail com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |RESOLVED
         Resolution|                            |INVALID



------- Additional Comments From caulier.gilles gmail com  2007-07-10 22:35 -------
Asselstine,

No need to call close() method, it closed when QFile instance is destroyed. Look here :

http://doc.trolltech.com/3.3/qfile#~QFile

So it's done automaticly by Qt.

Gilles Caulier
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel