[Bug 147600] New: open folder - files shown in reverse order

[Steve-233]

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
         
http://bugs.kde.org/show_bug.cgi?id=147600         
           Summary: open folder - files shown in reverse order
           Product: showfoto
           Version: unspecified
          Platform: SuSE RPMs
        OS/Version: Linux
            Status: UNCONFIRMED
          Severity: normal
          Priority: NOR
         Component: general
        AssignedTo: digikam-devel kde org
        ReportedBy: stevod333 yahoo com au


Version:           0.6.0 (using KDE KDE 3.5.7)
Installed from:    SuSE RPMs
OS:                Linux

Not sure if this is a bug or not, but I can't find any way to change this behaviour...

When I open a folder (File > open folder), the thumbnails are shown in descending order (i.e last filename first). This also affects slideshows.

Very annoying if you have a series of images (say of an event) and you want to view them in order from first to last, you must choose the last image and move backwards, which makes it impossible to do a slideshow.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
         
http://bugs.kde.org/show_bug.cgi?id=147600         




------- Additional Comments From caulier.gilles gmail com  2007-07-06 12:50 -------
Steve,

Open Folder sorting file is harcoded in showfoto. Sorting is based on file date (more recent in first).

It's can be trivial to add a new option in settings dialog.

Beginner developpers, this task is for you (:=)))

The code to patch in showfoto.cpp is in "void ShowFoto::openFolder(const KUrl& url)" where you have these lines :

    // Directory items sorting. Perhaps we need to add any settings in config dialog.
    dir.setFilter ( QDir::Files | QDir::NoSymLinks );
    dir.setSorting ( QDir::Time );

Gilles
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Arnd Baecker]

>     dir.setSorting ( QDir::Time );
Why not just use
      dir.setSorting ( QDir::Time| QDir::Reversed );
?
Making this configurable seems not necessary to me.

Arnd
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Arnd Baecker]

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
         
http://bugs.kde.org/show_bug.cgi?id=147600         




------- Additional Comments From arnd.baecker web de  2007-07-06 13:02 -------
>     dir.setSorting ( QDir::Time );

Why not just use
      dir.setSorting ( QDir::Time| QDir::Reversed );
?
Making this configurable seems not necessary to me.

Arnd
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Steve-233]

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
         
http://bugs.kde.org/show_bug.cgi?id=147600         




------- Additional Comments From stevod333 yahoo com au  2007-07-06 14:22 -------
I agree Arnd, I don't think it really needs to be a settings option.
I'd have a crack at it, but my C skills are only at the very beginning of their developing life... Hope someone out there could have a go at it, otherwise I'll give it a go once I've got a bit more experience under my belt.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
         
http://bugs.kde.org/show_bug.cgi?id=147600         




------- Additional Comments From caulier.gilles gmail com  2007-07-06 14:29 -------
Personnaly, i always use current date order of file loaded in shwofoto. This is why i have implemented like this in source code.

I vote to add a new option in config dialog to load files in Thummbbar using and order based on multiple options as file date, file name, and reverse.

Gilles
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Arnd Baecker]

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
         
http://bugs.kde.org/show_bug.cgi?id=147600         




------- Additional Comments From arnd.baecker web de  2007-07-06 22:24 -------
Created an attachment (id=21079)
 --> (http://bugs.kde.org/attachment.cgi?id=21079&action=view)
Patch to make the sort order configurable

The attached patch implements new configuration options
in showfoto's settings to select between ordering according to
name/date/size and to reverse the ordering.
The default is to sort by increasing date.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Arnd Baecker]

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
         
http://bugs.kde.org/show_bug.cgi?id=147600         
arnd.baecker web de changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #21079|0                           |1
        is obsolete|                            |



------- Additional Comments From arnd.baecker web de  2007-07-24 11:44 -------
Created an attachment (id=21233)
 --> (http://bugs.kde.org/attachment.cgi?id=21233&action=view)
Patch to make the sort order configurable, English improvements

Compared to the previous patch, only the English corrections
by Clytie Siddall (Thanks!) are incorporated.

Further discussion in private mail with Giles (so that it
does not get lost):

Gilles: Currently, the patch fixes Open/Folder feature to order files in
thumbbar. This is not the only one issue : Open/File must be fixed in
this way, because more than one file can be loaded at the same time by
this option...

Arnd: One approach might be to introduce
      in the Routine slotOpenFile() the usage of
        QDir dir(url.path(), patterns),
      where patterns is set to the full names of the file.
      Afterwards, using the routines to sort via QDir's mechanisms
      is possible.

      Does this make sense, and sound like a good solution?

Gilles:
The standard way used is to use the void ShowFoto::applySettings() to
read settings from setup dialog (this method is called when you valid
setup dialog to update editor settings).

Store the setting in a common place to d private class like all others
settings are stored (for ex. d->deleteItem2Trash), and use these settings
where you want (slotOpenFile() or slotOpenFolder()). You can make a
common method to parse folder content accordinly with these settings.
Call this method at the right place...
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
         
http://bugs.kde.org/show_bug.cgi?id=147600         




------- Additional Comments From caulier.gilles gmail com  2007-07-24 12:04 -------
Arnd,

So, i can't said more (:=))).

If your future patch respect these rules, well commit it on svn and close this file only when somebody has tested.

Also, prepare your patch to be backported into KDE4 (trunk). The change will be minor normally...

Gilles
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
         
http://bugs.kde.org/show_bug.cgi?id=147600         




------- Additional Comments From superandrzej epf pl  2007-10-10 23:49 -------
any chance to have it included in 0.7?
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
         
http://bugs.kde.org/show_bug.cgi?id=147600         
caulier.gilles gmail com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |RESOLVED
         Resolution|                            |FIXED



------- Additional Comments From caulier.gilles gmail com  2008-03-19 09:20 -------
SVN commit 787439 by cgilles:

digiKam from KDE3 branch: Showfoto: apply patch from Arnd to a added 2 new options to set ordering of images when File/Open Folder action is used.
BUG: 147600



 M  +45 -15    setup/setupeditor.cpp
 M  +28 -3     showfoto.cpp
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
         
http://bugs.kde.org/show_bug.cgi?id=147600         




------- Additional Comments From caulier.gilles gmail com  2008-03-19 09:56 -------
SVN commit 787451 by cgilles:

backport commit #787439 from KDE3 branch
CCBUGS: 147600


 M  +36 -0     setup/setupeditor.cpp  
 M  +37 -12    showfoto.cpp  


WebSVN link: http://websvn.kde.org/?view=rev&revision=787451
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel