[Bug 147248] New: Image info doesn't follow image in the editor

classic Classic list List threaded Threaded
6 messages Options
Reply | Threaded
Open this post in threaded view
|

[Bug 147248] New: Image info doesn't follow image in the editor

Bugzilla from pave@o2.pl
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
         
http://bugs.kde.org/show_bug.cgi?id=147248         
           Summary: Image info doesn't follow image in the editor
           Product: digikam
           Version: unspecified
          Platform: unspecified
        OS/Version: Linux
            Status: UNCONFIRMED
          Severity: normal
          Priority: NOR
         Component: Image Editor
        AssignedTo: digikam-devel kde org
        ReportedBy: pave o2 pl


Version:            (using KDE KDE 3.5.7)
Installed from:    Unlisted Binary Package
OS:                Linux

When I do File->Last (or ctrl-PgDn) in the image editor mode, the image info sidebar gets desynchronized with the actual image. That way it's very easy to comment, say, 200 images only to realize at the end that the comments are saved into wrong files, which doesn't necessarily give you a nice feeling.

I took a look at the source and it turned out to be a stupid copy-paste bug. Proposed patch attached.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel
Reply | Threaded
Open this post in threaded view
|

[Bug 147248] Image info doesn't follow image in the editor

Bugzilla from pave@o2.pl
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
         
http://bugs.kde.org/show_bug.cgi?id=147248         




------- Additional Comments From pave o2 pl  2007-06-26 16:04 -------
Created an attachment (id=20972)
 --> (http://bugs.kde.org/attachment.cgi?id=20972&action=view)
changes one line that have been left unchanged afer a copy-paste
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel
Reply | Threaded
Open this post in threaded view
|

[Bug 147248] Image info doesn't follow image in the editor

Bugzilla from pave@o2.pl
In reply to this post by Bugzilla from pave@o2.pl
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
         
http://bugs.kde.org/show_bug.cgi?id=147248         




------- Additional Comments From pave o2 pl  2007-06-26 16:06 -------
This bug may have something to do with an old bug #133516 that was closed with WORKSFORME.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel
Reply | Threaded
Open this post in threaded view
|

[Bug 147248] Image info doesn't follow image in the editor

Gilles Caulier-4
In reply to this post by Bugzilla from pave@o2.pl
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
         
http://bugs.kde.org/show_bug.cgi?id=147248         




------- Additional Comments From caulier.gilles gmail com  2007-06-26 16:22 -------
Marcel,

It just a copy and paste failure (:=)))...

Patch is fine for you ?

Gilles
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel
Reply | Threaded
Open this post in threaded view
|

[Bug 147248] Image info doesn't follow image in the editor

Gilles Caulier-4
In reply to this post by Bugzilla from pave@o2.pl
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
         
http://bugs.kde.org/show_bug.cgi?id=147248         




------- Additional Comments From caulier.gilles gmail com  2007-06-26 16:24 -------
Achim, Angelo,

If patch is fine for Marcel... please unforget to backport it into 0.9.2 package.

Just follow this thread before to patch DEB and RPM

Thanks in advance...

Gilles
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel
Reply | Threaded
Open this post in threaded view
|

[Bug 147248] Image info doesn't follow image in the editor

Marcel Wiesweg
In reply to this post by Bugzilla from pave@o2.pl
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
         
http://bugs.kde.org/show_bug.cgi?id=147248         
marcel.wiesweg gmx de changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |RESOLVED
         Resolution|                            |FIXED



------- Additional Comments From marcel.wiesweg gmx de  2007-06-26 18:35 -------
SVN commit 680586 by mwiesweg:

Applying the patch from Pawel Marciniak to fix copy-and-paste bug.
Thank you very much for your patch.

BUG: 147248


 M  +1 -1      imagewindow.cpp  


--- branches/extragear/kde3/graphics/digikam/utilities/imageeditor/editor/imagewindow.cpp #680585:680586
 @ -533,7 +533,7  @
         return;
 
     d->urlCurrent = d->urlList.last();
-    d->imageInfoCurrent = d->imageInfoList.first();
+    d->imageInfoCurrent = d->imageInfoList.last();
     slotLoadCurrent();
 }
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel