[Bug 145237] New: small wishes for the light-table

[Gilles Caulier-4]

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
         
http://bugs.kde.org/show_bug.cgi?id=145237         




------- Additional Comments From caulier.gilles gmail com  2007-05-12 08:57 -------
Arnd,

About the feature "going through pairs of images", What i can use in English words to describe this new option in View menu ?

"Navigate by pair of items" is fine ?

Gilles
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Arnd Baecker]

> "Navigate by pair of items" is fine ?

Hmm, that is a not so easy one - your suggestion seems fine to me.
Maybe "Navigate by pairs" would be ok as well?

Maybe someone else has an even better suggestion...

Best, Arnd
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Arnd Baecker]

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
         
http://bugs.kde.org/show_bug.cgi?id=145237         




------- Additional Comments From arnd.baecker web de  2007-05-12 09:13 -------
> "Navigate by pair of items" is fine ?


Hmm, that is a not so easy one - your suggestion seems fine to me.
Maybe "Navigate by pairs" would be ok as well?

Maybe someone else has an even better suggestion...

Best, Arnd
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Marcel Wiesweg]

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
         
http://bugs.kde.org/show_bug.cgi?id=145237         




------- Additional Comments From marcel.wiesweg gmx de  2007-05-12 17:34 -------
SVN commit 663883 by mwiesweg:

Adapt the line step of the scroll bars to the zoom factor.
For low zoom factors, scrolling with the mouse wheel is still precise,
for higher zoom rates the steps get bigger.
This means the approx. the same amount of mouse wheel scrolling is required
for to scroll the same span in the original picture, regardless of zoom rate.

For the overall relative speed, I added a factor of 2 which feels good, please report
if scrolling steps are too big or too small.

(bug 145237, #4)

CCBUG: 145237


 M  +6 -0      previewwidget.cpp  


--- trunk/extragear/graphics/digikam/libs/widgets/common/previewwidget.cpp #663882:663883
 @ -219,6 +219,12  @
 
     updateContentsSize();
 
+    int step = QMAX(2, 2*lround(d->zoom));
+    horizontalScrollBar()->setLineStep( step );
+    horizontalScrollBar()->setPageStep( step * 10 );
+    verticalScrollBar()->setLineStep( step );
+    verticalScrollBar()->setPageStep( step * 10 );
+
     viewport()->setUpdatesEnabled(false);
     center((int)((cpx * d->tileSize ) / floor(d->tileSize / d->zoom)),
            (int)((cpy * d->tileSize ) / floor(d->tileSize / d->zoom)));
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
         
http://bugs.kde.org/show_bug.cgi?id=145237         




------- Additional Comments From caulier.gilles gmail com  2007-05-12 18:45 -------
>For the overall relative speed, I added a factor of 2 which feels good, please >report
>if scrolling steps are too big or too small.

Thanks Marcel for this fix. it sound fine for me.

Gerhard, can you give us your viewpoint ?

Gilles
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
         
http://bugs.kde.org/show_bug.cgi?id=145237         




------- Additional Comments From caulier.gilles gmail com  2007-05-12 18:50 -------
Marcel,

Like Image Editor Canvas and Image Preview are very similar, i suspect than canvas.cpp need to be patched in the same way. Right ?

To be honest, later 0.9.2, i will use ImagePreview class like parent of canvas to factorize implementation (:=)))

Gilles
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Arnd Baecker]

> >A very minor glitch: invoking the light-table  the first time
> >(or after emptying the light-table),
> >the "Forward" and "Last" buttons are not activated.
>
> No problem here. Checkout and try again.

Still here. To really observe this: restart digikam,
mark a few images in the album view and then invoke
the light-table with F6 (it does not show up
once the light-table has been activated once during
a digikam session).
Then all the Forward/Last (and First/Back, as it should be for
the first item) are disabled.

> Resynchronization of panels is fixed with commit #663723.

Yes and no ;-)
Namely, you solved the jump on slider move/zoom,
so that it jumps when one presses CTRL-SHIFT-Y.
However,
"it would be better if it behaves the following way: "
[ ... see the text I wrote under #15 above ...]
What do you think about that?

A cosmetic issue:
when panning (either with the mouse or scrollbars),
the horizontal (sometimes also the vertical)
slider of the other panel reduces its length
for a very short time (leading to some flickering
of the slider).
A similar flickering also arise when using
the zoom slider (but then for both joined images).

Best, Arnd
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Arnd Baecker]

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
         
http://bugs.kde.org/show_bug.cgi?id=145237         




------- Additional Comments From arnd.baecker web de  2007-05-12 20:50 -------
> >A very minor glitch: invoking the light-table  the first time
> >(or after emptying the light-table),
> >the "Forward" and "Last" buttons are not activated.
>
> No problem here. Checkout and try again.


Still here. To really observe this: restart digikam,
mark a few images in the album view and then invoke
the light-table with F6 (it does not show up
once the light-table has been activated once during
a digikam session).
Then all the Forward/Last (and First/Back, as it should be for
the first item) are disabled.

> Resynchronization of panels is fixed with commit #663723.


Yes and no ;-)
Namely, you solved the jump on slider move/zoom,
so that it jumps when one presses CTRL-SHIFT-Y.
However,
"it would be better if it behaves the following way: "
[ ... see the text I wrote under #15 above ...]
What do you think about that?

A cosmetic issue:
when panning (either with the mouse or scrollbars),
the horizontal (sometimes also the vertical)
slider of the other panel reduces its length
for a very short time (leading to some flickering
of the slider).
A similar flickering also arise when using
the zoom slider (but then for both joined images).

Best, Arnd
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
         
http://bugs.kde.org/show_bug.cgi?id=145237         




------- Additional Comments From caulier.gilles gmail com  2007-05-12 21:48 -------
Arnd,

Navigate by Pair feature is now implemented in svn. Checkout and try it.

> >A very minor glitch: invoking the light-table  the first time
> >(or after emptying the light-table),
> >the "Forward" and "Last" buttons are not activated.

ok, now i can reproduce. Something is not initialized properly. I will take a look.

Gilles
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
         
http://bugs.kde.org/show_bug.cgi?id=145237         
caulier.gilles gmail com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |RESOLVED
         Resolution|                            |FIXED



------- Additional Comments From caulier.gilles gmail com  2007-05-13 18:22 -------
> >A very minor glitch: invoking the light-table  the first time
> >(or after emptying the light-table),
> >the "Forward" and "Last" buttons are not activated.

Fixed in svn

Gilles
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Arnd Baecker]

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
         
http://bugs.kde.org/show_bug.cgi?id=145237         




------- Additional Comments From arnd.baecker web de  2007-05-13 19:26 -------
Gilles, thanks a lot - all works very fine!

Only remaining: Points a) from #0 and #15
(after: "it would be better if it behaves the following way: ").
This might need a separate discussion and input from other users -
should I create a new B.K.O.?
(this one got pretty long for "small" wishes ... ;-)
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel