[Bug 142457] New: temp files not cleaned up after crashes

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
         
http://bugs.kde.org/show_bug.cgi?id=142457         




------- Additional Comments From andi.clemens gmx net  2008-07-09 10:52 -------
I tested this and it is true: showFoto doesn't clean up the cache, even if it was closed properly, but digiKam does. If I kill digiKam while using image editor, it also doesn't clean the cache folder (sure, it has no time to do that).
But as mentioned before in this bugreport, showFoto really leaves the temp files in the kdecache folder!!

Simple test:
1. open showFoto
2. edit image
3. close showFoto without saving the image
4. look in temp folder

Tested it four times now, this is definitely true. We really need to make sure on startup if files are in the temp folder and clean it up manually... this should not be a big problem. Maybe this is fixed for KDE4 already, but KDE3 doesn't clean it up at all.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
         
http://bugs.kde.org/show_bug.cgi?id=142457         




------- Additional Comments From andi.clemens gmx net  2008-07-09 11:05 -------
Another comment: I have a separate var partition, because pacman (the package manager from archlinux) works better with JFS / XFS or ReiserFS, normally I use ext3. So I made a separate file-system for that.
After playing around with showFoto to test this case, the cache folder for showFoto contained 756 MB cache files!! Ok I'm working with high resolution images, but nevertheless if my partition would be full (and it nearly was), I might have lost my package managers database (happened once before, kdevelop flooded my temp folder that day).
So I really think this issue is important and should be fixed. I'll have a look at it...
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
         
http://bugs.kde.org/show_bug.cgi?id=142457         




------- Additional Comments From caulier.gilles gmail com  2008-07-09 11:11 -------
Andi,

If i remmember, we use KTempFile for that. there is a method named setAutoDelete(). Perhaps the problem is here.

Gilles Caulier
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
         
http://bugs.kde.org/show_bug.cgi?id=142457         




------- Additional Comments From sputnikshock gmail com  2008-07-09 11:19 -------
Just a 'thanks' to you, Andi! - This is excatly what happened to me. And as I had a smaller root partition on my laptop this regulary brought the system down. - Ofcourse the - system itself - (with no space available to save anything) what also had the sideefect of not being able to start X or the KDE-desktop anymore before cleaning up the cache...

Old bug though...

Thanks for regarding it!!!! :)
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
         
http://bugs.kde.org/show_bug.cgi?id=142457         




------- Additional Comments From andi.clemens gmx net  2008-07-09 11:49 -------
Created an attachment (id=25979)
 --> (http://bugs.kde.org/attachment.cgi?id=25979&action=view)
should fix the removing of cache files on normal close

somehow the closeEvent from imageeditor window is not processed by showfoto, I
put the essential code from closeEvent into the queryClose method of
showfoto... works fine.
Sure this doesn't solve the cleaning of the temp folder on startup, but it does
at least operate the normal way like digikam imageeditor.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
         
http://bugs.kde.org/show_bug.cgi?id=142457         




------- Additional Comments From caulier.gilles gmail com  2008-07-09 12:01 -------
Andi,

Patch fine for me.

Gilles
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
         
http://bugs.kde.org/show_bug.cgi?id=142457         




------- Additional Comments From caulier.gilles gmail com  2008-07-09 12:11 -------
Andi,

About the not cleaned tmp path when crash appear, i think there is a solution... Look into undocache.cpp code. When the instance of this class is created by UndoManager, this last one created by DImgInterface, a new cache tmp folder is created on the system (typically into /var/...)

The global idea is to register somewhere this path when new UndoManager instance is created. If crash appears, at the next session, we just need to check the last cache tmp folder and if it exist, just to remove it...

But take a care: this can be more complex than a simple string to record in digikamrc file (for ex., my first idea here), because, for showfoto or digiKam, more than one instance can be started at the same time... We need to record too the process id somewhere, or something like that...

Gilles
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
         
http://bugs.kde.org/show_bug.cgi?id=142457         




------- Additional Comments From caulier.gilles gmail com  2008-07-09 12:17 -------
With KDE4, it can be better to use KTemporaryFile class into UndoCache. look here :

http://api.kde.org/4.x-api/kdelibs-apidocs/kdecore/html/classKTemporaryFile.html

Gilles Caulier
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
         
http://bugs.kde.org/show_bug.cgi?id=142457         




------- Additional Comments From andi.clemens gmx net  2008-07-09 12:28 -------
SVN commit 829870 by aclemens:

cache files were not removed when closing showFoto because the closeEvent from ImageEditorWindow was not processed at all. This was fixed by putting all essential content of closeEvent() into the queryClose() method of showFoto.

 M  +4 -0      showfoto.cpp

WebSVN link: http://websvn.kde.org/?view=rev&revision=829870
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
         
http://bugs.kde.org/show_bug.cgi?id=142457         




------- Additional Comments From andi.clemens gmx net  2008-07-09 12:31 -------
Gilles,

in KDE4 showFoto is clearing up the cache folder on close. Although the queryClose() method is not changed at all... seems to be a KDE3 / Qt3 specific problem?
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
         
http://bugs.kde.org/show_bug.cgi?id=142457         




------- Additional Comments From caulier.gilles gmail com  2008-07-09 12:40 -------
Andi,

No sure... but i remember a similar problem with KDialog...

So, if you cannot confirm this, that fine for me.

Gilles
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
         
http://bugs.kde.org/show_bug.cgi?id=142457         




------- Additional Comments From andi.clemens gmx net  2008-07-22 02:50 -------
I think it is nearly impossible to solve the cleanup of left over cache files, because you can always have multiple instances of showFoto / digiKam running.
This makes it very hard to decide which files can be removed and which not.
If you want to be platform independent (every system has its own way of defining / getting process IDs), this can't be done... or I'm just not able to find a good solution.
I spent a lot of time on this now and somehow I'm tired of it. All in all this is KDE's fault, not digiKam, because the cache dirs are not cleanup on logout. This seems to be fixed in KDE4, so I will stop working on this for KDE3 branch.
One of the problems was that showFoto didn't cleanup cache files at all, even not on a clean shutdown of the program. This was fixed in the current SVN (and 0.9.4 final). But deleting old cache files (at least on logout) should be done by KDE itself...
So I'm thinking about closing this one now... Is this ok for you all?
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
         
http://bugs.kde.org/show_bug.cgi?id=142457         




------- Additional Comments From sputnikshock gmail com  2008-07-22 03:45 -------
Fixing ShowFoto might be a good step forward! - Thanks for your work and effort, Andi!
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
         
http://bugs.kde.org/show_bug.cgi?id=142457         




------- Additional Comments From caulier.gilles gmail com  2008-07-22 09:46 -------
Andi,

If you think than someting must be done in KDELibs, move thi sfile to the right bugzilla components of kdelibs section and wait and see comments from developpers.

Note: unforget to set the right email to re-route meesages at te right place.

Gilles
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel