[Bug 142443] New: red eye correction should change eye colour to an alternate colour

[Oliver Dörr]

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
         
http://bugs.kde.org/show_bug.cgi?id=142443         
           Summary: red eye correction should change eye colour to an
                    alternate colour
           Product: digikam
           Version: unspecified
          Platform: unspecified
        OS/Version: Linux
            Status: UNCONFIRMED
          Severity: wishlist
          Priority: NOR
         Component: general
        AssignedTo: digikam-devel kde org
        ReportedBy: oliver doerr-privat de


Version:           0.9.1-rc1 (using KDE 3.5.5, Kubuntu (edgy) 4:3.5.5-0ubuntu3.1)
Compiler:          Target: i486-linux-gnu
OS:                Linux (i686) release 2.6.17-11-generic

Hi,

using the red eye correction has a big problem. It takes the red out of the eye (great) and produces a "dark" eye (not good). It would be better if i could specify a target eye color, so that the tool moves the colour of the red aereas of the eye into that direction.

Would be perfect if i could choose another eye as target eye. Meaning that this eye has the colour there the red eye correction should move the eye colour to.

What do xou think
Oliver
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
         
http://bugs.kde.org/show_bug.cgi?id=142443         
caulier.gilles gmail com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Product|digikam                     |digikamimageplugins
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
         
http://bugs.kde.org/show_bug.cgi?id=142443         
caulier.gilles gmail com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
          Component|general                     |Core Plugin



------- Additional Comments From caulier.gilles gmail com  2007-03-03 09:24 -------
Hi Oliver (:=)))

I have planed to add coloring feature to red eyes correction tool later 0.9.1.

I'm study the right algorithm to do it. I will gve inspiration from ACDsee red Eye correction tool (if you know).

Gilles Caulier
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Oliver Dörr]

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
         
http://bugs.kde.org/show_bug.cgi?id=142443         




------- Additional Comments From oliver doerr-privat de  2007-03-03 14:36 -------
Hi Gilles,

i don't know ACDsee. The wish comes because my little son had a bithday party with a little girl with beautiful blue eyes ;-))

Oliver
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
         
http://bugs.kde.org/show_bug.cgi?id=142443         




------- Additional Comments From caulier.gilles gmail com  2007-03-04 21:50 -------
Created an attachment (id=19881)
 --> (http://bugs.kde.org/attachment.cgi?id=19881&action=view)
patch to coloring eyes with a custom color

Oliver,

attached a patch against svn to coloring the eyes with a custom color. The
color can be choosen from a button. The red color is changed to this color as
well.

The patch is experimental and not optimized. I have no "red eyes" photograph
here to test indeep, but i think it will work fine normally. If you have some
pictures to test, please attach it to this B.K.O file.

The color is not yet saved between plugin session. I will do it later if
algorithm work fine.

Thanks in advance for you report...

Gilles
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
         
http://bugs.kde.org/show_bug.cgi?id=142443         




------- Additional Comments From caulier.gilles gmail com  2007-03-04 21:53 -------
Oliver,

I have forget to said than the algorithm do not support yet 16 bits color depth images, only 8 bits...

It's few source code lines to do. I will do it later...

Gilles
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Oliver Dörr]

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
         
http://bugs.kde.org/show_bug.cgi?id=142443         




------- Additional Comments From oliver doerr-privat de  2007-03-04 22:01 -------
I have some Photos with red eyes...

But i don't know how to apply a patch to source code. Witch command do i have to use, i want to attach the patch against rc2?

Oliver
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

4 Mar 2007 21:01:49 -0000, Oliver Doerr <[hidden email]>:

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

http://bugs.kde.org/show_bug.cgi?id=142443




------- Additional Comments From oliver doerr-privat de  2007-03-04 22:01 -------
I have some Photos with red eyes...

 

fine

 

But i don't know how to apply a patch to source code. Witch command do i have to use,

 

it's very simple : copy the patch file into digikam/imageplugin folder and from the command line use "patch -p0 redeyes.patch".

Recompile and install the core plugin to run "make" and "make install" (as root of course) in this folder.

 

i want to attach the patch against rc2?

 

 

yes, normally patch can be applied against RC2 without problem.

 

Friendly

 

Gilles

_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
         
http://bugs.kde.org/show_bug.cgi?id=142443         




------- Additional Comments From caulier.gilles gmail com  2007-03-04 22:12 -------
4 Mar 2007 21:01:49 -0000, Oliver Doerr <oliver doerr-privat de>:
[bugs.kde.org quoted mail]


fine


But i don't know how to apply a patch to source code. Witch command do i
> have to use,



it's very simple : copy the patch file into digikam/imageplugin folder and
from the command line use "patch -p0 redeyes.patch".
Recompile and install the core plugin to run "make" and "make install" (as
root of course) in this folder.


 i want to attach the patch against rc2?



yes, normally patch can be applied against RC2 without problem.

Friendly

Gilles
<br><br>
<div><span class="gmail_quote">4 Mar 2007 21:01:49 -0000, Oliver Doerr &lt;<a href="mailto:oliver doerr-privat de">oliver doerr-privat de</a>&gt;:</span>
<blockquote class="gmail_quote" style="PADDING-LEFT: 1ex; MARGIN: 0px 0px 0px 0.8ex; BORDER-LEFT: #ccc 1px solid">------- You are receiving this mail because: -------<br>You are the assignee for the bug, or are watching the assignee.
<br><br><a href="http://bugs.kde.org/show_bug.cgi?id=142443">http://bugs.kde.org/show_bug.cgi?id=142443</a><br><br><br><br><br>------- Additional Comments From oliver doerr-privat de&nbsp;&nbsp;2007-03-04 22:01 -------<br>I have some Photos with red eyes...
</blockquote>
<div>&nbsp;</div>
<div>fine</div>
<div>&nbsp;</div><br>
<blockquote class="gmail_quote" style="PADDING-LEFT: 1ex; MARGIN: 0px 0px 0px 0.8ex; BORDER-LEFT: #ccc 1px solid">But i don&#39;t know how to apply a patch to source code. Witch command do i have to use,</blockquote>
<div>&nbsp;</div>
<div>it&#39;s very simple : copy the patch file into digikam/imageplugin folder and from the command line use &quot;patch -p0 redeyes.patch&quot;.</div>
<div>Recompile and install the core plugin to run &quot;make&quot; and &quot;make install&quot; (as root of course) in this folder.</div>
<div>&nbsp;</div><br>
<blockquote class="gmail_quote" style="PADDING-LEFT: 1ex; MARGIN: 0px 0px 0px 0.8ex; BORDER-LEFT: #ccc 1px solid"> i want to attach the patch against rc2?</blockquote>
<div>&nbsp;</div>
<div>&nbsp;</div>
<div>yes, normally patch can be applied against RC2 without problem.</div>
<div>&nbsp;</div>
<div>Friendly</div>
<div>&nbsp;</div>
<div>Gilles</div></div>
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Oliver Dörr]

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
         
http://bugs.kde.org/show_bug.cgi?id=142443         




------- Additional Comments From oliver doerr-privat de  2007-03-04 23:02 -------
Hi Gilles,

the command does not end. It looks like it does sweet nothing, because the timestamps of the files remain the same.

tmp/digikam-0.9.1-rc2/digikam/imageplugins$ patch -p0 redeyes.patch

I am tired now and go to bed. I will take a look at this tomorrow.

Oliver
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gerhard Kulzer]

Am Sunday 04 March 2007 schrieb Oliver Doerr:

> ------- You are receiving this mail because: -------
> You are the assignee for the bug, or are watching the assignee.
>
> http://bugs.kde.org/show_bug.cgi?id=142443
>
>
>
>
> ------- Additional Comments From oliver doerr-privat de  2007-03-04 23:02
> ------- Hi Gilles,
>
> the command does not end. It looks like it does sweet nothing, because the
> timestamps of the files remain the same.
>
> tmp/digikam-0.9.1-rc2/digikam/imageplugins$ patch -p0 redeyes.patch

the command syntax is patch -p0 < redeyes.patch

-p0 when the cwd matches the path in the patch header, -p1 if you're 1 level
up and so on.

Gerhard
>
> I am tired now and go to bed. I will take a look at this tomorrow.
>
> Oliver
> _______________________________________________
> Digikam-devel mailing list
> [hidden email]
> https://mail.kde.org/mailman/listinfo/digikam-devel



--
Hakuna matata
http://www.gerhard.fr

_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gerhard Kulzer]

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
         
http://bugs.kde.org/show_bug.cgi?id=142443         




------- Additional Comments From gerhard kulzer net  2007-03-05 06:11 -------
Am Sunday 04 March 2007 schrieb Oliver Doerr:
[bugs.kde.org quoted mail]

the command syntax is patch -p0 < redeyes.patch

-p0 when the cwd matches the path in the patch header, -p1 if you're 1 level
up and so on.

Gerhard
>
> I am tired now and go to bed. I will take a look at this tomorrow.
>
> Oliver
> _______________________________________________
> Digikam-devel mailing list
> Digikam-devel kde org
> https://mail.kde.org/mailman/listinfo/digikam-devel
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
         
http://bugs.kde.org/show_bug.cgi?id=142443         




------- Additional Comments From caulier.gilles gmail com  2007-03-05 08:47 -------
Gerhard,

Have you tried the patch ?

Gilles
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gerhard Kulzer]

Am Monday 05 March 2007 schrieb Gilles Caulier:

> ------- You are receiving this mail because: -------
> You are the assignee for the bug, or are watching the assignee.
>
> http://bugs.kde.org/show_bug.cgi?id=142443
>
>
>
>
> ------- Additional Comments From caulier.gilles gmail com  2007-03-05 08:47
> ------- Gerhard,
>
> Have you tried the patch ?
>

Yes I've tried it.

I think it's a step in the right direction, but there are still dark squares
visible after applying 'red eye'. If the selection was round instead of
square, that would be much better.

Gerhard

P.S. I posted 0.9.1 to our website

--
Hakuna matata
http://www.gerhard.fr

_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gerhard Kulzer]

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
         
http://bugs.kde.org/show_bug.cgi?id=142443         




------- Additional Comments From gerhard kulzer net  2007-03-05 09:55 -------
Am Monday 05 March 2007 schrieb Gilles Caulier:
[bugs.kde.org quoted mail]
Yes I've tried it.
I think it's a step in the right direction, but there are still dark squares
visible after applying 'red eye'. If the selection was round instead of
square, that would be much better.

Gerhard

P.S. I posted 0.9.1 to our website
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Arnd Baecker]

[...]
> but there are still dark squares
> visible after applying 'red eye'. If the selection was round instead of
> square, that would be much better.

Maybe then even a feathered selection (i.e. one with a smooth transparency
gradient to the outside) would be needed?
(just a thought, haven't tried anything like that)

_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Arnd Baecker]

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
         
http://bugs.kde.org/show_bug.cgi?id=142443         




------- Additional Comments From arnd.baecker web de  2007-03-05 11:48 -------
[...]
> but there are still dark squares
> visible after applying 'red eye'. If the selection was round instead of
> square, that would be much better.


Maybe then even a feathered selection (i.e. one with a smooth transparency
gradient to the outside) would be needed?
(just a thought, haven't tried anything like that)
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
         
http://bugs.kde.org/show_bug.cgi?id=142443         
caulier.gilles gmail com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #19881|0                           |1
        is obsolete|                            |
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
         
http://bugs.kde.org/show_bug.cgi?id=142443         




------- Additional Comments From caulier.gilles gmail com  2007-03-05 13:42 -------
Created an attachment (id=19884)
 --> (http://bugs.kde.org/attachment.cgi?id=19884&action=view)
2nd version of the patch to coloring red yes...

This second version of the patch support 16 bits color depth image and remember
coloring taint between tool session.

Next stage is to provide a preview of corrected image and a slider to set the
agressive red eyes correction level...

Gilles
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Oliver Dörr]

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
         
http://bugs.kde.org/show_bug.cgi?id=142443         




------- Additional Comments From oliver doerr-privat de  2007-03-05 17:17 -------
Hi Gilles,

tried the 1st version of the patch, but it's very difficult to handle. It's difficult to chose the right colour for the eye. Perhaps a colour picker would help, so that i could choose an eye of the person that has not the red eye effect...

Oliver
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel