[Bug 134308] Add arrow buttons on thumbnail to perform lossless rotation.

classic Classic list List threaded Threaded
3 messages Options
Reply | Threaded
Open this post in threaded view
|

[Bug 134308] Add arrow buttons on thumbnail to perform lossless rotation.

Gilles Caulier-4
https://bugs.kde.org/show_bug.cgi?id=134308


Gilles Caulier <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |RESOLVED
         Resolution|                            |FIXED




--- Comment #8 from Gilles Caulier <caulier gilles gmail com>  2009-06-01 08:45:51 ---
SVN commit 976164 by cgilles:

New overlay buttons over icon view item to rotate left/right images.
Transformations are lossless for jpeg :
we use kipi-plugin to rotate.
BUG: 134308


 M  +1 -0      CMakeLists.txt  
 M  +50 -5     digikam/digikamimageview.cpp  
 M  +6 -0      digikam/digikamimageview.h  
 AM            digikam/imagerotationoverlay.cpp   [License: GPL (v2+)]
 AM            digikam/imagerotationoverlay.h   [License: GPL (v2+)]


WebSVN link: http://websvn.kde.org/?view=rev&revision=976164

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel
Reply | Threaded
Open this post in threaded view
|

Re: [Bug 134308] Add arrow buttons on thumbnail to perform lossless rotation.

Bugzilla from mikmach@wp.pl
On Monday 01 June 2009 08:45:53 Gilles Caulier wrote:
> --- Comment #8 from Gilles Caulier <caulier gilles gmail com>  2009-06-01
> 08:45:51 --- SVN commit 976164 by cgilles:
>
> New overlay buttons over icon view item to rotate left/right images.
> Transformations are lossless for jpeg :
> we use kipi-plugin to rotate.

Great feature :)

Was testing it extensively for last few hours ;)

Few issues:

1. Is it possible to *not* show kipi dialog window at all? It flashes only for
few seconds or less so user will not be able to read what there is - please
show it only when bugs occurred.

2. Reproducible only in fullscreen (and not always so please try few times ;):
hover mouse over rotate icon to highlight it and move mouse away without
clicking - whole digikam window flashes or even became grey for second or two.

3. Inconsistency in hover actions:
a) select three images
b) perform rotate action
All three images will be rotated
But assign star rating - it will be assigned only to current image. IMO rating
should be assigned to all three images

Situation is more visible when after selection of those three images you will
hover mouse over fourth image. After clicking rotate icon in this fourth image
only images in selection will be rotated - but not image from where action was
called! Rating will be assigned only to this image - three previously selected
will be ignored. Fourth image - with "selected by hovering" should be treated
as fully selected (like with plus sign or Ctrl-click action).

m.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel
Reply | Threaded
Open this post in threaded view
|

Re: [Bug 134308] Add arrow buttons on thumbnail to perform lossless rotation.

Gilles Caulier-4
2009/6/1 Mikolaj Machowski <[hidden email]>:

> On Monday 01 June 2009 08:45:53 Gilles Caulier wrote:
>> --- Comment #8 from Gilles Caulier <caulier gilles gmail com>  2009-06-01
>> 08:45:51 --- SVN commit 976164 by cgilles:
>>
>> New overlay buttons over icon view item to rotate left/right images.
>> Transformations are lossless for jpeg :
>> we use kipi-plugin to rotate.
>
> Great feature :)
>
> Was testing it extensively for last few hours ;)
>
> Few issues:
>
> 1. Is it possible to *not* show kipi dialog window at all? It flashes only for
> few seconds or less so user will not be able to read what there is - please
> show it only when bugs occurred.
>

It's a limitation of libkipi. in fact, i would implement plugins
progress handling in host application...

It's in my to do list for the future.

> 2. Reproducible only in fullscreen (and not always so please try few times ;):
> hover mouse over rotate icon to highlight it and move mouse away without
> clicking - whole digikam window flashes or even became grey for second or two.

Not reproducible here with last code...

>
> 3. Inconsistency in hover actions:
> a) select three images
> b) perform rotate action
> All three images will be rotated

fixed.

> But assign star rating - it will be assigned only to current image. IMO rating
> should be assigned to all three images

No. on icon item where hover rating overlay appears. It's the same
behavior in Gwenview about rotation.

>
> Situation is more visible when after selection of those three images you will
> hover mouse over fourth image. After clicking rotate icon in this fourth image
> only images in selection will be rotated - but not image from where action was
> called! Rating will be assigned only to this image - three previously selected
> will be ignored. Fourth image - with "selected by hovering" should be treated
> as fully selected (like with plus sign or Ctrl-click action).
>

This point is fixed with my last commit. only icon where rotate button
is pressed will be rotated.

Pb : is selection is done before, it will be lost. kipi-plugins only
work with selection, so i need to deselect all and select only item
relevant before to run plugin.

It's a limitation of libkipi interface. this must be improved in the future.

Gilles
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel