Assign/Remove Tags menu screenshot

[Marcel Wiesweg]

Hi,

it is in svn for more than one week, but a screenshot has been missing until
today of the rewritten TagsPopupMenu:

http://digikam3rdparty.free.fr/Screenshots/tagspopupmenu1.png

This is implemented with QWidgetAction and custom drawing using QStyle methods
directly. It is a known bug that the 1-pixel frame is missing on the right
side.
I am thinking if the "Assign Tags" and "Remove Tags" menu can be unified in
one "Change Tags" menu. What do you think?

Marcel
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

Marcel Wiesweg wrote:
> it is in svn for more than one week, but a screenshot has been missing
> until today of the rewritten TagsPopupMenu:
>
> http://digikam3rdparty.free.fr/Screenshots/tagspopupmenu1.png
>
> This is implemented with QWidgetAction and custom drawing using QStyle
> methods directly. It is a known bug that the 1-pixel frame is missing on
> the right side.

Talking about tagging from the album view, I very much like an idea
mentioned in http://bugs.kde.org/show_bug.cgi?id=114465 "Simpler entry of
tags": Provide the same kind of widget used in kmail when you push "m" for
moving a mail to a folder. This would allow for fast tagging with the
keyboard, as it reduces a tree to all matching folders (-> tags) as you
type. Do you know, which one I am talking about, Marcel?

> I am thinking if the "Assign Tags" and "Remove Tags" menu can be unified
> in one "Change Tags" menu. What do you think?

Sounds like a good idea, judging from your screenshot.

Frank

_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

Frank Siegert wrote:
> Marcel Wiesweg wrote:
> Talking about tagging from the album view, I very much like an idea
> mentioned in http://bugs.kde.org/show_bug.cgi?id=114465 "Simpler entry of
> tags": Provide the same kind of widget used in kmail when you push "m" for
> moving a mail to a folder. This would allow for fast tagging with the
> keyboard, as it reduces a tree to all matching folders (-> tags) as you
> type. Do you know, which one I am talking about, Marcel?

To make that clearer: This wasn't meant to replace the menu you showed, but
as an additional means to tag a picture.

--
Frank

_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Marcel Wiesweg]

> Talking about tagging from the album view, I very much like an idea
> mentioned in http://bugs.kde.org/show_bug.cgi?id=114465 "Simpler entry of
> tags": Provide the same kind of widget used in kmail when you push "m" for
> moving a mail to a folder. This would allow for fast tagging with the
> keyboard, as it reduces a tree to all matching folders (-> tags) as you
> type. Do you know, which one I am talking about, Marcel?

I really see the need for improved tagging procedures, and everytime I tag a
large number of images I want to have free tagging by keyboard and tagging by
mouse click, not drag.
It's always the problem that there are so many features I want to have ;-)

Marcel
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

Marcel Wiesweg wrote:
> I really see the need for improved tagging procedures, and everytime I tag
> a large number of images I want to have free tagging by keyboard and
> tagging by mouse click, not drag.
> It's always the problem that there are so many features I want to have ;-)

Ok, I get the "broad hint"! ;-)

I wanted to play around a bit, to see whether I should tackle this idea, but
somehow I failed to compile digikam trunk with KDE4/Qt4. Are there
somewhere more detailed instructions for that?

To be more specific for people that want to help me out:
In Kubuntu, I have kdelibs and -dev installed (version 3.92, i.e. beta1),
which include a /usr/lib/kde4/share/apps/cmake/modules directory with lots
of .cmake files.

Now I checked out digikam:
  $ svn co svn://anonsvn.kde.org/home/kde/trunk/extragear/graphics/digikam

and in this directory I ran cmake:
  $ cmake .

This results in an error message
  .../digikam/data/icons/CMakeLists.txt:1:
  Unknown CMake command "KDE4_INSTALL_ICONS".

I can work around this, by
copying /usr/lib/kde4/share/apps/cmake/modules/KDE4Macros.cmake to the
digikam directory and adding INCLUDE(KDE4Macros.cmake) to CMakeLists.txt.
But then more errors appear:

  CMake Error: Error in cmake code at
  .../digikam/data/icons/CMakeLists.txt:1:
  KDE4_INSTALL_ICONS Macro invoked with incorrect arguments for macro named:
    KDE4_INSTALL_ICONS
  Current CMake stack: .../digikam/data/icons/CMakeLists.txt

  CMake Error: Error in cmake code at
  .../digikam/utilities/scripts/CMakeLists.txt:2:
  INSTALL PROGRAMS given no DESTINATION!
  Current CMake stack: .../digikam/utilities/scripts/CMakeLists.txt

And more similar errors (INSTALL PROGRAMS, INSTALL FILES, ...).

Now I am wondering, whether latter problems have something to do with the
first problem (not finding things like KDE4_INSTALL_ICONS in the first
place), and how I would solve this.

Thanks,
Frank

_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Marcel Wiesweg]

> Ok, I get the "broad hint"! ;-)
>
> I wanted to play around a bit, to see whether I should tackle this idea,
> but somehow I failed to compile digikam trunk with KDE4/Qt4. Are there
> somewhere more detailed instructions for that?

On techbase.kde.org there are some detailed instructions on how to set up a
KDE development environment. I have such a setup, including the additions
to .bashrc which make life easier.

http://techbase.kde.org/Getting_Started/Build/KDE4

>
> To be more specific for people that want to help me out:
> In Kubuntu, I have kdelibs and -dev installed (version 3.92, i.e. beta1),
> which include a /usr/lib/kde4/share/apps/cmake/modules directory with lots
> of .cmake files.
>
> Now I checked out digikam:
>   $ svn co svn://anonsvn.kde.org/home/kde/trunk/extragear/graphics/digikam
>
> and in this directory I ran cmake:
>   $ cmake .
>
> This results in an error message
>   .../digikam/data/icons/CMakeLists.txt:1:
>   Unknown CMake command "KDE4_INSTALL_ICONS".
>
> I can work around this, by
> copying /usr/lib/kde4/share/apps/cmake/modules/KDE4Macros.cmake to the
> digikam directory and adding INCLUDE(KDE4Macros.cmake) to CMakeLists.txt.

You certainly dont need to edit digikam's CMakeLists.txt if your setup is
correct...Have you the required version (> 2.4.5) of CMake installed?
CMake comes with a small KDE module which in turn locates the main KDE CMake
modules that comes with kdelibs (FindKDE4internal.cmake)
Have you set the KDEDIR variables?
With the bashrc additions mentioned above, I have always set:

export KDEDIR=/usr/kde/4.0
export PATH=$KDEDIR/bin:$PATH
export LD_LIBRARY_PATH=$KDEDIR/lib:$LD_LIBRARY_PATH
export QT_PLUGIN_PATH=$KDEDIR/lib/kde4/plugins
export KDEDIRS=$KDEDIR

export PKG_CONFIG_PATH=$KDEDIR/lib/pkgconfig:$PKG_CONFIG_PATH

# User
export KDEHOME=$HOME/.kde4
export KDETMP=/tmp/$USER-kde4
mkdir -p $KDETMP
export KDEVARTMP=/var/tmp/$USER-kde4

# build and src folders
# you might want to change these!
export KDE_BUILD=$HOME/freshmeat/multimedia/kde4/build
export KDE_SRC=$HOME/freshmeat/multimedia/kde4/src

> But then more errors appear:
>
>   CMake Error: Error in cmake code at
>   .../digikam/data/icons/CMakeLists.txt:1:
>   KDE4_INSTALL_ICONS Macro invoked with incorrect arguments for macro
> named: KDE4_INSTALL_ICONS
>   Current CMake stack: .../digikam/data/icons/CMakeLists.txt
>
>   CMake Error: Error in cmake code at
>   .../digikam/utilities/scripts/CMakeLists.txt:2:
>   INSTALL PROGRAMS given no DESTINATION!
>   Current CMake stack: .../digikam/utilities/scripts/CMakeLists.txt
>
> And more similar errors (INSTALL PROGRAMS, INSTALL FILES, ...).
>
> Now I am wondering, whether latter problems have something to do with the
> first problem (not finding things like KDE4_INSTALL_ICONS in the first
> place), and how I would solve this.
>
> Thanks,
> Frank

_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

Frank Siegert wrote:

> In Kubuntu, I have kdelibs and -dev installed (version 3.92, i.e. beta1),
> which include a /usr/lib/kde4/share/apps/cmake/modules directory with lots
> of .cmake files.
>
> Now I checked out digikam:
>   $ svn co svn://anonsvn.kde.org/home/kde/trunk/extragear/graphics/digikam
>
> and in this directory I ran cmake:
>   $ cmake .
>
> This results in an error message
>   .../digikam/data/icons/CMakeLists.txt:1:
>   Unknown CMake command "KDE4_INSTALL_ICONS".

I found the reason for this error:
One has to check out the trunk/extragear/graphics directory, and run cmake
from there, instead of only digikam. Is it really wise that way? Wouldn't
it be much easier if the digikam/CMakeLists.txt where set up in a way such
that digikam can be checked out standalone, and compiled from there?

Cheers,
Frank

_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

2007/8/11, Frank Siegert <[hidden email]>:

Marcel Wiesweg wrote:
> it is in svn for more than one week, but a screenshot has been missing
> until today of the rewritten TagsPopupMenu:
>
> http://digikam3rdparty.free.fr/Screenshots/tagspopupmenu1.png
>
> This is implemented with QWidgetAction and custom drawing using QStyle
> methods directly. It is a known bug that the 1-pixel frame is missing on
> the right side.

Talking about tagging from the album view, I very much like an idea
mentioned in http://bugs.kde.org/show_bug.cgi?id=114465 "Simpler entry of
tags": Provide the same kind of widget used in kmail when you push "m" for
moving a mail to a folder. This would allow for fast tagging with the
keyboard, as it reduces a tree to all matching folders (-> tags) as you
type. Do you know, which one I am talking about, Marcel?

> I am thinking if the "Assign Tags" and "Remove Tags" menu can be unified
> in one "Change Tags" menu. What do you think?

Sounds like a good idea, judging from your screenshot.

Agree with Franck. Merging Add and Remove tags sub-menu will be more clean for user.

Another idea is to limit tags entries when list is huge. The sub menu can be very big and become unsuitable. There is a bug in B.K.O about this subject.

A possible solution is to add the already used tags in first, the most recent tags used in second, and a menu entry to extend list for the rest (as M$ Windows do with "start" task bar button for ex.)

Your viewpoints ?

Gilles

_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel