Album GUI menu entries not disabled...

classic Classic list List threaded Threaded
4 messages Options
Reply | Threaded
Open this post in threaded view
|

Album GUI menu entries not disabled...

Gilles Caulier-4
Andi,

Go to an album and deselect all items. Go to Image menu and look like
these entries still available :

- Add to current queue
- Add to new queue

Now go to Album tree view and select "My Album". Look like these Album
menu entries still available:

- Refresh
- Sync image with DB
- Open in File manager

Gilles
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel
Reply | Threaded
Open this post in threaded view
|

Re: Album GUI menu entries not disabled...

Bugzilla from andi.clemens@gmx.net
I think this is due to the chances Marcel did some time ago.
I don't find the commit now, maybe he knows what this was?
Something about selectionChanged signals...

Andi

On Thursday 09 July 2009 12:32:44 Gilles Caulier wrote:

> Andi,
>
> Go to an album and deselect all items. Go to Image menu and look like
> these entries still available :
>
> - Add to current queue
> - Add to new queue
>
> Now go to Album tree view and select "My Album". Look like these Album
> menu entries still available:
>
> - Refresh
> - Sync image with DB
> - Open in File manager
>
> Gilles
> _______________________________________________
> Digikam-devel mailing list
> [hidden email]
> https://mail.kde.org/mailman/listinfo/digikam-devel

_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel
Reply | Threaded
Open this post in threaded view
|

Re: Album GUI menu entries not disabled...

Marcel Wiesweg
> I think this is due to the chances Marcel did some time ago.
> I don't find the commit now, maybe he knows what this was?
> Something about selectionChanged signals...
>
> >
> > Go to an album and deselect all items. Go to Image menu and look like
> > these entries still available :
> >
> > - Add to current queue
> > - Add to new queue

All these actions are enabled/disabled in DigikamApp::slotSelectionChanged,
digikamapp.cpp:387.
I did not add a remove any actions handled there, unless inadvertently.
d->imageAddCurrentQueueAction and d->imageAddNewQueueAction are indeed nowhere
enabled or disabled. Did this ever work?

> >
> > Now go to Album tree view and select "My Album". Look like these Album
> > menu entries still available:
> >
> > - Refresh
> > - Sync image with DB
> > - Open in File manager

This is not about image selection. DigikamApp::slotAlbumSelected?
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel
Reply | Threaded
Open this post in threaded view
|

Re: Album GUI menu entries not disabled...

Bugzilla from andi.clemens@gmx.net
Good question... but I guess I added something in the past, because
ContextMenuHelper needs to handle special cases like "no queue exists" and
such things.

I will take a look.

Andi

On Friday 10 July 2009 17:26:31 Marcel Wiesweg wrote:

> > I think this is due to the chances Marcel did some time ago.
> > I don't find the commit now, maybe he knows what this was?
> > Something about selectionChanged signals...
> >
> > > Go to an album and deselect all items. Go to Image menu and look like
> > > these entries still available :
> > >
> > > - Add to current queue
> > > - Add to new queue
>
> All these actions are enabled/disabled in DigikamApp::slotSelectionChanged,
> digikamapp.cpp:387.
> I did not add a remove any actions handled there, unless inadvertently.
> d->imageAddCurrentQueueAction and d->imageAddNewQueueAction are indeed
> nowhere enabled or disabled. Did this ever work?
>
> > > Now go to Album tree view and select "My Album". Look like these Album
> > > menu entries still available:
> > >
> > > - Refresh
> > > - Sync image with DB
> > > - Open in File manager
>
> This is not about image selection. DigikamApp::slotAlbumSelected?
> _______________________________________________
> Digikam-devel mailing list
> [hidden email]
> https://mail.kde.org/mailman/listinfo/digikam-devel

_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel