A note on sidebar widths

[Marcel Wiesweg]

Hi,

there had been some complaints about sidebar too large minimum sidebar widths
in 0.10, but looking at current trunk I think all widths are now back to
normal.

Just to put this information somewhere in the public, the current sidebar
minimum width status is this:
Sidebars are ~312 pixels minimum on both sides.
Included are 10px for the splitter handle and 30px for the tabbar.
Leaves 266 net space for sidebar widgets.
This minimum size is determined by the color and the GPS sidebar,
as the HistogramWidget, the CIETongueWidget and the WorldMapWidget all have
deliberately set a minimum size of 256. We could shrink minimum width by
reducing these three. I assume the next limiting factor will then be the
Caption/Tags tab.
However, I think there is good reason to have a certain minimum size for the
three widgets.

Marcel
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

2008/9/18 Marcel Wiesweg <[hidden email]>

Hi,

there had been some complaints about sidebar too large minimum sidebar widths
in 0.10, but looking at current trunk I think all widths are now back to
normal.

Just to put this information somewhere in the public, the current sidebar
minimum width status is this:
Sidebars are ~312 pixels minimum on both sides.
Included are 10px for the splitter handle and 30px for the tabbar.
Leaves 266 net space for sidebar widgets.
This minimum size is determined by the color and the GPS sidebar,
as the HistogramWidget, the CIETongueWidget and the WorldMapWidget all have
deliberately set a minimum size of 256. We could shrink minimum width by
reducing these three. I assume the next limiting factor will then be the
Caption/Tags tab.
However, I think there is good reason to have a certain minimum size for the
three widgets.

Marcel

Marcel,

There still something wrong with sidebar width, especially on right side. Look code from this method : SideBar::updateMinimumWidth()

This code must set the minimun width of sidebar container accordingly with minimum width of current widgets hosted in sidebar tabs. This is used in editor, when RawImport is load in sidebar. Settings from this tools take more space than the rest of tabs. So, the sidebar tab is adjusted accordingly...

But when RawImport tool is removed from sidebar, the minimal width must be actualized. SideBar::updateMinimumWidth() is called another time and sometime it's work, sometime no...

Any idea ?

Gilles

_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Marcel Wiesweg]

> Marcel,
>
> There still something wrong with sidebar width, especially on right side.
> Look code from this method : SideBar::updateMinimumWidth()
>
> This code must set the minimun width of sidebar container accordingly with
> minimum width of current widgets hosted in sidebar tabs. This is used in
> editor, when RawImport is load in sidebar. Settings from this tools take
> more space than the rest of tabs. So, the sidebar tab is adjusted
> accordingly...
>
> But when RawImport tool is removed from sidebar, the minimal width must be
> actualized. SideBar::updateMinimumWidth() is called another time and
> sometime it's work, sometime no...
>
> Any idea ?

I am wondering why is this call necessary at all? The stacked layout should
take care of any minimum requirements of contained widgets, does it not do
it?
Usually, when a widget is removed or added, the layout should be notified by
that and relayout?

>
> Gilles


_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

2008/9/18 Marcel Wiesweg <[hidden email]>

> Marcel,
>
> There still something wrong with sidebar width, especially on right side.
> Look code from this method : SideBar::updateMinimumWidth()
>
> This code must set the minimun width of sidebar container accordingly with
> minimum width of current widgets hosted in sidebar tabs. This is used in
> editor, when RawImport is load in sidebar. Settings from this tools take
> more space than the rest of tabs. So, the sidebar tab is adjusted
> accordingly...
>
> But when RawImport tool is removed from sidebar, the minimal width must be
> actualized. SideBar::updateMinimumWidth() is called another time and
> sometime it's work, sometime no...
>
> Any idea ?

I am wondering why is this call necessary at all? The stacked layout should
take care of any minimum requirements of contained widgets, does it not do
it?
Usually, when a widget is removed or added, the layout should be notified by
that and relayout?

Well, if you don't call SideBar::updateMinimumWidth() after to remove a tab (as RawImport), the minimal size to sidebar is fine, but sidebar still at the last width set by RawImport settings widget which is huge. you need to resize by hand. this is what i want to automatize.

Gilles

_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel